Issue metadata
Sign in to add a comment
|
10% Octane/Splay regression |
||||||||||||||||||||||
Issue description
,
Feb 14 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/14f000dd840000 Configure TaskScheduler to use one less worker than cores by default. by gab@chromium.org https://chromium.googlesource.com/chromium/src/+/f61636f214c9a53a91906a2ec4b35af511bb5b57 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Feb 14 2018
,
Feb 15 2018
Hey Ulan, looks like this graph is stalled on Feb 7th... Any idea? Michael says the "process" is that you go over these every now and then and re-enable them? https://chromeperf.appspot.com/report?sid=1baa537b4453e72066ada181dbd4d17629d5042e919106baf5d522ca6153f715
,
Feb 16 2018
,
Feb 19 2018
The expectations says that octane is disabled only on Android One: https://cs.chromium.org/chromium/src/tools/perf/expectations.config?rcl=ab50768732698a332158c88a87c2d07ed276c701&l=97 I don't see MacOs specific entry there. mac-12, mac-11-air, mac-11-pro are running Octane: https://chromeperf.appspot.com/report?sid=a9bb1f7ed447e4f2cd600eb4f7afca6e25181516e479da8af5369d477b181197 Ned, mac-11 machine is not running Octane benchmark since Feb 7. It doesn't seem to be disabled on mac-11. So looks like something is wrong with the config. Who is the owner of mac-11?
,
Feb 20 2018
I believe we are killing Mac 10-11 because the OS is outdated: issue 803851
,
Feb 20 2018
I see, that's too bad as the two retired configs (mac11 and Mac Retina) were the ones affected by this change... I assume we still have users there..? https://chromeperf.appspot.com/report?sid=87fb19da9c20efdfa22cce57fb69b64b88ad2d1d448bbb9d5e7c19ff0f147c54
,
Feb 20 2018
*gab: we have a small team, and cannot cover all the configs and still do an excellent job maintaining them. We have been talking to Mac team to come up with the plan in that bug.
,
Feb 20 2018
Ok thanks. @ulan: looks like Splay still hasn't recovered on AreWeFastYet [1]. Is it using v8 only or v8 in chrome? My CL was in chrome and only affects v8 when chrome is the platform. I would expect chrome+v8 to have recovered @ r536207. [1] https://arewefastyet.com/#machine=29&view=single&suite=octane&subtest=Splay
,
Feb 20 2018
gab@, AreWeFastYet runs d8 (i.e. v8 only).
,
Feb 20 2018
Ok then I don't know if we have the equivalent metric in our d8 dashboards but this is not my change nor has it recovered yet.
,
Feb 20 2018
I'll file separate issue for AreWeFast regression to avoid confusion.
,
Feb 20 2018
The chromium based regression was fixed, see 10.12 graph : https://chromeperf.appspot.com/report?sid=3f316e9899148a2c840432cc77f7013e90f5b0ef6a1236f5b536b5f6f03ed2ff&start_rev=528040&end_rev=537754 Regressed in chromium r534414, fixed in v8 8996e26 in chromium r536207. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Feb 14 2018