New issue
Advanced search Search tips

Issue 812156 link

Starred by 2 users
Status: Fixed
Owner:
ccameron@chromium.org
Closed: Feb 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
ccameron@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unwanted glimpse of avatar overlay is seen after clicking on sign in to chrome

Reported by pranjali...@etouch.net, Feb 14 2018 
Chrome Version: 66.0.3347.0 (Official Build) 3b9cfdda2eb80dab7457ec61e619dd910d194248-refs/heads/master@{#536620} (64 bit)
 
OS: Mac(10.12.6, 10.13.1, 10.13.4).

Steps to reproduce:
1. Launch chrome and click on avatar icon .
2. Click on ‘sign in to chrome’ button on avatar overlay and observe.

Actual: Unwanted glimpse of avatar overlay is seen after clicking on sign in to chrome button.
Expected: Glimpse of avatar overlay should not be seen.

This is Regression issue broken in 'M-66’ and will soon update other info. 
Good Build:66.0.3346.0 
Bad Build:66.0.3347.0
Actual_result.mov
1.9 MB View Download

Comment 1 by pranjali...@etouch.net, Feb 14 2018

Labels: hasbisect-per-revision RegressedIn-66 FoundIn-66 Target-66
Owner: ccameron@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 536429 (known good), but no later than 536430 (first known bad).

CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/46f115f22260093ee7bc2a8764adf64d9c48a612..0158ac8bd270408aa9f3b44e19524c5f8d54cb97

Suspect : https://chromium.googlesource.com/chromium/src/+/0158ac8bd270408aa9f3b44e19524c5f8d54cb97

@ ccameron:  Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Note: Issue is not seen on Windows(7,8,8.1,10) and Linux(14.04 LTS).

Kindly refer attached screen cast
Expected Result.mov
1.7 MB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a89487894c5c141e32bd716d72ce4e0f63800d4

commit 5a89487894c5c141e32bd716d72ce4e0f63800d4
Author: Christopher Cameron <ccameron@chromium.org>
Date: Mon Feb 19 09:03:23 2018

mac: Don't pause for frames with no frame sink

This should not have been removed in https://crrev.com/536430

Move tracking from RenderWidgetHostImpl (where it is tracked only in
non-viz mode) to BrowserCompositorView, where it is tracked in both
modes.

Bug: 772576,  812505 ,  812156 
Change-Id: I006c1c78f2dc148602f08253745993f8a57a7e16
Reviewed-on: https://chromium-review.googlesource.com/923379
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537604}
[modify] https://crrev.com/5a89487894c5c141e32bd716d72ce4e0f63800d4/content/browser/renderer_host/browser_compositor_view_mac.mm

Comment 3 by ccameron@chromium.org, Feb 21 2018

Status: Fixed (was: Assigned)

Comment 4 by ccameron@chromium.org, Feb 21 2018

Cc: ccameron@chromium.org
 Issue 814147  has been merged into this issue.

Comment 5 by pranjali...@etouch.net, Feb 22 2018

Labels: TE-Verified-M66 TE-Verified-66.0.3352.0
Update : 
Verified above issue in latest Canary #66.0.3352.0 build on Mac(10.12.6, 10.13.1, 10.13.4) OS and the issue is fixed. The fix is working as intended. Kindly review an attached screencast.

Thank you!
Canary_behaviour.mov
4.3 MB View Download
►

Sign in to add a comment