New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 812152 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 924445



Sign in to add a comment

[servo] build unittest functionality into hdctools/servo

Project Member Reported by coconutruben@chromium.org, Feb 14 2018

Issue description

This bug is to track efforts to make hdctools/servo at least conform to our unittest guidelines namely
- add a python unittest runner into setup.py
- add src_test to hdctools ebuild to properly run these unittests
- slowly add unittests to each driver, and servod logic
 
Labels: -Pri-3 Pri-2
Owner: coconutruben@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3fd39f857345e0e550ea16881bc3c4dd6fae575f

commit 3fd39f857345e0e550ea16881bc3c4dd6fae575f
Author: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Date: Thu May 31 03:38:55 2018

hdctools: add testing state for python tests

this CL adds testing for the hdctools package by allowing FEATURES=test
to be used to automatically detect and run python unit-tests and pytest
tests written in the hdctools package.

BUG=chromium:812152
TEST=manual
cros_workon --host start hdctools
sudo FEATURES=test emerge hdctools

Change-Id: Ib87949288b8ee810cc9b48b4e64e67cdc1e12bae
Reviewed-on: https://chromium-review.googlesource.com/1078607
Commit-Ready: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Tested-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/3fd39f857345e0e550ea16881bc3c4dd6fae575f/dev-util/hdctools/hdctools-9999.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/7035f9b188ab52ee2e2f16b1a031c86d3d78a707

commit 7035f9b188ab52ee2e2f16b1a031c86d3d78a707
Author: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Date: Thu Aug 23 14:37:16 2018

servod: system config map & input_type

This CL reshuffles the logic inside resolve_val in system_config to
allow for mapped values to also leverage input_type.
This means that if for
dut-control random_ctrl:val
|val| maps to "1.2" then the float 1.2 will be passed to the set method.

It also starts the process of adding unittests to system_config.py

BUG=chromium:806148, chromium:812152
TEST=manual testing

Change-Id: I1a4590b22b8d7003454d51b040cfa4ba5105c7c7
Reviewed-on: https://chromium-review.googlesource.com/1168270
Commit-Ready: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Tested-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/7035f9b188ab52ee2e2f16b1a031c86d3d78a707/servo/system_config.py
[add] https://crrev.com/7035f9b188ab52ee2e2f16b1a031c86d3d78a707/servo/system_config_unittest.py

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/ec51041b477d832557db7f8435d16e63b0e1305a

commit ec51041b477d832557db7f8435d16e63b0e1305a
Author: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Date: Mon Sep 24 13:49:53 2018

servo: add configuration integration test

This generates a host of tests to validate the integrity of servo/data
configuration files.
The tests validate each control, map, and include being structured
properly, as well as some cross-reference validation, such as making
sure that maps used are defined somewhere, and include files exist.

Note: the current 4 failures are due to power XML files being imported,
but those only being generated in the build stage.
A TODO is left in data_integrity_test to allow to run outside of the
ebuild by builing the data-package in a temporary directory.
However, this does not break the FEATURES=test flow.

BUG=chromium:812152
TEST=manual
py.test data_integrity_test.py
...
4 failed, 8153 passed, 3499 skipped in 13.77 seconds

Change-Id: I2db9dcd52af8623071588d91dab663062671a07f
Signed-off-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1078588
Reviewed-by: Todd Broch <tbroch@chromium.org>

[add] https://crrev.com/ec51041b477d832557db7f8435d16e63b0e1305a/servo/data/data_integrity_test.py
[modify] https://crrev.com/ec51041b477d832557db7f8435d16e63b0e1305a/servo/data/cr50.xml
[modify] https://crrev.com/ec51041b477d832557db7f8435d16e63b0e1305a/servo/data/servo_micro.xml

Components: Tools>ChromeOSDebugBoards

Comment 6 by coconutruben@chromium.org, Today (7 hours ago)

Blockedon: 924445

Sign in to add a comment