New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 812150 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

[servo] tracker bug to bring code to conform to style guideline

Project Member Reported by coconutruben@chromium.org, Feb 14 2018

Issue description

The servo directory does not follow the Chromium OS style guide.
https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/master/servo/

This bug is to track efforts to make the code conform with the chromium os style guidelines for python.
https://www.chromium.org/chromium-os/python-style-guidelines
The one caveat here is that code to determine what command to execute, needs to follow the form as outlined in
https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/master/servo/drv/hw_driver.py

 

Comment 1 by tbroch@chromium.org, Mar 23 2018

Status: Available (was: Unconfirmed)

Comment 2 by puthik@google.com, Mar 23 2018

I happened to know some Google3 tool that did exactly this.

/google/data/ro/projects/devtools/pyformat/pyformat -i --force_quote_type single -s 2 -r ~/chromiumos/src/third_party/hdctools/servo

https://crrev.com/c/978955 should did 90% of the job here.

Comment 3 by puthik@google.com, Mar 27 2018

Apparently #c2 command make method declaration looks bad. Here is the better command to use.

/google/data/ro/projects/devtools/pyformat/pyformat -i --force_quote_type single -s 2 --binpack_named_arguments -r ~/chromiumos/src/third_party/hdctools/servo 
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/01ead1517f025f2066d7044001d7f30d54127e5a

commit 01ead1517f025f2066d7044001d7f30d54127e5a
Author: Puthikorn Voravootivat <puthik@chromium.org>
Date: Tue Mar 27 21:58:15 2018

servo: Format servo code to conform style guide

Format code to conform with style guide below.
https://www.chromium.org/chromium-os/python-style-guidelines

BUG=chromium:812150
TEST=build

Change-Id: Ie1490da190c1bfe9ad65a2beee8a01d9c88cdc43
Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/978955
Tested-by: Todd Broch <tbroch@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/multiservo.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/servo_server.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/scripts/servo_mfg/pty_driver.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/veyron_mickey_power.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/scripts/servoflex_test_v2.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/kitty_power.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/scripts/servo_mfg/mfg_servo_micro.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/ec3po_driver.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/bbi2c.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/cr50.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/scripts/servo_mfg/mfg_servo_common.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/fw_wp_state.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/ina231.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/m24c02.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/ec_lm4.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/dut_control.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/ina219.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/uart.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/scripts/servo_mfg/mfg_servo_v4.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/pty_driver.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/bbgpio.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/bbi2c_unittests.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/kb.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/ec3po_servo_micro.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/daisy_power.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/arm_ec.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/pca95xx.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/ltc1663.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/bbuart_unittests.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/ec3po_servo_v4.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/bbadc.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/ftdigpio.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/loglevel.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/ftdi_utils.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/client.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/scripts/tps65090_power.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/stm32uart.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/stm32i2c.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/lcm2004.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/stm32usb.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/pca9546.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/cros_chip.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/servo_metadata.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/stm32gpio.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/uart.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/cros_ec_softrec_power.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/larvae_adc.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/fw_wp_ccd.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/ec.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/ec3po_gpio.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/ina2xx.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/stumpy_power.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/ps8742.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/system_config.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/hw_driver.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/veyron_chromebox_power.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/bbuart.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/servod.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/ftdi_common.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/gpio_interface.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/scripts/servo_mfg/stm32usb.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/daisy_ec.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/tca6416.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/ad5248.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/servo_postinit.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/gpio.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/tcs3414.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/pca9500.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/parrot_ec.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/cros_ec_hardrec_power.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/i2c_reg.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/sx1505.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/ftdiuart.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/power_tools.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/scripts/servo_mfg/stm32uart.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/veyron_rialto_power.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/keyboard_handlers.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/cros_ec_power.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/ec3po_interface.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/servo_interfaces.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/sx1506.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/bbmux_controller.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/ap.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/ina3221.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/pca9537.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/bbgpio_unittests.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/beltino_power.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/i2cbus.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/bbmux_controller_unitttests.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/ftdii2c.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/cros_ec_pd_softrec_power.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/power_state.py
[modify] https://crrev.com/01ead1517f025f2066d7044001d7f30d54127e5a/servo/drv/plankton.py

Sign in to add a comment