New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 812122 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Webkit layout tests should not be supported

Project Member Reported by st...@chromium.org, Feb 14 2018

Issue description

Page URL: https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/28943

 Description:
Heuristic analysis caused false positives easily, because currently the whole stdout is used to extract signals.

The blacklist seems not work well because the step name keeps changing.
Chan, does it worth a temporary fix to blacklist all webkit layout test? How far are we from supporting webkit output format?
 

Comment 1 by chanli@chromium.org, Feb 14 2018

I'm suspecting the blacklist doesn't work because we are checking full step_name instead of canonical step_name. I need to look into the code but right now it seems easy to fix.

I think the new parser for json_test_results_format should be fully ready in 2~3 weeks. 

Comment 2 by st...@chromium.org, Feb 14 2018

Does it worth to make the blacklist a regex instead of a full string equal?

Comment 3 by chanli@chromium.org, Feb 14 2018

My plan was to use canonical step name instead of full step name when check if a step is supported or not.

Comment 4 by st...@chromium.org, Feb 14 2018

SG. That would work, and is better.
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8dc625f6725b4d398219315c3dca34a359d39d53

commit 8dc625f6725b4d398219315c3dca34a359d39d53
Author: Chan <chanli@chromium.org>
Date: Tue Feb 20 19:00:41 2018

[Findit] Use canonical step_name to decide if Findit supports a step or not.

This change will make Findit to check a step's canonical name to decide if the step is supported or not.

The supported value will also be saved in failure info so that Findit doesn't need to check with config repeatedly in different steps of analysis.

Bug:  812122 
Change-Id: I347b370491973f2333dcfd61f6e2a116ad88067e
Reviewed-on: https://chromium-review.googlesource.com/920386
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/8dc625f6725b4d398219315c3dca34a359d39d53/appengine/findit/services/compile_failure/test/compile_try_job_test.py
[modify] https://crrev.com/8dc625f6725b4d398219315c3dca34a359d39d53/appengine/findit/services/compile_failure/compile_failure_analysis.py
[modify] https://crrev.com/8dc625f6725b4d398219315c3dca34a359d39d53/appengine/findit/services/ci_failure.py
[modify] https://crrev.com/8dc625f6725b4d398219315c3dca34a359d39d53/appengine/findit/services/build_failure_analysis.py
[modify] https://crrev.com/8dc625f6725b4d398219315c3dca34a359d39d53/appengine/findit/services/compile_failure/compile_try_job.py
[modify] https://crrev.com/8dc625f6725b4d398219315c3dca34a359d39d53/appengine/findit/services/parameters.py
[modify] https://crrev.com/8dc625f6725b4d398219315c3dca34a359d39d53/appengine/findit/services/compile_failure/test/extract_compile_signal_test.py
[modify] https://crrev.com/8dc625f6725b4d398219315c3dca34a359d39d53/appengine/findit/services/test_failure/test_failure_analysis.py
[modify] https://crrev.com/8dc625f6725b4d398219315c3dca34a359d39d53/appengine/findit/services/test_failure/extract_test_signal.py
[modify] https://crrev.com/8dc625f6725b4d398219315c3dca34a359d39d53/appengine/findit/services/test/build_failure_analysis_test.py
[modify] https://crrev.com/8dc625f6725b4d398219315c3dca34a359d39d53/appengine/findit/services/compile_failure/test/compile_failure_analysis_test.py
[modify] https://crrev.com/8dc625f6725b4d398219315c3dca34a359d39d53/appengine/findit/services/test/ci_failure_test.py
[modify] https://crrev.com/8dc625f6725b4d398219315c3dca34a359d39d53/appengine/findit/services/compile_failure/extract_compile_signal.py
[modify] https://crrev.com/8dc625f6725b4d398219315c3dca34a359d39d53/appengine/findit/waterfall/build_util.py
[modify] https://crrev.com/8dc625f6725b4d398219315c3dca34a359d39d53/appengine/findit/services/test_failure/test/ci_test_failure_test.py
[modify] https://crrev.com/8dc625f6725b4d398219315c3dca34a359d39d53/appengine/findit/services/test_failure/test/test_failure_analysis_test.py
[modify] https://crrev.com/8dc625f6725b4d398219315c3dca34a359d39d53/appengine/findit/services/test_failure/test/extract_test_signal_test.py

Comment 6 by chanli@chromium.org, Feb 20 2018

Status: Fixed (was: Assigned)

Sign in to add a comment