New issue
Advanced search Search tips

Issue 812099 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Task

Blocking:
issue 773928



Sign in to add a comment

[Print Preview componentization]: Add system dialog link

Project Member Reported by rbpotter@chromium.org, Feb 14 2018 
Add "Print with system dialog" link to the componentized Print Preview page and correctly handle system dialog printing for both Windows and non-Windows.

Also add "Open PDF in Preview" link on Mac, and correctly handle opening PDF in Preview app.

Comment 1 by rbpotter@chromium.org, Feb 14 2018

Description: Show this description

Comment 2 by rbpotter@chromium.org, Feb 14 2018

Blocking: 773928
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25671885ba7b256b1a143c95bc8372026fd9db7d

commit 25671885ba7b256b1a143c95bc8372026fd9db7d
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Mar 30 03:07:01 2018

Print Preview Componentization: Add system dialog links

Bug: 773928,  812099 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I861a40dff62c4a4fd2929ff5644a23ebad0334b7
Reviewed-on: https://chromium-review.googlesource.com/971467
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547092}
[modify] https://crrev.com/25671885ba7b256b1a143c95bc8372026fd9db7d/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/25671885ba7b256b1a143c95bc8372026fd9db7d/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/25671885ba7b256b1a143c95bc8372026fd9db7d/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[add] https://crrev.com/25671885ba7b256b1a143c95bc8372026fd9db7d/chrome/browser/resources/print_preview/new/link_container.html
[add] https://crrev.com/25671885ba7b256b1a143c95bc8372026fd9db7d/chrome/browser/resources/print_preview/new/link_container.js
[modify] https://crrev.com/25671885ba7b256b1a143c95bc8372026fd9db7d/chrome/browser/resources/print_preview/new/model.js
[modify] https://crrev.com/25671885ba7b256b1a143c95bc8372026fd9db7d/chrome/browser/resources/print_preview/new/preview_area.js
[modify] https://crrev.com/25671885ba7b256b1a143c95bc8372026fd9db7d/chrome/browser/resources/print_preview/new/state.js
[modify] https://crrev.com/25671885ba7b256b1a143c95bc8372026fd9db7d/chrome/browser/resources/print_preview/print_preview_resources.grd
[add] https://crrev.com/25671885ba7b256b1a143c95bc8372026fd9db7d/chrome/test/data/webui/print_preview/link_container_test.js
[modify] https://crrev.com/25671885ba7b256b1a143c95bc8372026fd9db7d/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[add] https://crrev.com/25671885ba7b256b1a143c95bc8372026fd9db7d/chrome/test/data/webui/print_preview/system_dialog_browsertest.js

Comment 4 by rbpotter@chromium.org, Apr 4 2018

Status: Fixed (was: Available)
►

Sign in to add a comment