New issue
Advanced search Search tips

Issue 812097 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Task

Blocking:
issue 773928



Sign in to add a comment

[Print Preview componentization]: Add provisional destination resolver

Project Member Reported by rbpotter@chromium.org, Feb 14 2018

Issue description

Add provisional destination resolver overlay and correctly handle provisional destinations in the componentized Print Preview page.
 
Blocking: 773928
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eaee0041fc658d2744d86ac786e6fe470ca8ccdc

commit eaee0041fc658d2744d86ac786e6fe470ca8ccdc
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Apr 13 15:35:24 2018

Print Preview Componentization: Add provisional destination resolver

Bug:  812097 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic15ae3735c82875759bf67be8e64bd5beeb7ecb0
Reviewed-on: https://chromium-review.googlesource.com/996301
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550626}
[modify] https://crrev.com/eaee0041fc658d2744d86ac786e6fe470ca8ccdc/chrome/browser/resources/print_preview/data/destination_store.js
[modify] https://crrev.com/eaee0041fc658d2744d86ac786e6fe470ca8ccdc/chrome/browser/resources/print_preview/new/button_css.html
[modify] https://crrev.com/eaee0041fc658d2744d86ac786e6fe470ca8ccdc/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/eaee0041fc658d2744d86ac786e6fe470ca8ccdc/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/eaee0041fc658d2744d86ac786e6fe470ca8ccdc/chrome/browser/resources/print_preview/new/destination_dialog.js
[modify] https://crrev.com/eaee0041fc658d2744d86ac786e6fe470ca8ccdc/chrome/browser/resources/print_preview/new/destination_list.js
[modify] https://crrev.com/eaee0041fc658d2744d86ac786e6fe470ca8ccdc/chrome/browser/resources/print_preview/new/destination_list_item.js
[add] https://crrev.com/eaee0041fc658d2744d86ac786e6fe470ca8ccdc/chrome/browser/resources/print_preview/new/provisional_destination_resolver.html
[add] https://crrev.com/eaee0041fc658d2744d86ac786e6fe470ca8ccdc/chrome/browser/resources/print_preview/new/provisional_destination_resolver.js
[modify] https://crrev.com/eaee0041fc658d2744d86ac786e6fe470ca8ccdc/chrome/browser/resources/print_preview/new/search_dialog_css.html
[modify] https://crrev.com/eaee0041fc658d2744d86ac786e6fe470ca8ccdc/chrome/browser/resources/print_preview/print_preview_resources.grd

Status: Fixed (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eaee0041fc658d2744d86ac786e6fe470ca8ccdc

commit eaee0041fc658d2744d86ac786e6fe470ca8ccdc
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Apr 13 15:35:24 2018

Print Preview Componentization: Add provisional destination resolver

Bug:  812097 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic15ae3735c82875759bf67be8e64bd5beeb7ecb0
Reviewed-on: https://chromium-review.googlesource.com/996301
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550626}
[modify] https://crrev.com/eaee0041fc658d2744d86ac786e6fe470ca8ccdc/chrome/browser/resources/print_preview/data/destination_store.js
[modify] https://crrev.com/eaee0041fc658d2744d86ac786e6fe470ca8ccdc/chrome/browser/resources/print_preview/new/button_css.html
[modify] https://crrev.com/eaee0041fc658d2744d86ac786e6fe470ca8ccdc/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/eaee0041fc658d2744d86ac786e6fe470ca8ccdc/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/eaee0041fc658d2744d86ac786e6fe470ca8ccdc/chrome/browser/resources/print_preview/new/destination_dialog.js
[modify] https://crrev.com/eaee0041fc658d2744d86ac786e6fe470ca8ccdc/chrome/browser/resources/print_preview/new/destination_list.js
[modify] https://crrev.com/eaee0041fc658d2744d86ac786e6fe470ca8ccdc/chrome/browser/resources/print_preview/new/destination_list_item.js
[add] https://crrev.com/eaee0041fc658d2744d86ac786e6fe470ca8ccdc/chrome/browser/resources/print_preview/new/provisional_destination_resolver.html
[add] https://crrev.com/eaee0041fc658d2744d86ac786e6fe470ca8ccdc/chrome/browser/resources/print_preview/new/provisional_destination_resolver.js
[modify] https://crrev.com/eaee0041fc658d2744d86ac786e6fe470ca8ccdc/chrome/browser/resources/print_preview/new/search_dialog_css.html
[modify] https://crrev.com/eaee0041fc658d2744d86ac786e6fe470ca8ccdc/chrome/browser/resources/print_preview/print_preview_resources.grd

Sign in to add a comment