New issue
Advanced search Search tips

Issue 812095 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Task

Blocking:
issue 773928



Sign in to add a comment

[Print Preview componentization]: Add custom margins

Project Member Reported by rbpotter@chromium.org, Feb 14 2018

Issue description

Add custom margins controls to the componentized print preview UI.
 
Blocking: 773928
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97b85948f63bd07ff0995cb2adbab8d6d8fd6ecb

commit 97b85948f63bd07ff0995cb2adbab8d6d8fd6ecb
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Mar 13 21:35:09 2018

Print Preview Componentization: Add custom margins controls

Make controls appear on preview area when custom margins is selected.
Controls do not yet work.

Bug: 773928,  812095 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia0319b743736717f94af65c3ef364b65f2193571
Reviewed-on: https://chromium-review.googlesource.com/935681
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542918}
[modify] https://crrev.com/97b85948f63bd07ff0995cb2adbab8d6d8fd6ecb/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[add] https://crrev.com/97b85948f63bd07ff0995cb2adbab8d6d8fd6ecb/chrome/browser/resources/print_preview/new/margin_control.html
[add] https://crrev.com/97b85948f63bd07ff0995cb2adbab8d6d8fd6ecb/chrome/browser/resources/print_preview/new/margin_control.js
[add] https://crrev.com/97b85948f63bd07ff0995cb2adbab8d6d8fd6ecb/chrome/browser/resources/print_preview/new/margin_control_container.html
[add] https://crrev.com/97b85948f63bd07ff0995cb2adbab8d6d8fd6ecb/chrome/browser/resources/print_preview/new/margin_control_container.js
[modify] https://crrev.com/97b85948f63bd07ff0995cb2adbab8d6d8fd6ecb/chrome/browser/resources/print_preview/new/preview_area.html
[modify] https://crrev.com/97b85948f63bd07ff0995cb2adbab8d6d8fd6ecb/chrome/browser/resources/print_preview/new/preview_area.js
[modify] https://crrev.com/97b85948f63bd07ff0995cb2adbab8d6d8fd6ecb/chrome/browser/resources/print_preview/print_preview_resources.grd

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b656a14d3b0361dddc27b2e99d16ee108b601b2f

commit b656a14d3b0361dddc27b2e99d16ee108b601b2f
Author: rbpotter <rbpotter@chromium.org>
Date: Sat Mar 17 00:52:23 2018

Print Preview Componentization: Make custom margins movable

Make custom margins draggable and allow for updates with text boxes.
Does not yet update margins ticket item or limit margins values based
on page size.

Bug: 773928,  812095 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifa0e270bb32cc77c420788dae2daecf7817c063f
Reviewed-on: https://chromium-review.googlesource.com/961483
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543892}
[modify] https://crrev.com/b656a14d3b0361dddc27b2e99d16ee108b601b2f/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/b656a14d3b0361dddc27b2e99d16ee108b601b2f/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/b656a14d3b0361dddc27b2e99d16ee108b601b2f/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/b656a14d3b0361dddc27b2e99d16ee108b601b2f/chrome/browser/resources/print_preview/new/margin_control.html
[modify] https://crrev.com/b656a14d3b0361dddc27b2e99d16ee108b601b2f/chrome/browser/resources/print_preview/new/margin_control.js
[modify] https://crrev.com/b656a14d3b0361dddc27b2e99d16ee108b601b2f/chrome/browser/resources/print_preview/new/margin_control_container.html
[modify] https://crrev.com/b656a14d3b0361dddc27b2e99d16ee108b601b2f/chrome/browser/resources/print_preview/new/margin_control_container.js
[modify] https://crrev.com/b656a14d3b0361dddc27b2e99d16ee108b601b2f/chrome/browser/resources/print_preview/new/preview_area.html
[modify] https://crrev.com/b656a14d3b0361dddc27b2e99d16ee108b601b2f/chrome/browser/resources/print_preview/new/preview_area.js

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55cbc9d778e123931b1a2901a07e25a4950f8a31

commit 55cbc9d778e123931b1a2901a07e25a4950f8a31
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Mar 30 20:31:53 2018

Print Preview Componentization: Update custom margins model, add errors

Update the model with the custom margins values, correctly initialize
custom margins values, and add error handling. Correctly update header/
footer availability based on margins.

Bug: 773928,  812095 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia67e3055cd05e9cdacd29dfd1a809f7a9f1e1c8b
Reviewed-on: https://chromium-review.googlesource.com/967541
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547259}
[modify] https://crrev.com/55cbc9d778e123931b1a2901a07e25a4950f8a31/chrome/browser/resources/print_preview/data/margins.js
[modify] https://crrev.com/55cbc9d778e123931b1a2901a07e25a4950f8a31/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/55cbc9d778e123931b1a2901a07e25a4950f8a31/chrome/browser/resources/print_preview/new/input_behavior.js
[modify] https://crrev.com/55cbc9d778e123931b1a2901a07e25a4950f8a31/chrome/browser/resources/print_preview/new/margin_control.html
[modify] https://crrev.com/55cbc9d778e123931b1a2901a07e25a4950f8a31/chrome/browser/resources/print_preview/new/margin_control.js
[modify] https://crrev.com/55cbc9d778e123931b1a2901a07e25a4950f8a31/chrome/browser/resources/print_preview/new/margin_control_container.html
[modify] https://crrev.com/55cbc9d778e123931b1a2901a07e25a4950f8a31/chrome/browser/resources/print_preview/new/margin_control_container.js
[modify] https://crrev.com/55cbc9d778e123931b1a2901a07e25a4950f8a31/chrome/browser/resources/print_preview/new/model.js
[modify] https://crrev.com/55cbc9d778e123931b1a2901a07e25a4950f8a31/chrome/browser/resources/print_preview/new/preview_area.html
[modify] https://crrev.com/55cbc9d778e123931b1a2901a07e25a4950f8a31/chrome/browser/resources/print_preview/new/preview_area.js

Status: Fixed (was: Available)

Sign in to add a comment