Add the advanced settings dialog for displaying additional cloud printer options to the new print preview UI.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c212d47a0f03d5b2024bcc98cb7a9e0ad8725add commit c212d47a0f03d5b2024bcc98cb7a9e0ad8725add Author: rbpotter <rbpotter@chromium.org> Date: Sat Feb 17 03:52:19 2018 Print Preview Componentization: Add advanced settings Refactor cr-dialog styling from destination settings dialog and share with advanced settings. Bug: 773928, 812092 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I870d5831983af5fca56986314f06deb87dc9b242 Reviewed-on: https://chromium-review.googlesource.com/920775 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#537522} [modify] https://crrev.com/c212d47a0f03d5b2024bcc98cb7a9e0ad8725add/chrome/browser/resources/print_preview/new/advanced_options_settings.html [modify] https://crrev.com/c212d47a0f03d5b2024bcc98cb7a9e0ad8725add/chrome/browser/resources/print_preview/new/advanced_options_settings.js [add] https://crrev.com/c212d47a0f03d5b2024bcc98cb7a9e0ad8725add/chrome/browser/resources/print_preview/new/advanced_settings_dialog.html [add] https://crrev.com/c212d47a0f03d5b2024bcc98cb7a9e0ad8725add/chrome/browser/resources/print_preview/new/advanced_settings_dialog.js [modify] https://crrev.com/c212d47a0f03d5b2024bcc98cb7a9e0ad8725add/chrome/browser/resources/print_preview/new/app.html [modify] https://crrev.com/c212d47a0f03d5b2024bcc98cb7a9e0ad8725add/chrome/browser/resources/print_preview/new/compiled_resources2.gyp [modify] https://crrev.com/c212d47a0f03d5b2024bcc98cb7a9e0ad8725add/chrome/browser/resources/print_preview/new/destination_dialog.html [add] https://crrev.com/c212d47a0f03d5b2024bcc98cb7a9e0ad8725add/chrome/browser/resources/print_preview/new/search_dialog_css.html [modify] https://crrev.com/c212d47a0f03d5b2024bcc98cb7a9e0ad8725add/chrome/browser/resources/print_preview/print_preview_resources.grd
rbpotter@ Could you please provide repro steps to verify the issue from TE-end. Thanks..
This issue is only for tracking a part of issue 773928. As stated in comment 11 on that bug, this is an early stage effort and there is nothing to test at this point.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/486ecf9799f29b9373ce7f65cef44fb6efb88cf2 commit 486ecf9799f29b9373ce7f65cef44fb6efb88cf2 Author: rbpotter <rbpotter@chromium.org> Date: Fri Feb 23 14:48:52 2018 Print Preview Componentization: Fill in settings in advanced settings Fill in the settings in the advanced settings dialog. Bug: 773928, 812092 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If2dacbd4db65700fe56f37c55aba3e2dec7a71d7 Reviewed-on: https://chromium-review.googlesource.com/923043 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#538779} [modify] https://crrev.com/486ecf9799f29b9373ce7f65cef44fb6efb88cf2/chrome/browser/resources/print_preview/data/destination.js [modify] https://crrev.com/486ecf9799f29b9373ce7f65cef44fb6efb88cf2/chrome/browser/resources/print_preview/new/advanced_settings_dialog.html [add] https://crrev.com/486ecf9799f29b9373ce7f65cef44fb6efb88cf2/chrome/browser/resources/print_preview/new/advanced_settings_item.html [add] https://crrev.com/486ecf9799f29b9373ce7f65cef44fb6efb88cf2/chrome/browser/resources/print_preview/new/advanced_settings_item.js [modify] https://crrev.com/486ecf9799f29b9373ce7f65cef44fb6efb88cf2/chrome/browser/resources/print_preview/new/compiled_resources2.gyp [modify] https://crrev.com/486ecf9799f29b9373ce7f65cef44fb6efb88cf2/chrome/browser/resources/print_preview/print_preview_resources.grd [modify] https://crrev.com/486ecf9799f29b9373ce7f65cef44fb6efb88cf2/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fae635000c95be29576373e8748ff579eafc988d commit fae635000c95be29576373e8748ff579eafc988d Author: rbpotter <rbpotter@chromium.org> Date: Fri Feb 23 14:59:35 2018 Print Preview Componentization: Set, save and restore advanced settings Bug: 773928, 812092 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id5ab92710d394f3382bbe79ba7c0256b8ab7b5d3 Reviewed-on: https://chromium-review.googlesource.com/924521 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#538780} [modify] https://crrev.com/fae635000c95be29576373e8748ff579eafc988d/chrome/browser/resources/print_preview/data/destination.js [modify] https://crrev.com/fae635000c95be29576373e8748ff579eafc988d/chrome/browser/resources/print_preview/new/advanced_settings_dialog.html [modify] https://crrev.com/fae635000c95be29576373e8748ff579eafc988d/chrome/browser/resources/print_preview/new/advanced_settings_dialog.js [modify] https://crrev.com/fae635000c95be29576373e8748ff579eafc988d/chrome/browser/resources/print_preview/new/advanced_settings_item.html [modify] https://crrev.com/fae635000c95be29576373e8748ff579eafc988d/chrome/browser/resources/print_preview/new/advanced_settings_item.js [modify] https://crrev.com/fae635000c95be29576373e8748ff579eafc988d/chrome/browser/resources/print_preview/new/compiled_resources2.gyp [modify] https://crrev.com/fae635000c95be29576373e8748ff579eafc988d/chrome/browser/resources/print_preview/new/model.js [modify] https://crrev.com/fae635000c95be29576373e8748ff579eafc988d/chrome/test/data/webui/print_preview/settings_section_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e684b898fcefae015baa9fff016c84e292d0d87f commit e684b898fcefae015baa9fff016c84e292d0d87f Author: rbpotter <rbpotter@chromium.org> Date: Wed Feb 28 05:34:30 2018 Print Preview Componentization: Add highlighting for advanced settings Bug: 773928, 812092 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6a77a773cc1eecf91b8847c46e83626215d2b0b5 Reviewed-on: https://chromium-review.googlesource.com/927831 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#539720} [modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/print_preview/new/advanced_settings_dialog.html [modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/print_preview/new/advanced_settings_dialog.js [modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/print_preview/new/advanced_settings_item.html [modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/print_preview/new/advanced_settings_item.js [modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/print_preview/new/compiled_resources2.gyp [modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/print_preview/new/destination_list_item.html [modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/print_preview/new/destination_list_item.js [add] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/print_preview/new/highlight_utils.html [add] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/print_preview/new/highlight_utils.js [modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/print_preview/print_preview_resources.grd [modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/settings/controls/settings_toggle_button.html [modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/settings/search_settings.js [modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/settings/settings_vars_css.html [add] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/ui/webui/resources/cr_elements/search_highlight_style_css.html [modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/ui/webui/resources/cr_elements/shared_vars_css.html [modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/ui/webui/resources/cr_elements_resources.grdp [modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/ui/webui/resources/js/search_highlight_utils.js
Comment 1 by rbpotter@chromium.org
, Feb 14 2018