New issue
Advanced search Search tips

Issue 812089 link

Starred by 1 user
Status: Fixed
Owner:
tkent@chromium.org
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 572693



Sign in to add a comment

Cleanup of importNode() cloneNode() implementation

Project Member Reported by tkent@chromium.org, Feb 14 2018 
Chrome Version: ToT
OS: All but iOS

importNode() part of DOM specification says:
> 2. Return a *clone* of node, with context object and the clone children flag set if deep is true.
https://dom.spec.whatwg.org/#dom-document-importnode

However, our implementation doesn't share importNode() code and cloneNode() code very well.

For example, Document::importNode() contains a special handling for <template>, but HTMLTemplateElement::cloneNode() handles the same thing.

Also, I feel Element::CloneElement* functions are unnecessarily complex.

Comment 1 by tkent@chromium.org, Feb 14 2018

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48b6878bbdcb86b8e4a44c3ca7f733931a67046e

commit 48b6878bbdcb86b8e4a44c3ca7f733931a67046e
Author: Kent Tamura <tkent@chromium.org>
Date: Thu Feb 15 09:03:33 2018

Consolidate <template> cloning steps for cloneNode() and importNode().

<template>'s extra cloning step [1] needs "clone children flag."
So this CL adds it to CloneDataFromElement() and
CopyNonAttributePropertiesFromElement().

This CL has no behavior changes.

[1] https://html.spec.whatwg.org/multipage/scripting.html#the-template-element:concept-node-clone-ext

Bug:  812089 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: If87da26b9ef46f18d69129ee5b956159d392c471
Reviewed-on: https://chromium-review.googlesource.com/920942
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536975}
[modify] https://crrev.com/48b6878bbdcb86b8e4a44c3ca7f733931a67046e/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/48b6878bbdcb86b8e4a44c3ca7f733931a67046e/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/48b6878bbdcb86b8e4a44c3ca7f733931a67046e/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/48b6878bbdcb86b8e4a44c3ca7f733931a67046e/third_party/WebKit/Source/core/editing/commands/ReplaceNodeWithSpanCommand.cpp
[modify] https://crrev.com/48b6878bbdcb86b8e4a44c3ca7f733931a67046e/third_party/WebKit/Source/core/html/HTMLTemplateElement.cpp
[modify] https://crrev.com/48b6878bbdcb86b8e4a44c3ca7f733931a67046e/third_party/WebKit/Source/core/html/HTMLTemplateElement.h
[modify] https://crrev.com/48b6878bbdcb86b8e4a44c3ca7f733931a67046e/third_party/WebKit/Source/core/html/forms/HTMLFormControlElement.cpp
[modify] https://crrev.com/48b6878bbdcb86b8e4a44c3ca7f733931a67046e/third_party/WebKit/Source/core/html/forms/HTMLFormControlElement.h
[modify] https://crrev.com/48b6878bbdcb86b8e4a44c3ca7f733931a67046e/third_party/WebKit/Source/core/html/forms/HTMLFormElement.cpp
[modify] https://crrev.com/48b6878bbdcb86b8e4a44c3ca7f733931a67046e/third_party/WebKit/Source/core/html/forms/HTMLFormElement.h
[modify] https://crrev.com/48b6878bbdcb86b8e4a44c3ca7f733931a67046e/third_party/WebKit/Source/core/html/forms/HTMLInputElement.cpp
[modify] https://crrev.com/48b6878bbdcb86b8e4a44c3ca7f733931a67046e/third_party/WebKit/Source/core/html/forms/HTMLInputElement.h
[modify] https://crrev.com/48b6878bbdcb86b8e4a44c3ca7f733931a67046e/third_party/WebKit/Source/core/html/forms/HTMLTextAreaElement.cpp
[modify] https://crrev.com/48b6878bbdcb86b8e4a44c3ca7f733931a67046e/third_party/WebKit/Source/core/html/forms/HTMLTextAreaElement.h
[modify] https://crrev.com/48b6878bbdcb86b8e4a44c3ca7f733931a67046e/third_party/WebKit/Source/core/html/forms/TextControlElement.cpp
[modify] https://crrev.com/48b6878bbdcb86b8e4a44c3ca7f733931a67046e/third_party/WebKit/Source/core/html/forms/TextControlElement.h
[modify] https://crrev.com/48b6878bbdcb86b8e4a44c3ca7f733931a67046e/third_party/WebKit/Source/core/svg/SVGUseElement.cpp

Comment 3 by tkent@chromium.org, Feb 16 2018

Blocking: 572693
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35bb61db1c5a66208c46f0a3ed69df450df20793

commit 35bb61db1c5a66208c46f0a3ed69df450df20793
Author: Kent Tamura <tkent@chromium.org>
Date: Fri Feb 16 08:01:51 2018

importNode() should clone |already started| flag of <script>.

Add |factory| argument to Element::
CloneElementWithoutAttributesAndChildren(), and use it in Document::
importNode().

Bug:  572693 ,  812089 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1c89cdf45f9a1f38b9ab6a3e7149692b66e1c44d
Reviewed-on: https://chromium-review.googlesource.com/920965
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537253}
[delete] https://crrev.com/0b888d00bb0f833067ea7a7efa27329c4a5e74de/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/035-expected.txt
[modify] https://crrev.com/35bb61db1c5a66208c46f0a3ed69df450df20793/third_party/WebKit/Source/core/dom/CreateElementFlags.h
[modify] https://crrev.com/35bb61db1c5a66208c46f0a3ed69df450df20793/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/35bb61db1c5a66208c46f0a3ed69df450df20793/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/35bb61db1c5a66208c46f0a3ed69df450df20793/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/35bb61db1c5a66208c46f0a3ed69df450df20793/third_party/WebKit/Source/core/html/HTMLScriptElement.cpp
[modify] https://crrev.com/35bb61db1c5a66208c46f0a3ed69df450df20793/third_party/WebKit/Source/core/html/HTMLScriptElement.h
[modify] https://crrev.com/35bb61db1c5a66208c46f0a3ed69df450df20793/third_party/WebKit/Source/core/html/forms/SliderThumbElement.h
[modify] https://crrev.com/35bb61db1c5a66208c46f0a3ed69df450df20793/third_party/WebKit/Source/core/html/track/vtt/VTTElement.cpp
[modify] https://crrev.com/35bb61db1c5a66208c46f0a3ed69df450df20793/third_party/WebKit/Source/core/html/track/vtt/VTTElement.h
[modify] https://crrev.com/35bb61db1c5a66208c46f0a3ed69df450df20793/third_party/WebKit/Source/core/svg/SVGScriptElement.cpp
[modify] https://crrev.com/35bb61db1c5a66208c46f0a3ed69df450df20793/third_party/WebKit/Source/core/svg/SVGScriptElement.h
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4eaf12cd98a8096a9a43cc30f6656959cb72a34d

commit 4eaf12cd98a8096a9a43cc30f6656959cb72a34d
Author: Kent Tamura <tkent@chromium.org>
Date: Fri Feb 16 10:06:05 2018

Separate cloneNode() implementation and "clone" algorithm implementation.

Our C++ cloneNode() implemented web-exposed Node.prototype.cloneNode()
[1] and DOM "clone" algorithm [2]. This CL makes C++ cloneNode()
responsible only for [1], and moves [2] to virtual Node::Clone().

- Rename Node::importNode override functions to Clone().
- Add Document& argument to support importNode case
- Remove ExceptionState argument. Clone() never throws.

This is a preparation to use [2] for importNode().
This CL has no behavior changes.

[1] https://dom.spec.whatwg.org/#dom-node-clonenode
[2] https://dom.spec.whatwg.org/#concept-node-clone

Bug:  812089 
Change-Id: I523e81b32bb8c1e80273e9aa9529cdd6972ca8bf
Reviewed-on: https://chromium-review.googlesource.com/923684
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537273}
[modify] https://crrev.com/4eaf12cd98a8096a9a43cc30f6656959cb72a34d/third_party/WebKit/Source/core/dom/Attr.cpp
[modify] https://crrev.com/4eaf12cd98a8096a9a43cc30f6656959cb72a34d/third_party/WebKit/Source/core/dom/Attr.h
[modify] https://crrev.com/4eaf12cd98a8096a9a43cc30f6656959cb72a34d/third_party/WebKit/Source/core/dom/CDATASection.cpp
[modify] https://crrev.com/4eaf12cd98a8096a9a43cc30f6656959cb72a34d/third_party/WebKit/Source/core/dom/CDATASection.h
[modify] https://crrev.com/4eaf12cd98a8096a9a43cc30f6656959cb72a34d/third_party/WebKit/Source/core/dom/Comment.cpp
[modify] https://crrev.com/4eaf12cd98a8096a9a43cc30f6656959cb72a34d/third_party/WebKit/Source/core/dom/Comment.h
[modify] https://crrev.com/4eaf12cd98a8096a9a43cc30f6656959cb72a34d/third_party/WebKit/Source/core/dom/ContainerNode.cpp
[modify] https://crrev.com/4eaf12cd98a8096a9a43cc30f6656959cb72a34d/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/4eaf12cd98a8096a9a43cc30f6656959cb72a34d/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/4eaf12cd98a8096a9a43cc30f6656959cb72a34d/third_party/WebKit/Source/core/dom/DocumentFragment.cpp
[modify] https://crrev.com/4eaf12cd98a8096a9a43cc30f6656959cb72a34d/third_party/WebKit/Source/core/dom/DocumentFragment.h
[modify] https://crrev.com/4eaf12cd98a8096a9a43cc30f6656959cb72a34d/third_party/WebKit/Source/core/dom/DocumentType.cpp
[modify] https://crrev.com/4eaf12cd98a8096a9a43cc30f6656959cb72a34d/third_party/WebKit/Source/core/dom/DocumentType.h
[modify] https://crrev.com/4eaf12cd98a8096a9a43cc30f6656959cb72a34d/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/4eaf12cd98a8096a9a43cc30f6656959cb72a34d/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/4eaf12cd98a8096a9a43cc30f6656959cb72a34d/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/4eaf12cd98a8096a9a43cc30f6656959cb72a34d/third_party/WebKit/Source/core/dom/Node.h
[modify] https://crrev.com/4eaf12cd98a8096a9a43cc30f6656959cb72a34d/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp
[modify] https://crrev.com/4eaf12cd98a8096a9a43cc30f6656959cb72a34d/third_party/WebKit/Source/core/dom/ProcessingInstruction.h
[modify] https://crrev.com/4eaf12cd98a8096a9a43cc30f6656959cb72a34d/third_party/WebKit/Source/core/dom/ShadowRoot.cpp
[modify] https://crrev.com/4eaf12cd98a8096a9a43cc30f6656959cb72a34d/third_party/WebKit/Source/core/dom/ShadowRoot.h
[modify] https://crrev.com/4eaf12cd98a8096a9a43cc30f6656959cb72a34d/third_party/WebKit/Source/core/dom/Text.cpp
[modify] https://crrev.com/4eaf12cd98a8096a9a43cc30f6656959cb72a34d/third_party/WebKit/Source/core/dom/Text.h
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4d982d2ba9b1b46911335a2803da17d8f554db7

commit d4d982d2ba9b1b46911335a2803da17d8f554db7
Author: Kent Tamura <tkent@chromium.org>
Date: Mon Feb 19 04:50:25 2018

Remove Document::ImportContainerNodeChildren().

ContainerNode::CloneChildNodes() does the same thing.
This CL has no behavior changes.

Bug:  812089 
Change-Id: Ida9fb4c6dbc34654b54e74285263f70411d50d36
Reviewed-on: https://chromium-review.googlesource.com/924108
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537577}
[modify] https://crrev.com/d4d982d2ba9b1b46911335a2803da17d8f554db7/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/d4d982d2ba9b1b46911335a2803da17d8f554db7/third_party/WebKit/Source/core/dom/Document.h
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cf1e6a8b69b52af5b0744dcbc4b56e032e8efd8

commit 4cf1e6a8b69b52af5b0744dcbc4b56e032e8efd8
Author: Kent Tamura <tkent@chromium.org>
Date: Mon Feb 19 04:56:13 2018

Document::importNode should use Node::Clone as much as possible.

Make Element::CloneElementWithoutAttributesAndChildren private back.
This CL has no behavior changes.

Bug:  812089 
Change-Id: I69b91ebcb436d721f8d54d904dd8b145cdc12607
Reviewed-on: https://chromium-review.googlesource.com/923506
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537578}
[modify] https://crrev.com/4cf1e6a8b69b52af5b0744dcbc4b56e032e8efd8/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/4cf1e6a8b69b52af5b0744dcbc4b56e032e8efd8/third_party/WebKit/Source/core/dom/Element.h
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58587b6fed86783b650c35a38bc7fa3667018a14

commit 58587b6fed86783b650c35a38bc7fa3667018a14
Author: Kent Tamura <tkent@chromium.org>
Date: Mon Feb 19 11:13:53 2018

Remove unnecessary HasValidNamespaceForElements() check in Document::importNode().

It must not be possible to create elements with invalid namespace and
prefixes, and the DOM specification doesn't ask to check it.

This CL must have no behavior changes.

Bug:  812089 
Change-Id: I598081857d10116a195ecb572c9c65588d6a7734
Reviewed-on: https://chromium-review.googlesource.com/923618
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537624}
[modify] https://crrev.com/58587b6fed86783b650c35a38bc7fa3667018a14/third_party/WebKit/Source/core/dom/Document.cpp
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7b14042eca00b5575d1149e097ef8923fd42ab8

commit c7b14042eca00b5575d1149e097ef8923fd42ab8
Author: Kent Tamura <tkent@chromium.org>
Date: Tue Feb 20 01:24:49 2018

Restructuring Document::importNode() code.

Makes importNode() code match to the DOM specification.
This CL has no behavior changes

Bug:  812089 
Change-Id: I9aa7bf1401ba2e5b4342547e49ea7b567616801c
Reviewed-on: https://chromium-review.googlesource.com/923230
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537694}
[modify] https://crrev.com/c7b14042eca00b5575d1149e097ef8923fd42ab8/third_party/WebKit/Source/core/dom/Document.cpp
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71b093d2c834e0a4e15149022e4f88ab144ac805

commit 71b093d2c834e0a4e15149022e4f88ab144ac805
Author: Kent Tamura <tkent@chromium.org>
Date: Tue Feb 20 07:09:22 2018

Fix a bug that document.importNode() doesn't clone Attr nodes with namespace.

We should just call Attr::Clone().

Bug:  812089 ,  812105 
Change-Id: I163769e134a52d82b88834ae29083a01a3480e95
Reviewed-on: https://chromium-review.googlesource.com/925865
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537730}
[modify] https://crrev.com/71b093d2c834e0a4e15149022e4f88ab144ac805/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-importNode.html
[modify] https://crrev.com/71b093d2c834e0a4e15149022e4f88ab144ac805/third_party/WebKit/Source/core/dom/Document.cpp

Comment 11 by tkent@chromium.org, Feb 20 2018

Owner: tkent@chromium.org
Status: Fixed (was: Available)
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/807b5b7a98daef1db4402456e60b6f0cd3f45ce0

commit 807b5b7a98daef1db4402456e60b6f0cd3f45ce0
Author: Kent Tamura <tkent@chromium.org>
Date: Wed Feb 21 01:57:33 2018

Make ContainerNode::CloneChildNodes consistent with other Clone* functions

- Swap |this| and the argument
- Rename CloneChildNodes to CloneChildNodesFrom

The new shape is consistent with CloneAttributesFromElement(),
CopyNonAttributePropertiesFromElement(), and CloneDataFromElement().

This CL has no behavior changes.

Bug:  812089 
Change-Id: I1bb2396aeb5a6d94b4600a32c27acdb70207ee67
Reviewed-on: https://chromium-review.googlesource.com/927689
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537988}
[modify] https://crrev.com/807b5b7a98daef1db4402456e60b6f0cd3f45ce0/third_party/WebKit/Source/core/dom/ContainerNode.cpp
[modify] https://crrev.com/807b5b7a98daef1db4402456e60b6f0cd3f45ce0/third_party/WebKit/Source/core/dom/ContainerNode.h
[modify] https://crrev.com/807b5b7a98daef1db4402456e60b6f0cd3f45ce0/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/807b5b7a98daef1db4402456e60b6f0cd3f45ce0/third_party/WebKit/Source/core/dom/DocumentFragment.cpp
[modify] https://crrev.com/807b5b7a98daef1db4402456e60b6f0cd3f45ce0/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/807b5b7a98daef1db4402456e60b6f0cd3f45ce0/third_party/WebKit/Source/core/html/HTMLTemplateElement.cpp
[modify] https://crrev.com/807b5b7a98daef1db4402456e60b6f0cd3f45ce0/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86f69261dcc5fd11cba23ee928fc7b2466d0a8d5

commit 86f69261dcc5fd11cba23ee928fc7b2466d0a8d5
Author: Kent Tamura <tkent@chromium.org>
Date: Wed Feb 21 03:51:10 2018

Do not use CloneDataFromElement() in SVGUseElement.cpp

These code fragments copy attributes to another SVG elements with
different tag names. We should not use CloneDataFromElement() in such
cases because implementations of CopyNonAttributePropertiesFromElement(),
which is called in CloneDataFromElement(), assumes |this| element and
the specified element are the same type.

Makes CloneDataFromElement() private because there are no callsites
outside of Element.

This CL has no behavior changes.

Bug:  812089 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I6587be423ec5028910c0ce32f7b586bbec74bca8
Reviewed-on: https://chromium-review.googlesource.com/925929
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538016}
[modify] https://crrev.com/86f69261dcc5fd11cba23ee928fc7b2466d0a8d5/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/86f69261dcc5fd11cba23ee928fc7b2466d0a8d5/third_party/WebKit/Source/core/svg/SVGUseElement.cpp
Project Member

Comment 14 by bugdroid1@chromium.org, Feb 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe5ae1bdbc095e41042faf99cf4512c08464d645

commit fe5ae1bdbc095e41042faf99cf4512c08464d645
Author: Kent Tamura <tkent@chromium.org>
Date: Wed Feb 21 06:06:38 2018

Remove Element::CloneDataFromElement

The function is very small and has no complex logic. This CL folds it
into callsites.

This CL has no behavior changes.

Bug:  812089 
Change-Id: Ica05e3261dcd3e5cc314d2bbc3f6c5893b905197
Reviewed-on: https://chromium-review.googlesource.com/927966
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538034}
[modify] https://crrev.com/fe5ae1bdbc095e41042faf99cf4512c08464d645/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/fe5ae1bdbc095e41042faf99cf4512c08464d645/third_party/WebKit/Source/core/dom/Element.h
Project Member

Comment 15 by bugdroid1@chromium.org, Feb 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/638cfd8732a0b269c63ad593797378f653619c62

commit 638cfd8732a0b269c63ad593797378f653619c62
Author: Kent Tamura <tkent@chromium.org>
Date: Thu Feb 22 04:50:55 2018

Simplify clone-related function names in Element.

- CloneElementWithChildren -> CloneWithChildren
- CloneElementWithoutChildren -> CloneWithoutChildren
- CloneAttributesFromElement -> CloneAttributesFrom
- CopyNonAttributePropertiesFromElement ->
    CloneNonAttributePropertiesFrom
- CloneElementWithoutAttributesAndChildren ->
    CloneWithoutAttributesAndChildren

This CL has no behavior changes.

Bug:  812089 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I02c39a252bf112aeba858fe5b8f7886741b0be76
Reviewed-on: https://chromium-review.googlesource.com/928052
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538350}
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/css/SelectorQueryTest.cpp
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/editing/commands/ReplaceNodeWithSpanCommand.cpp
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/html/HTMLScriptElement.cpp
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/html/HTMLScriptElement.h
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/html/HTMLTemplateElement.cpp
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/html/HTMLTemplateElement.h
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/html/forms/HTMLFormControlElement.cpp
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/html/forms/HTMLFormControlElement.h
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/html/forms/HTMLFormElement.cpp
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/html/forms/HTMLFormElement.h
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/html/forms/HTMLInputElement.cpp
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/html/forms/HTMLInputElement.h
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/html/forms/HTMLTextAreaElement.cpp
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/html/forms/HTMLTextAreaElement.h
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/html/forms/SliderThumbElement.h
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/html/forms/TextControlElement.cpp
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/html/forms/TextControlElement.h
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/html/track/vtt/VTTElement.cpp
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/html/track/vtt/VTTElement.h
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/svg/SVGScriptElement.cpp
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/svg/SVGScriptElement.h
[modify] https://crrev.com/638cfd8732a0b269c63ad593797378f653619c62/third_party/WebKit/Source/core/svg/SVGUseElement.cpp
Project Member

Comment 16 by bugdroid1@chromium.org, Feb 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b

commit fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b
Author: Kent Tamura <tkent@chromium.org>
Date: Thu Feb 22 07:30:39 2018

Constify clone-related functions in core/dom/.

This CL has no behavior changes.

Bug:  812089 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I48390c2e3d08fe7ac378b934063088355333e89d
Reviewed-on: https://chromium-review.googlesource.com/930105
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538377}
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/dom/Attr.cpp
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/dom/Attr.h
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/dom/CDATASection.cpp
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/dom/CDATASection.h
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/dom/Comment.cpp
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/dom/Comment.h
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/dom/ContainerNode.cpp
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/dom/DocumentFragment.cpp
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/dom/DocumentFragment.h
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/dom/DocumentType.cpp
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/dom/DocumentType.h
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/dom/Node.h
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/dom/ProcessingInstruction.h
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/dom/ShadowRoot.cpp
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/dom/ShadowRoot.h
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/dom/Text.cpp
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/dom/Text.h
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/html/HTMLDocument.cpp
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/html/HTMLDocument.h
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/html/HTMLScriptElement.cpp
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/html/HTMLScriptElement.h
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/html/forms/SliderThumbElement.h
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/html/track/vtt/VTTElement.cpp
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/html/track/vtt/VTTElement.h
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/svg/SVGScriptElement.cpp
[modify] https://crrev.com/fb1c2f6cdb0bcb9a3e26930100f646772ea7eb1b/third_party/WebKit/Source/core/svg/SVGScriptElement.h
►

Sign in to add a comment