This should be done after the new wallpaper picker is enabled by default. In addition, rename certain legacy names, such as baseURL for custom wallpapers (a better name should be fileName.)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/841235c1d35d8ec6067f40526785b2bd9add3656 commit 841235c1d35d8ec6067f40526785b2bd9add3656 Author: Wenzhao Zang <wzang@chromium.org> Date: Wed Oct 24 20:42:07 2018 cros: Clean up old wallpaper picker code (Part I) Remove the |useNewWallpaperPicker| checks, and modify some comments. Will need follow-up CLs to: 1) Remove the flag in //ash. 2) Take a second pass to check which CSS styles/functions/variables are unused. Bug: 812085 Change-Id: I7faa99c16715360a95feed50b5041d89c8c322a1 Reviewed-on: https://chromium-review.googlesource.com/c/1297308 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#602432} [modify] https://crrev.com/841235c1d35d8ec6067f40526785b2bd9add3656/chrome/browser/resources/chromeos/wallpaper_manager/js/constants.js [modify] https://crrev.com/841235c1d35d8ec6067f40526785b2bd9add3656/chrome/browser/resources/chromeos/wallpaper_manager/js/event_page.js [modify] https://crrev.com/841235c1d35d8ec6067f40526785b2bd9add3656/chrome/browser/resources/chromeos/wallpaper_manager/js/util.js [modify] https://crrev.com/841235c1d35d8ec6067f40526785b2bd9add3656/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_categories_list.js [modify] https://crrev.com/841235c1d35d8ec6067f40526785b2bd9add3656/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_images_grid.js [modify] https://crrev.com/841235c1d35d8ec6067f40526785b2bd9add3656/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js [modify] https://crrev.com/841235c1d35d8ec6067f40526785b2bd9add3656/chrome/test/data/chromeos/wallpaper_manager/unit_tests/api_mock.js [modify] https://crrev.com/841235c1d35d8ec6067f40526785b2bd9add3656/chrome/test/data/chromeos/wallpaper_manager/unit_tests/event_page_unittest.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea82df7bc2cb21ccf67802bb4d34d15ff35741d5 commit ea82df7bc2cb21ccf67802bb4d34d15ff35741d5 Author: Wenzhao Zang <wzang@chromium.org> Date: Wed Oct 24 22:10:08 2018 cros: Clean up old wallpaper picker code (Part II) Bug: 812085 Change-Id: Ia2bf565c0ff5e5cd43e94079ae41b7a0be614430 Reviewed-on: https://chromium-review.googlesource.com/c/1297356 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#602480} [modify] https://crrev.com/ea82df7bc2cb21ccf67802bb4d34d15ff35741d5/ash/public/cpp/ash_features.cc [modify] https://crrev.com/ea82df7bc2cb21ccf67802bb4d34d15ff35741d5/ash/public/cpp/ash_features.h [modify] https://crrev.com/ea82df7bc2cb21ccf67802bb4d34d15ff35741d5/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/ea82df7bc2cb21ccf67802bb4d34d15ff35741d5/chrome/browser/about_flags.cc [modify] https://crrev.com/ea82df7bc2cb21ccf67802bb4d34d15ff35741d5/chrome/browser/chromeos/extensions/wallpaper_private_api.cc [modify] https://crrev.com/ea82df7bc2cb21ccf67802bb4d34d15ff35741d5/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/ea82df7bc2cb21ccf67802bb4d34d15ff35741d5/chrome/browser/flag_descriptions.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d75b735baac8472a097ad954afda580b086c31d commit 5d75b735baac8472a097ad954afda580b086c31d Author: Wenzhao Zang <wzang@chromium.org> Date: Fri Nov 02 00:38:19 2018 cros: Clean up old wallpaper picker code (Part III) Remove more dead code. Bug: 812085 Change-Id: I1ba634e3fb41d61511736dc7c057a5bbc5903c78 Reviewed-on: https://chromium-review.googlesource.com/c/1300315 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#604772} [modify] https://crrev.com/5d75b735baac8472a097ad954afda580b086c31d/chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css [modify] https://crrev.com/5d75b735baac8472a097ad954afda580b086c31d/chrome/browser/resources/chromeos/wallpaper_manager/js/constants.js [modify] https://crrev.com/5d75b735baac8472a097ad954afda580b086c31d/chrome/browser/resources/chromeos/wallpaper_manager/js/event_page.js [modify] https://crrev.com/5d75b735baac8472a097ad954afda580b086c31d/chrome/browser/resources/chromeos/wallpaper_manager/js/main_scripts.js [delete] https://crrev.com/2ebd2c8385d00274be86a2a8b768624d43bbec51/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_directories.js [modify] https://crrev.com/5d75b735baac8472a097ad954afda580b086c31d/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_images_grid.js [modify] https://crrev.com/5d75b735baac8472a097ad954afda580b086c31d/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js [modify] https://crrev.com/5d75b735baac8472a097ad954afda580b086c31d/chrome/browser/resources/chromeos/wallpaper_manager/main.html
Comment 1 by wzang@chromium.org
, Oct 22