New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 812070 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

UKM metrics are not being recorded for Autofill on iOS

Project Member Reported by mahmadi@chromium.org, Feb 14 2018

Issue description

UKM metrics are not being recorded for Autofill on iOS. UKM metrics are being recorded for other features on iOS (e.g., Payment Request) in M64.
 

Comment 1 by pkl@chromium.org, Feb 14 2018

Cc: noyau@chromium.org cma...@chromium.org olivierrobin@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80f0c5570649c35a869429b2ab8c381a0a7246cb

commit 80f0c5570649c35a869429b2ab8c381a0a7246cb
Author: Mohamad Ahmadi <mahmadi@chromium.org>
Date: Wed Feb 14 08:33:58 2018

Fixes a bug were UKM metrics were not being logged for autofill on iOS

autofill::AutofillManager passes FormData.main_frame_origin to the
autofill::AutofillMetrics::FormInteractionsUkmLogger. This property was not
being set in autofill_agent.mm, therefore no metrics were being logged.

Bug:  812070 
Change-Id: I1e337ae6af575fc6182e5b360e44f12427d3d5be
Reviewed-on: https://chromium-review.googlesource.com/917534
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536678}
[modify] https://crrev.com/80f0c5570649c35a869429b2ab8c381a0a7246cb/components/autofill/ios/browser/autofill_agent.mm

Labels: Merge-Request-65
Status: Fixed (was: Started)
cmasso@, would like to merge this into M65 after it's verified on canary.
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 14 2018

Labels: -Merge-Request-65 Merge-Review-65 Hotlist-Merge-Review
This bug requires manual review: Less than 16 days to go before AppStore submit on M65
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by cmasso@google.com, Feb 14 2018

Labels: -Hotlist-Merge-Review -Merge-Review-65 Merge-Approved-65
Project Member

Comment 6 by sheriffbot@chromium.org, Feb 19 2018

Cc: cmasso@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Verified UKM data for autofill is being recorded on Chrome Canary 66.0.3351.0
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 20 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b78663d43c691818f06eacb93a79345b7860f45

commit 5b78663d43c691818f06eacb93a79345b7860f45
Author: Mohamad Ahmadi <mahmadi@chromium.org>
Date: Tue Feb 20 16:55:32 2018

Fixes a bug were UKM metrics were not being logged for autofill on iOS

autofill::AutofillManager passes FormData.main_frame_origin to the
autofill::AutofillMetrics::FormInteractionsUkmLogger. This property was not
being set in autofill_agent.mm, therefore no metrics were being logged.

Bug:  812070 
Change-Id: I1e337ae6af575fc6182e5b360e44f12427d3d5be
Reviewed-on: https://chromium-review.googlesource.com/917534
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#536678}(cherry picked from commit 80f0c5570649c35a869429b2ab8c381a0a7246cb)
Reviewed-on: https://chromium-review.googlesource.com/926821
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#504}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/5b78663d43c691818f06eacb93a79345b7860f45/components/autofill/ios/browser/autofill_agent.mm

Sign in to add a comment