Enable Oculus behind a runtime flag |
||||
Issue descriptionOculus is currently behind a compile-time flag.
,
Feb 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/103ed273b119a6af8a8c4c63b32573c2e2c7896b commit 103ed273b119a6af8a8c4c63b32573c2e2c7896b Author: Bill Orr <billorr@chromium.org> Date: Wed Feb 14 21:23:05 2018 Enable Oculus devices behind a runtime flag This change moves the Oculus device to be behind a runtime flag, rather than a build flag. It will only be enabled if is_chrome_branding, is_win, and src_internal is available. The means that developers testing with Oculus support should still build locally with enable_oculus_vr gn arg if they aren't building with chrome branding. Public bots (CQ) will not build this, but perftests/fyi will. BUG= 812050 Change-Id: I7b99d98b53adf8878c0523e2eafe4ab422936ebe Reviewed-on: https://chromium-review.googlesource.com/917644 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#536817} [modify] https://crrev.com/103ed273b119a6af8a8c4c63b32573c2e2c7896b/DEPS [modify] https://crrev.com/103ed273b119a6af8a8c4c63b32573c2e2c7896b/chrome/browser/about_flags.cc [modify] https://crrev.com/103ed273b119a6af8a8c4c63b32573c2e2c7896b/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/103ed273b119a6af8a8c4c63b32573c2e2c7896b/chrome/browser/flag_descriptions.h [modify] https://crrev.com/103ed273b119a6af8a8c4c63b32573c2e2c7896b/chrome/browser/vr/service/vr_device_manager.cc [modify] https://crrev.com/103ed273b119a6af8a8c4c63b32573c2e2c7896b/chrome/common/chrome_features.cc [modify] https://crrev.com/103ed273b119a6af8a8c4c63b32573c2e2c7896b/chrome/common/chrome_features.h [modify] https://crrev.com/103ed273b119a6af8a8c4c63b32573c2e2c7896b/device/vr/features/features.gni [modify] https://crrev.com/103ed273b119a6af8a8c4c63b32573c2e2c7896b/tools/metrics/histograms/enums.xml
,
Feb 14 2018
,
Feb 16 2018
,
Jul 4
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ymalik@chromium.org
, Feb 14 2018