New issue
Advanced search Search tips

Issue 812036 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocked on:
issue 811382



Sign in to add a comment

Redirect to chrome://connection-help when an interstitial is triggered for help content.

Project Member Reported by carlosil@chromium.org, Feb 14 2018

Issue description

As part of go/httphelpcontent, users who get an interstitial when visiting the connection help page on the help center (support.google.com/chrome/answer/6098869/) should be redirected to chrome://connection-help.
 
Blockedon: 811382
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55ef4b4d90198c9fc2e8598bdbb42a7d4b856dd5

commit 55ef4b4d90198c9fc2e8598bdbb42a7d4b856dd5
Author: Carlos IL <carlosil@chromium.org>
Date: Wed Feb 21 21:00:57 2018

Set automatic redirect to chrome://connection-help

Added a connection_help_tab_helper that monitors if a navigation to the
connection help page on the help center results in an interstitial, in
which case it redirects to chrome://connection-help. For now this only
happens if the BundledConnectionHelp feature is enabled.

Bug:  812036 
Change-Id: Ic299b6594537c82f5f0d36842da72d4b5fc569c3
Reviewed-on: https://chromium-review.googlesource.com/917464
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538205}
[modify] https://crrev.com/55ef4b4d90198c9fc2e8598bdbb42a7d4b856dd5/chrome/browser/BUILD.gn
[add] https://crrev.com/55ef4b4d90198c9fc2e8598bdbb42a7d4b856dd5/chrome/browser/ssl/connection_help_tab_helper.cc
[add] https://crrev.com/55ef4b4d90198c9fc2e8598bdbb42a7d4b856dd5/chrome/browser/ssl/connection_help_tab_helper.h
[add] https://crrev.com/55ef4b4d90198c9fc2e8598bdbb42a7d4b856dd5/chrome/browser/ssl/connection_help_tab_helper_browsertest.cc
[modify] https://crrev.com/55ef4b4d90198c9fc2e8598bdbb42a7d4b856dd5/chrome/browser/ui/tab_helpers.cc
[modify] https://crrev.com/55ef4b4d90198c9fc2e8598bdbb42a7d4b856dd5/chrome/test/BUILD.gn
[modify] https://crrev.com/55ef4b4d90198c9fc2e8598bdbb42a7d4b856dd5/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/55ef4b4d90198c9fc2e8598bdbb42a7d4b856dd5/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment