New issue
Advanced search Search tips

Issue 812035 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
rogerta@chromium.org
dbeam@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Polymer WebUI: Migrate from synthetic 'tap' to native 'click' event.

Project Member Reported by dpa...@chromium.org, Feb 14 2018 
It seems that the only reason 'tap' was preferred over 'click' originally was the fact that a 300ms delay existed as documented at [1] along with a way to turn it off, example at [2].

Using directly the native event is better, since it reduces the amount of unnecessary JS executing and reduces the chances of bugs. For example,  issue 802163  would also be addressed, per finding at [3].

[1] https://developers.google.com/web/updates/2013/12/300ms-tap-delay-gone-away
[2] https://jsfiddle.net/k6jtkatu/
[3] https://bugs.chromium.org/p/chromium/issues/detail?id=802163#c39

Comment 1 by dpa...@chromium.org, Feb 14 2018 

FYI started a CL for Settings at https://chromium-review.googlesource.com/c/chromium/src/+/919174.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04f68ff8420a40a405969c3251a119afb0697a96

commit 04f68ff8420a40a405969c3251a119afb0697a96
Author: dpapad <dpapad@chromium.org>
Date: Sat Feb 17 03:35:28 2018

Settings WebUI: Use native 'click' event instead of synthetic 'tap'.

Bug: 812035
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0a18c7593f3ec29a0025bf4ac63ef060a8fda5e4
Reviewed-on: https://chromium-review.googlesource.com/919174
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537521}
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/a11y_page/a11y_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/a11y_page/manage_a11y_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/about_page/channel_switcher_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/about_page/detailed_build_info.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/about_page/update_warning_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/android_apps_page/android_apps_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/android_apps_page/android_apps_subpage.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/android_apps_page/android_settings_element.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/change_password_page/change_password_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/chrome_cleanup_page/items_to_remove_list.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/clear_browsing_data_dialog/history_deletion_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/controls/controlled_button.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/controls/controlled_button.js
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/controls/controlled_radio_button.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/controls/controlled_radio_button.js
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/controls/extension_controlled_indicator.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/controls/settings_checkbox.js
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/date_time_page/date_time_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/default_browser_page/default_browser_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/device_page/device_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/device_page/device_page_browser_proxy.js
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/device_page/display.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/device_page/display_layout.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/device_page/display_overscan_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/device_page/drive_cache_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/device_page/keyboard.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/device_page/pointers.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/device_page/storage.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/device_page/stylus.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/downloads_page/downloads_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/google_assistant_page/google_assistant_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/internet_page/internet_config.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/internet_page/internet_detail_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/internet_page/internet_page.js
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/internet_page/internet_subpage.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/internet_page/internet_subpage.js
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/internet_page/network_proxy_section.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/internet_page/network_summary_item.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/internet_page/tether_connection_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/languages_page/edit_dictionary_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/languages_page/languages_page.js
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/on_startup_page/startup_url_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/on_startup_page/startup_url_entry.js
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/passwords_and_forms_page/password_list_item.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/passwords_and_forms_page/passwords_export_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/people_page/fingerprint_list.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/people_page/import_data_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/people_page/lock_screen.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/people_page/password_prompt_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/people_page/setup_fingerprint_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/people_page/setup_pin_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/people_page/sync_account_control.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/people_page/user_list.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/people_page/users_add_user_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/people_page/users_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/printing_page/cups_printers.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/printing_page/cups_printers_list.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/printing_page/printing_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/reset_page/powerwash_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/reset_page/reset_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/reset_page/reset_profile_banner.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/search_engines_page/search_engines_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/search_page/search_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/settings.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/settings_page/settings_subpage.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/settings_page/settings_subpage_search.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/site_settings/add_site_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/site_settings/all_sites.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/site_settings/edit_exception_dialog.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/site_settings/protocol_handlers.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/site_settings/site_data.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/site_settings/site_data_details_subpage.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/site_settings/site_details.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/site_settings/usb_devices.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/site_settings/zoom_levels.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/browser/resources/settings/system_page/system_page.html
[modify] https://crrev.com/04f68ff8420a40a405969c3251a119afb0697a96/chrome/test/data/webui/settings/people_page_sync_page_test.js
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c308440f113f5d59f90381404b2522d3709481dc

commit c308440f113f5d59f90381404b2522d3709481dc
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Feb 21 00:29:13 2018

Print Preview: Remove on-tap

Also move <style> section to <head> in print_preview_new.html, to match
other web UI files (e.g. settings.html).

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I48c4c2df7d26b8f5f52f4f2ed45750940cc87402
Bug: 812035
Reviewed-on: https://chromium-review.googlesource.com/924659
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537956}
[modify] https://crrev.com/c308440f113f5d59f90381404b2522d3709481dc/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/c308440f113f5d59f90381404b2522d3709481dc/chrome/browser/resources/print_preview/new/destination_dialog.js
[modify] https://crrev.com/c308440f113f5d59f90381404b2522d3709481dc/chrome/browser/resources/print_preview/new/destination_list.html
[modify] https://crrev.com/c308440f113f5d59f90381404b2522d3709481dc/chrome/browser/resources/print_preview/new/destination_list.js
[modify] https://crrev.com/c308440f113f5d59f90381404b2522d3709481dc/chrome/browser/resources/print_preview/new/destination_settings.html
[modify] https://crrev.com/c308440f113f5d59f90381404b2522d3709481dc/chrome/browser/resources/print_preview/new/destination_settings.js
[modify] https://crrev.com/c308440f113f5d59f90381404b2522d3709481dc/chrome/browser/resources/print_preview/new/header.html
[modify] https://crrev.com/c308440f113f5d59f90381404b2522d3709481dc/chrome/browser/resources/print_preview/new/header.js
[modify] https://crrev.com/c308440f113f5d59f90381404b2522d3709481dc/chrome/browser/resources/print_preview/print_preview_new.html

Comment 4 by dpa...@chromium.org, Feb 21 2018

Cc: dbeam@chromium.org
FYI, some related CLs in progress:

MD Extensions: https://chromium-review.googlesource.com/c/chromium/src/+/927904
Downloads: https://chromium-review.googlesource.com/c/chromium/src/+/927904
Adding PRESUBMIT (by dbeam@): https://chromium-review.googlesource.com/c/chromium/src/+/927837
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51e59fa29ac47d53049bedae8a83a86983a40abe

commit 51e59fa29ac47d53049bedae8a83a86983a40abe
Author: dpapad <dpapad@chromium.org>
Date: Wed Feb 21 23:23:02 2018

MD Extensions: Use native 'click' event instead of synthetic 'tap'.

Bug: 812035
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iabb745cdb27e15daf1bea8b8c6957cbfe4ce03ba
Reviewed-on: https://chromium-review.googlesource.com/927903
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538247}
[modify] https://crrev.com/51e59fa29ac47d53049bedae8a83a86983a40abe/chrome/browser/resources/md_extensions/detail_view.html
[modify] https://crrev.com/51e59fa29ac47d53049bedae8a83a86983a40abe/chrome/browser/resources/md_extensions/error_page.html
[modify] https://crrev.com/51e59fa29ac47d53049bedae8a83a86983a40abe/chrome/browser/resources/md_extensions/extensions.html
[modify] https://crrev.com/51e59fa29ac47d53049bedae8a83a86983a40abe/chrome/browser/resources/md_extensions/install_warnings_dialog.html
[modify] https://crrev.com/51e59fa29ac47d53049bedae8a83a86983a40abe/chrome/browser/resources/md_extensions/item.html
[modify] https://crrev.com/51e59fa29ac47d53049bedae8a83a86983a40abe/chrome/browser/resources/md_extensions/item_list.html
[modify] https://crrev.com/51e59fa29ac47d53049bedae8a83a86983a40abe/chrome/browser/resources/md_extensions/kiosk_dialog.html
[modify] https://crrev.com/51e59fa29ac47d53049bedae8a83a86983a40abe/chrome/browser/resources/md_extensions/load_error.html
[modify] https://crrev.com/51e59fa29ac47d53049bedae8a83a86983a40abe/chrome/browser/resources/md_extensions/pack_dialog.html
[modify] https://crrev.com/51e59fa29ac47d53049bedae8a83a86983a40abe/chrome/browser/resources/md_extensions/pack_dialog_alert.html
[modify] https://crrev.com/51e59fa29ac47d53049bedae8a83a86983a40abe/chrome/browser/resources/md_extensions/shortcut_input.html
[modify] https://crrev.com/51e59fa29ac47d53049bedae8a83a86983a40abe/chrome/browser/resources/md_extensions/sidebar.html
[modify] https://crrev.com/51e59fa29ac47d53049bedae8a83a86983a40abe/chrome/browser/resources/md_extensions/toolbar.html
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be690ef47f6ab92d2f11785f569014bd77386743

commit be690ef47f6ab92d2f11785f569014bd77386743
Author: dpapad <dpapad@chromium.org>
Date: Thu Feb 22 21:40:26 2018

Downloads WebUI: Use native 'click' event instead of synthetic 'tap'.

Bug: 812035
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8fe414c3eb748fe1b1a52971aff50be5ca3760cd
Reviewed-on: https://chromium-review.googlesource.com/927904
Reviewed-by: Dan Beam (no longer on Chrome) <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538572}
[modify] https://crrev.com/be690ef47f6ab92d2f11785f569014bd77386743/chrome/browser/resources/md_downloads/downloads.html
[modify] https://crrev.com/be690ef47f6ab92d2f11785f569014bd77386743/chrome/browser/resources/md_downloads/item.html
[modify] https://crrev.com/be690ef47f6ab92d2f11785f569014bd77386743/chrome/browser/resources/md_downloads/toolbar.html

Comment 10 by viswa.karala@chromium.org, Feb 27 2018

Labels: Needs-Feedback
Tested the issue on latest chrome version 66.0.3356.0 using Mac 10.12.6 with steps mentioned below:
1) Launched chrome version and naviagted to jsfiddle provided in comment#0 step#2
2) Clicked on "Tap me" and "Click me", didn't observed anything happens on the page.

@dpapad:
Please find the attched screencast for your reference and let us know if we missed anything in verifying the fix, please provide reproducible steps and excepted behaviour of the issue which helps us in verfying the fix.

Thanks!
812035.mp4
907 KB View Download

Comment 11 by dpa...@chromium.org, Feb 27 2018 

This bug is not marked as Fixed, so not sure why there is a need to verify it yet.
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e1cf7c20cc5285914ba2e6c876d322d8cafef49

commit 6e1cf7c20cc5285914ba2e6c876d322d8cafef49
Author: dpapad <dpapad@chromium.org>
Date: Fri Mar 09 23:00:20 2018

WebUI cr-toggle: Use native 'click' event instead of synthetic 'tap'.

Bug: 812035
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3fefd8951f9c28b00e98f1a42edaa9d24e5e5856
Reviewed-on: https://chromium-review.googlesource.com/944045
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542269}
[modify] https://crrev.com/6e1cf7c20cc5285914ba2e6c876d322d8cafef49/chrome/browser/resources/settings/controls/settings_toggle_button.js
[modify] https://crrev.com/6e1cf7c20cc5285914ba2e6c876d322d8cafef49/chrome/browser/resources/settings/device_page/display.html
[modify] https://crrev.com/6e1cf7c20cc5285914ba2e6c876d322d8cafef49/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/6e1cf7c20cc5285914ba2e6c876d322d8cafef49/chrome/browser/resources/settings/settings_menu/settings_menu.js
[modify] https://crrev.com/6e1cf7c20cc5285914ba2e6c876d322d8cafef49/chrome/browser/resources/settings/system_page/system_page.html
[modify] https://crrev.com/6e1cf7c20cc5285914ba2e6c876d322d8cafef49/ui/webui/resources/cr_elements/cr_toggle/cr_toggle.js
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7360540e4b535da603bacd4d407f80ae07acc34

commit b7360540e4b535da603bacd4d407f80ae07acc34
Author: dpapad <dpapad@chromium.org>
Date: Tue Jun 26 00:01:54 2018

Settings cleanup: Remove all usage of MockInteractions.tap().

In 99% of the cases it can simply be replaced with the native click() method.
In very few cases where a mousedown/mouseup event is expected, MockInteractions.tap
can be replaced with MockInteractions.up/down.

Also updating ESLint rules to disallow future usage. Eventual goal is to promote
this rule to apply to more folders.

Bug: 812035
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I9871e5f29546843b202e74a68229260f60e4c6ed
Reviewed-on: https://chromium-review.googlesource.com/1111006
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570248}
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/browser/resources/settings/change_password_page/change_password_page.html
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/browser/resources/settings/change_password_page/change_password_page.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/.eslintrc.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/a11y/sign_out_a11y_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/about_page_tests.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/android_apps_page_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/appearance_fonts_page_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/appearance_page_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/bluetooth_page_tests.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/category_default_setting_tests.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/certificate_manager_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/change_password_page_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/checkbox_tests.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/chrome_cleanup_page_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/crostini_page_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/cups_printer_page_tests.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/date_time_page_tests.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/device_page_tests.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/downloads_page_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/easy_unlock_browsertest_chromeos.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/edit_dictionary_page_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/extension_controlled_indicator_tests.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/fingerprint_browsertest_chromeos.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/focus_row_behavior_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/google_assistant_page_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/import_data_dialog_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/internet_page_tests.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/languages_page_tests.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/multidevice_page_tests.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/people_page_change_picture_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/people_page_manage_profile_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/people_page_sync_page_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/people_page_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/personalization_options_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/privacy_page_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/protocol_handlers_tests.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/reset_page_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/reset_profile_banner_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/search_engines_page_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/settings_main_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/settings_menu_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/settings_subpage_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/settings_toggle_button_tests.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/settings_ui_browsertest.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/site_data_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/site_details_tests.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/site_entry_tests.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/startup_urls_page_test.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/system_page_tests.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/usb_devices_tests.js
[modify] https://crrev.com/b7360540e4b535da603bacd4d407f80ae07acc34/chrome/test/data/webui/settings/zoom_levels_tests.js
►

Sign in to add a comment