EV Study: Lock icon lacks meaningful a11y label in experiment |
||
Issue descriptionFor our HTTPS Indicator UI study (issue 803138), we have experimental conditions which can result in the secure verbose text (the "Secure" chip) not being displayed, showing only the green lock icon. For users relying on accessibility tools or screen readers, this means that the button now only says "View site information", which does not convey the security status of the page. Previously, the button label would include the "Secure" text or the organization name (for an EV_SECURE page). The experimental conditions introduced in https://crrev.com/c/877400 break this. I have a start of a fix by adding a "Secure" string attribute to the AXNodeData of the LocationIconView, and should hopefully have a CL ready for review soon.
,
Feb 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19114cb8ae125b0fae4615ab455a0d1cb7df0af2 commit 19114cb8ae125b0fae4615ab455a0d1cb7df0af2 Author: Christopher Thompson <cthomp@chromium.org> Date: Thu Feb 15 03:19:47 2018 Ensure Secure status is in accessibility label This fixes an a11y regression in the page info button label under the experimental conditions of the HTTPS Indicator UI Study ( https://crbug.com/803501 ), where only the green lock icon would be shown but no explanatory label would be included for screen readers. This modifies the accessibility label under these conditions for both views and cocoa UI to make sure that secure connections are always labeled as such. On Windows/Linux/ChromeOS (Views), this appends a new String Attribute to the description in the AXNodeData. On Mac (Cocoa), this prepends the "Secure" text to the beginning of the Accessibility Label. Bug: 812034 Change-Id: I1fe2e6d1afa7110d445154da682846fd82738939 Reviewed-on: https://chromium-review.googlesource.com/917282 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#536938} [modify] https://crrev.com/19114cb8ae125b0fae4615ab455a0d1cb7df0af2/chrome/browser/ui/cocoa/location_bar/page_info_bubble_decoration.mm [modify] https://crrev.com/19114cb8ae125b0fae4615ab455a0d1cb7df0af2/chrome/browser/ui/views/location_bar/location_icon_view.cc
,
Feb 15 2018
Why are issue 803138 and issue 804995 view restricted?
,
Feb 15 2018
They are internal launch review bugs -- sorry. Issue 803501 is the public tracking bug for the engineering work.
,
Feb 15 2018
,
Feb 22 2018
Why are internal launch bugs view restricted? (I don't really know what a "launch bug" means, but many view restrictions in this issue tracker are excessive.)
,
Oct 12
Issue 852946 has been merged into this issue. |
||
►
Sign in to add a comment |
||
Comment 1 by cthomp@chromium.org
, Feb 13 2018