We need a way of connecting events like hover, etc, to audio provided in our component.
This portion ought to be proved out with dummy audio files. I'll dig into this ASAP.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6bf420a9312caf5f193e2c2aa4fdd9f8ddb0674 commit a6bf420a9312caf5f193e2c2aa4fdd9f8ddb0674 Author: Christopher Grant <cjgrant@chromium.org> Date: Fri Mar 09 14:56:11 2018 VR: Add initial UI sound support This change wires up button hover and click sounds, and adds them to the asset structure. BUG= 812026 R=tiborg Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iccf113e74663201c62aa220c7e134990369fd755 Reviewed-on: https://chromium-review.googlesource.com/953962 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#542109} [modify] https://crrev.com/a6bf420a9312caf5f193e2c2aa4fdd9f8ddb0674/chrome/browser/android/vr/vr_gl_thread.cc [modify] https://crrev.com/a6bf420a9312caf5f193e2c2aa4fdd9f8ddb0674/chrome/browser/android/vr/vr_gl_thread.h [modify] https://crrev.com/a6bf420a9312caf5f193e2c2aa4fdd9f8ddb0674/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/a6bf420a9312caf5f193e2c2aa4fdd9f8ddb0674/chrome/browser/vr/assets_loader.cc [modify] https://crrev.com/a6bf420a9312caf5f193e2c2aa4fdd9f8ddb0674/chrome/browser/vr/assets_loader.h [add] https://crrev.com/a6bf420a9312caf5f193e2c2aa4fdd9f8ddb0674/chrome/browser/vr/audio_delegate.h [modify] https://crrev.com/a6bf420a9312caf5f193e2c2aa4fdd9f8ddb0674/chrome/browser/vr/elements/disc_button.cc [modify] https://crrev.com/a6bf420a9312caf5f193e2c2aa4fdd9f8ddb0674/chrome/browser/vr/elements/disc_button.h [modify] https://crrev.com/a6bf420a9312caf5f193e2c2aa4fdd9f8ddb0674/chrome/browser/vr/elements/disc_button_unittest.cc [modify] https://crrev.com/a6bf420a9312caf5f193e2c2aa4fdd9f8ddb0674/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/a6bf420a9312caf5f193e2c2aa4fdd9f8ddb0674/chrome/browser/vr/elements/ui_element.h [modify] https://crrev.com/a6bf420a9312caf5f193e2c2aa4fdd9f8ddb0674/chrome/browser/vr/model/assets.h [add] https://crrev.com/a6bf420a9312caf5f193e2c2aa4fdd9f8ddb0674/chrome/browser/vr/model/sound_id.h [add] https://crrev.com/a6bf420a9312caf5f193e2c2aa4fdd9f8ddb0674/chrome/browser/vr/sounds_manager_audio_delegate.cc [add] https://crrev.com/a6bf420a9312caf5f193e2c2aa4fdd9f8ddb0674/chrome/browser/vr/sounds_manager_audio_delegate.h [modify] https://crrev.com/a6bf420a9312caf5f193e2c2aa4fdd9f8ddb0674/chrome/browser/vr/test/ui_pixel_test.cc [modify] https://crrev.com/a6bf420a9312caf5f193e2c2aa4fdd9f8ddb0674/chrome/browser/vr/test/ui_test.cc [modify] https://crrev.com/a6bf420a9312caf5f193e2c2aa4fdd9f8ddb0674/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/a6bf420a9312caf5f193e2c2aa4fdd9f8ddb0674/chrome/browser/vr/ui.cc [modify] https://crrev.com/a6bf420a9312caf5f193e2c2aa4fdd9f8ddb0674/chrome/browser/vr/ui.h [modify] https://crrev.com/a6bf420a9312caf5f193e2c2aa4fdd9f8ddb0674/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/a6bf420a9312caf5f193e2c2aa4fdd9f8ddb0674/chrome/browser/vr/ui_scene_creator.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40d64a607fe718b1028b5dca4c5129476b82b821 commit 40d64a607fe718b1028b5dca4c5129476b82b821 Author: Hongchan Choi <hongchan@chromium.org> Date: Fri Mar 09 18:16:06 2018 Revert "VR: Add initial UI sound support" This reverts commit a6bf420a9312caf5f193e2c2aa4fdd9f8ddb0674. Reason for revert: Compilation error. https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FAndroid_CFI%2F185%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout TBR=cjgrant Original change's description: > VR: Add initial UI sound support > > This change wires up button hover and click sounds, and adds them to the > asset structure. > > BUG= 812026 > R=tiborg > > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: Iccf113e74663201c62aa220c7e134990369fd755 > Reviewed-on: https://chromium-review.googlesource.com/953962 > Commit-Queue: Christopher Grant <cjgrant@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542109} TBR=vollick@chromium.org,cjgrant@chromium.org,tiborg@chromium.org Change-Id: I76dc098547a55502b8d38a96320a55e48132ed05 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 812026 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/955827 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#542150} [modify] https://crrev.com/40d64a607fe718b1028b5dca4c5129476b82b821/chrome/browser/android/vr/vr_gl_thread.cc [modify] https://crrev.com/40d64a607fe718b1028b5dca4c5129476b82b821/chrome/browser/android/vr/vr_gl_thread.h [modify] https://crrev.com/40d64a607fe718b1028b5dca4c5129476b82b821/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/40d64a607fe718b1028b5dca4c5129476b82b821/chrome/browser/vr/assets_loader.cc [modify] https://crrev.com/40d64a607fe718b1028b5dca4c5129476b82b821/chrome/browser/vr/assets_loader.h [delete] https://crrev.com/e632d236d0e10d4cea9b112e8cc0445be677ff6c/chrome/browser/vr/audio_delegate.h [modify] https://crrev.com/40d64a607fe718b1028b5dca4c5129476b82b821/chrome/browser/vr/elements/disc_button.cc [modify] https://crrev.com/40d64a607fe718b1028b5dca4c5129476b82b821/chrome/browser/vr/elements/disc_button.h [modify] https://crrev.com/40d64a607fe718b1028b5dca4c5129476b82b821/chrome/browser/vr/elements/disc_button_unittest.cc [modify] https://crrev.com/40d64a607fe718b1028b5dca4c5129476b82b821/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/40d64a607fe718b1028b5dca4c5129476b82b821/chrome/browser/vr/elements/ui_element.h [modify] https://crrev.com/40d64a607fe718b1028b5dca4c5129476b82b821/chrome/browser/vr/model/assets.h [delete] https://crrev.com/e632d236d0e10d4cea9b112e8cc0445be677ff6c/chrome/browser/vr/model/sound_id.h [delete] https://crrev.com/e632d236d0e10d4cea9b112e8cc0445be677ff6c/chrome/browser/vr/sounds_manager_audio_delegate.cc [delete] https://crrev.com/e632d236d0e10d4cea9b112e8cc0445be677ff6c/chrome/browser/vr/sounds_manager_audio_delegate.h [modify] https://crrev.com/40d64a607fe718b1028b5dca4c5129476b82b821/chrome/browser/vr/test/ui_pixel_test.cc [modify] https://crrev.com/40d64a607fe718b1028b5dca4c5129476b82b821/chrome/browser/vr/test/ui_test.cc [modify] https://crrev.com/40d64a607fe718b1028b5dca4c5129476b82b821/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/40d64a607fe718b1028b5dca4c5129476b82b821/chrome/browser/vr/ui.cc [modify] https://crrev.com/40d64a607fe718b1028b5dca4c5129476b82b821/chrome/browser/vr/ui.h [modify] https://crrev.com/40d64a607fe718b1028b5dca4c5129476b82b821/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/40d64a607fe718b1028b5dca4c5129476b82b821/chrome/browser/vr/ui_scene_creator.h
Not fixed. CLs were reverted due to a break.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/764281a9c2ca2e2ef3e09190b6569a7995ec07de commit 764281a9c2ca2e2ef3e09190b6569a7995ec07de Author: Christopher Grant <cjgrant@chromium.org> Date: Sat Mar 10 00:48:25 2018 Reland: VR: Add initial UI sound support Thie is a manual reland of CL 953962. This change wires up button hover and click sounds, and adds them to the asset structure. BUG= 812026 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id349bfe17f01cfcc3f911fc1b69d7dc33879ced6 Reviewed-on: https://chromium-review.googlesource.com/957305 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#542294} [modify] https://crrev.com/764281a9c2ca2e2ef3e09190b6569a7995ec07de/chrome/browser/android/vr/vr_gl_thread.cc [modify] https://crrev.com/764281a9c2ca2e2ef3e09190b6569a7995ec07de/chrome/browser/android/vr/vr_gl_thread.h [modify] https://crrev.com/764281a9c2ca2e2ef3e09190b6569a7995ec07de/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/764281a9c2ca2e2ef3e09190b6569a7995ec07de/chrome/browser/vr/assets_loader.cc [modify] https://crrev.com/764281a9c2ca2e2ef3e09190b6569a7995ec07de/chrome/browser/vr/assets_loader.h [add] https://crrev.com/764281a9c2ca2e2ef3e09190b6569a7995ec07de/chrome/browser/vr/audio_delegate.h [modify] https://crrev.com/764281a9c2ca2e2ef3e09190b6569a7995ec07de/chrome/browser/vr/elements/disc_button.cc [modify] https://crrev.com/764281a9c2ca2e2ef3e09190b6569a7995ec07de/chrome/browser/vr/elements/disc_button.h [modify] https://crrev.com/764281a9c2ca2e2ef3e09190b6569a7995ec07de/chrome/browser/vr/elements/disc_button_unittest.cc [modify] https://crrev.com/764281a9c2ca2e2ef3e09190b6569a7995ec07de/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/764281a9c2ca2e2ef3e09190b6569a7995ec07de/chrome/browser/vr/elements/ui_element.h [modify] https://crrev.com/764281a9c2ca2e2ef3e09190b6569a7995ec07de/chrome/browser/vr/model/assets.h [add] https://crrev.com/764281a9c2ca2e2ef3e09190b6569a7995ec07de/chrome/browser/vr/model/sound_id.h [add] https://crrev.com/764281a9c2ca2e2ef3e09190b6569a7995ec07de/chrome/browser/vr/sounds_manager_audio_delegate.cc [add] https://crrev.com/764281a9c2ca2e2ef3e09190b6569a7995ec07de/chrome/browser/vr/sounds_manager_audio_delegate.h [modify] https://crrev.com/764281a9c2ca2e2ef3e09190b6569a7995ec07de/chrome/browser/vr/test/ui_pixel_test.cc [modify] https://crrev.com/764281a9c2ca2e2ef3e09190b6569a7995ec07de/chrome/browser/vr/test/ui_test.cc [modify] https://crrev.com/764281a9c2ca2e2ef3e09190b6569a7995ec07de/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/764281a9c2ca2e2ef3e09190b6569a7995ec07de/chrome/browser/vr/ui.cc [modify] https://crrev.com/764281a9c2ca2e2ef3e09190b6569a7995ec07de/chrome/browser/vr/ui.h [modify] https://crrev.com/764281a9c2ca2e2ef3e09190b6569a7995ec07de/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/764281a9c2ca2e2ef3e09190b6569a7995ec07de/chrome/browser/vr/ui_scene_creator.h
Are we still doing more here?
I think this is fixed now. Last time we fixed it the CLs got reverted. So, we wanted to give it some time.
Comment 1 by vollick@chromium.org
, Feb 13 2018