New issue
Advanced search Search tips

Issue 812001 link

Starred by 0 users
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Feb 2018
Cc:
x...@chromium.org
mccanny@chromium.org
omrilio@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Blur background does not fade aftering closing all apps.

Project Member Reported by sammiequon@chromium.org, Feb 13 2018 
What steps will reproduce the problem?
(1) Enable new overview ui.
(2) Open an app or two.
(3) Enter overview. Wallpaper blurs.
(4) Close all apps.

What is the expected result?
Wallpaper should unblur.

What happens instead?
Wallpaper is still blurred.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97dd13e47b5e241a777ce3f49352d9a4976447f1

commit 97dd13e47b5e241a777ce3f49352d9a4976447f1
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Feb 14 01:11:14 2018

overview: Call grid shutdown when closing last window.

OnGridEmpty which is called when the last window in the grid is deleted
clears window_selectors vector of the grids before calling CancleSelection.
CancelSelection calls WindowGrid::Shutdown on the elements in the vector
of grids, but since OnGridEmpty clears the vector, the grids do not get
Shutdown, by passing some cleanup such as unblurring wallpaper. Manually
call Shutdown in OnGridEmpty.

Test: manual
Bug:  812001 
Change-Id: Ic22fc64b522211ab78d8e9d40e42f7fc6fd3a4b8
Reviewed-on: https://chromium-review.googlesource.com/917219
Reviewed-by: Mitsuru Oshima (In Tokyo) <oshima@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536583}
[modify] https://crrev.com/97dd13e47b5e241a777ce3f49352d9a4976447f1/ash/wm/overview/window_selector.cc

Comment 2 by sammiequon@chromium.org, Feb 14 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment