+oshima, since we had a few discussions on it.
+xdai, since maybe her team will like to take ownership 

xdai, does your team have extra cycles to take care of this?

I'll assign it to myself first. Looks like it doesn't require too much work. so we might be able to target it for 67. Omri, wdyt?

Note that we should still have screen rotation support - i.e. the screen should continue to track the device's physical rotation. Currently this screen rotation support is turned on and off by entering / exiting touchview:

https://cs.chromium.org/chromium/src/ash/display/screen_orientation_controller.cc?sq=package:chromium&dr=CSs&l=357

Sammie, do you have time for this issue? Feel free to assign back to me if you have other plans.

Please hold #4 as the rotation change has special meaning/behavior in tablet mode. 

Could you clarify what you mean by hold #4? IIUC, the specific repro steps "Flip the device into ... tent shape" require that we maintain the 180 degree tent rotation but still remove the touchview maximize mode window manager which makes sense if you want to use an external keyboard / mouse.

What I meant is that we should not allow the sensor based rotation in clamshell mode. If you have a keyboard connected, you can just rotate using keyboard.

Oh I agree, but that's not what I meant by #4. I meant that if we exit touchview mode in tent orientation because a mouse is attached, we should still maintain the 180 degree rotation.

To be more specific, I think that
- automatic screen rotation should be based on whether we believe the lid is open past ~180 degrees regardless of the presence or lack of external keyboards / mice.
- touchview (maximize window manager) mode should only be enabled if there is no mouse attached.

As I mentioned in #4, these two are currently tied together.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/baf66f5ed73b197e44dea0e788a09f203bd20a54

commit baf66f5ed73b197e44dea0e788a09f203bd20a54
Author: Sammie Quon <sammiequon@google.com>
Date: Mon May 07 19:30:38 2018

cros: Disallow tablet mode when external mouse and keyboard attached.

Tablet mode will exit if both are attached during tablet mode. Bending
the lid in any degree will not trigger tablet mode while the external
devices are connected.

Tablet mode controller still tracks if we should be in tablet mode but
are blocked by the external keyboard and mouse, so that after unplugging
the devices, we will enter tablet mode, if necessary.

If the device was in tablet mode and rotated, plugging the external
devices will revert rotation to none and rely on user to use keyboard
to rotate. This behaviour is being discussed on bug, and will be
addressed in follow up cl.

Test: covered by tests
Bug:  811999 
Change-Id: Ia3932f4850246fca80d39a3c7184eae601c77864
Reviewed-on: https://chromium-review.googlesource.com/1040777
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556528}
[modify] https://crrev.com/baf66f5ed73b197e44dea0e788a09f203bd20a54/ash/wm/tablet_mode/tablet_mode_controller.cc
[modify] https://crrev.com/baf66f5ed73b197e44dea0e788a09f203bd20a54/ash/wm/tablet_mode/tablet_mode_controller.h
[modify] https://crrev.com/baf66f5ed73b197e44dea0e788a09f203bd20a54/ash/wm/tablet_mode/tablet_mode_controller_unittest.cc
[modify] https://crrev.com/baf66f5ed73b197e44dea0e788a09f203bd20a54/services/ui/public/cpp/input_devices/input_device_client_test_api.cc
[modify] https://crrev.com/baf66f5ed73b197e44dea0e788a09f203bd20a54/services/ui/public/cpp/input_devices/input_device_client_test_api.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac5c6789cec26607f31bb630a99886fd617741ab

commit ac5c6789cec26607f31bb630a99886fd617741ab
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Jun 13 00:18:02 2018

tablet: Do not enter tablet mode if external mouse connected.

Previously required both external mouse and keyboard to suppress tablet
mode. That has changed in doc [1].

[1] https://docs.google.com/document/d/1TIiQ_30SRc0PZrYVWUgRieTrW1m-7tWsKb6XPKq6UPk/edit?ts=5b1f00c4#

Test: manual
Bug:  811999 
Change-Id: I10d076ec08fc16dd370fca81b4846faf302d4950
Reviewed-on: https://chromium-review.googlesource.com/1098033
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566641}
[modify] https://crrev.com/ac5c6789cec26607f31bb630a99886fd617741ab/ash/wm/tablet_mode/tablet_mode_controller.cc
[modify] https://crrev.com/ac5c6789cec26607f31bb630a99886fd617741ab/ash/wm/tablet_mode/tablet_mode_controller.h
[modify] https://crrev.com/ac5c6789cec26607f31bb630a99886fd617741ab/ash/wm/tablet_mode/tablet_mode_controller_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac5c6789cec26607f31bb630a99886fd617741ab

commit ac5c6789cec26607f31bb630a99886fd617741ab
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Jun 13 00:18:02 2018

tablet: Do not enter tablet mode if external mouse connected.

Previously required both external mouse and keyboard to suppress tablet
mode. That has changed in doc [1].

[1] https://docs.google.com/document/d/1TIiQ_30SRc0PZrYVWUgRieTrW1m-7tWsKb6XPKq6UPk/edit?ts=5b1f00c4#

Test: manual
Bug:  811999 
Change-Id: I10d076ec08fc16dd370fca81b4846faf302d4950
Reviewed-on: https://chromium-review.googlesource.com/1098033
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566641}
[modify] https://crrev.com/ac5c6789cec26607f31bb630a99886fd617741ab/ash/wm/tablet_mode/tablet_mode_controller.cc
[modify] https://crrev.com/ac5c6789cec26607f31bb630a99886fd617741ab/ash/wm/tablet_mode/tablet_mode_controller.h
[modify] https://crrev.com/ac5c6789cec26607f31bb630a99886fd617741ab/ash/wm/tablet_mode/tablet_mode_controller_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac5c6789cec26607f31bb630a99886fd617741ab

commit ac5c6789cec26607f31bb630a99886fd617741ab
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Jun 13 00:18:02 2018

tablet: Do not enter tablet mode if external mouse connected.

Previously required both external mouse and keyboard to suppress tablet
mode. That has changed in doc [1].

[1] https://docs.google.com/document/d/1TIiQ_30SRc0PZrYVWUgRieTrW1m-7tWsKb6XPKq6UPk/edit?ts=5b1f00c4#

Test: manual
Bug:  811999 
Change-Id: I10d076ec08fc16dd370fca81b4846faf302d4950
Reviewed-on: https://chromium-review.googlesource.com/1098033
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566641}
[modify] https://crrev.com/ac5c6789cec26607f31bb630a99886fd617741ab/ash/wm/tablet_mode/tablet_mode_controller.cc
[modify] https://crrev.com/ac5c6789cec26607f31bb630a99886fd617741ab/ash/wm/tablet_mode/tablet_mode_controller.h
[modify] https://crrev.com/ac5c6789cec26607f31bb630a99886fd617741ab/ash/wm/tablet_mode/tablet_mode_controller_unittest.cc

This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

+bhthompson

This is a pre-requisite merge to https://buganizer.corp.google.com/issues/111137179.

I see, if it takes a bunch of backports we probably don't want to merge it, do you think it is worth the risk here?

There should only be two backports, one is already in 68 and there are 2 copies. I'm indifferent to whether we should merge, the merge was requested by a partner in samsung.

If you think it is safe, SGTM. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d1195c9871c839bb7095229ee7de9759a74e995

commit 8d1195c9871c839bb7095229ee7de9759a74e995
Author: Sammie Quon <sammiequon@google.com>
Date: Thu Jul 26 17:48:00 2018

[merge to 68] tablet: Do not enter tablet mode if external mouse connected.

Previously required both external mouse and keyboard to suppress tablet
mode. That has changed in doc [1].

[1] https://docs.google.com/document/d/1TIiQ_30SRc0PZrYVWUgRieTrW1m-7tWsKb6XPKq6UPk/edit?ts=5b1f00c4#

TBR=sammiequon@google.com, xiyuan@chromium.org
(cherry picked from commit ac5c6789cec26607f31bb630a99886fd617741ab)

Test: manual
Bug:  811999 
Change-Id: I10d076ec08fc16dd370fca81b4846faf302d4950
Reviewed-on: https://chromium-review.googlesource.com/1098033
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#566641}
Reviewed-on: https://chromium-review.googlesource.com/1151724
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#753}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/8d1195c9871c839bb7095229ee7de9759a74e995/ash/wm/tablet_mode/tablet_mode_controller.cc
[modify] https://crrev.com/8d1195c9871c839bb7095229ee7de9759a74e995/ash/wm/tablet_mode/tablet_mode_controller.h
[modify] https://crrev.com/8d1195c9871c839bb7095229ee7de9759a74e995/ash/wm/tablet_mode/tablet_mode_controller_unittest.cc