New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 811995 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Delete the non-mmutex version of the run puppet scripts

Project Member Reported by charliea@chromium.org, Feb 13 2018

Issue description

(This is some clean-up work that I need to do in order to wrap up the maintenance mutex project.)

In rolling out the maintenance mutex, I created two versions of the puppet wrapper script: one version that checked for (and subsequently used) mmutex, and another that didn't.

Along the way, I verified that the former version didn't use mmutex if it wasn't deployed to the machine.

Now that we're confident that this works, we want to make sure that we don't have two versions of the puppet wrapper script to maintain forever after. I need to replace the wrapper script that doesn't check for mmutex with the wrapper script that does and delete any logic that switches between the two.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/7bfad5f347bf4c8ee1d64f13ba87b0b67f9083d9

commit 7bfad5f347bf4c8ee1d64f13ba87b0b67f9083d9
Author: Charlie Andrews <charliea@chromium.org>
Date: Wed Feb 14 19:13:41 2018

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/dad3d209c991d84fc69eee1c8644de44170f506f

commit dad3d209c991d84fc69eee1c8644de44170f506f
Author: Charlie Andrews <charliea@chromium.org>
Date: Wed Feb 14 21:59:55 2018

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/a964abacdb593c5b7ba1c1327b65e5598ffd7f1f

commit a964abacdb593c5b7ba1c1327b65e5598ffd7f1f
Author: Charlie Andrews <charliea@chromium.org>
Date: Fri Feb 16 17:58:29 2018

Status: Fixed (was: Assigned)

Sign in to add a comment