New issue
Advanced search Search tips

Issue 811988 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Dropping shill privileges: Spawn l2tpipsec_vpn with correct environment vars

Project Member Reported by mortonm@chromium.org, Feb 13 2018

Issue description

Currently, shill does not pass any environment variables to l2tpipsec_vpn, except for 2 special ones: SHILL_TASK_SERVICE and SHILL_TASK_PATH, whose values are initialized by calls to RPCTaskAdaptorInterface::GetRpcConnectionIdentifier and RPCTaskAdaptorInterface::GetRpcIdentifier. We want to spawn l2tpipsec_vpn in minijail, but currently minijail doesn't support setting environment variables for spawned processes.

Need to add this functionality to minijail or find some workaround.

Code: L2TPIPSecDriver::SpawnL2TPIPSecVPN() --> ExternalTask::Start() --> RPCTask::GetEnvironment() --> RPCTaskAdaptorInterface::**()
 
Identical scenario for /usr/sbin/pppd: https://cs.corp.google.com/chromeos_public/src/aosp/system/connectivity/shill/ppp_daemon.cc?rcl=c02a2bd5716fb95ca088115eecf4ea99cc85069d&l=94 , although haven't triggered this code yet, probably has to do with benchan@'s comment: "shill will also launch pppd directly for some cellular dongles"
Status: Fixed (was: Untriaged)
Fixed by CL:1099491 and CL:1039882

Sign in to add a comment