Add UI audio assets to the component and properly install audio component |
|||||||||||
Issue descriptionSimilar to how we've bundled assets for the environment.
,
Feb 13 2018
,
Feb 14 2018
,
Mar 3 2018
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2808848c3ced6cc6d159d87b129227581020bfb1 commit 2808848c3ced6cc6d159d87b129227581020bfb1 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Thu Mar 08 18:48:36 2018 [vr] Add audio assets Bug: 811987 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1c26701b29d44b6f381fdf67e821d8ebbc0d6a9b Reviewed-on: https://chromium-review.googlesource.com/956003 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#541845} [modify] https://crrev.com/2808848c3ced6cc6d159d87b129227581020bfb1/.gitignore [modify] https://crrev.com/2808848c3ced6cc6d159d87b129227581020bfb1/chrome/browser/resources/vr/assets/PRESUBMIT.py [modify] https://crrev.com/2808848c3ced6cc6d159d87b129227581020bfb1/chrome/browser/resources/vr/assets/VERSION [add] https://crrev.com/2808848c3ced6cc6d159d87b129227581020bfb1/chrome/browser/resources/vr/assets/chromium/back_button_click.wav [add] https://crrev.com/2808848c3ced6cc6d159d87b129227581020bfb1/chrome/browser/resources/vr/assets/chromium/button_click.wav [add] https://crrev.com/2808848c3ced6cc6d159d87b129227581020bfb1/chrome/browser/resources/vr/assets/chromium/button_hover.wav [add] https://crrev.com/2808848c3ced6cc6d159d87b129227581020bfb1/chrome/browser/resources/vr/assets/google_chrome/back_button_click.wav.sha1 [add] https://crrev.com/2808848c3ced6cc6d159d87b129227581020bfb1/chrome/browser/resources/vr/assets/google_chrome/button_click.wav.sha1 [add] https://crrev.com/2808848c3ced6cc6d159d87b129227581020bfb1/chrome/browser/resources/vr/assets/google_chrome/button_hover.wav.sha1 [modify] https://crrev.com/2808848c3ced6cc6d159d87b129227581020bfb1/chrome/browser/resources/vr/assets/vr_assets_component_files.json
,
Mar 8 2018
Published component version 2.0.
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83931b97029e50e50348b26237ace9ab6cbb0c76 commit 83931b97029e50e50348b26237ace9ab6cbb0c76 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Fri Mar 09 16:01:23 2018 [vr] Add compatibility to component 1.y, check integrity of WAV files Bug: 811987 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5c33b4210727b62357e0706c7b19800b98bdebc4 Reviewed-on: https://chromium-review.googlesource.com/956251 Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#542128} [modify] https://crrev.com/83931b97029e50e50348b26237ace9ab6cbb0c76/chrome/browser/component_updater/vr_assets_component_installer.cc [modify] https://crrev.com/83931b97029e50e50348b26237ace9ab6cbb0c76/chrome/browser/vr/assets_loader.cc [modify] https://crrev.com/83931b97029e50e50348b26237ace9ab6cbb0c76/chrome/browser/vr/assets_loader.h
,
Mar 9 2018
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e632d236d0e10d4cea9b112e8cc0445be677ff6c commit e632d236d0e10d4cea9b112e8cc0445be677ff6c Author: Hongchan Choi <hongchan@chromium.org> Date: Fri Mar 09 18:13:58 2018 Revert "[vr] Add compatibility to component 1.y, check integrity of WAV files" This reverts commit 83931b97029e50e50348b26237ace9ab6cbb0c76. Reason for revert: Compilation failure https://ci.chromium.org/buildbot/chromium.memory/Android%20CFI/185 Original change's description: > [vr] Add compatibility to component 1.y, check integrity of WAV files > > Bug: 811987 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I5c33b4210727b62357e0706c7b19800b98bdebc4 > Reviewed-on: https://chromium-review.googlesource.com/956251 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Christopher Grant <cjgrant@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542128} TBR=waffles@chromium.org,cjgrant@chromium.org,tiborg@chromium.org Change-Id: I99aab2f842e064e34ff92cc29501aedc05164b13 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 811987 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/955828 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#542149} [modify] https://crrev.com/e632d236d0e10d4cea9b112e8cc0445be677ff6c/chrome/browser/component_updater/vr_assets_component_installer.cc [modify] https://crrev.com/e632d236d0e10d4cea9b112e8cc0445be677ff6c/chrome/browser/vr/assets_loader.cc [modify] https://crrev.com/e632d236d0e10d4cea9b112e8cc0445be677ff6c/chrome/browser/vr/assets_loader.h
,
Mar 9 2018
,
Mar 9 2018
,
Mar 9 2018
,
Mar 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfaed2050b1e73a5cb442c77bd6d75975a0341e9 commit bfaed2050b1e73a5cb442c77bd6d75975a0341e9 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Mon Mar 12 15:27:42 2018 Reland "[vr] Add compatibility to component 1.y, check integrity of WAV files" This is a reland of 83931b97029e50e50348b26237ace9ab6cbb0c76 Original change's description: > [vr] Add compatibility to component 1.y, check integrity of WAV files > > Bug: 811987 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I5c33b4210727b62357e0706c7b19800b98bdebc4 > Reviewed-on: https://chromium-review.googlesource.com/956251 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Christopher Grant <cjgrant@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542128} TBR=waffles@chromium.org,cjgrant@chromium.org Bug: 811987 Change-Id: I806e84ff18a771fda9ea38f2bfe435b0cdba84f2 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/958008 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#542485} [modify] https://crrev.com/bfaed2050b1e73a5cb442c77bd6d75975a0341e9/chrome/browser/component_updater/vr_assets_component_installer.cc [modify] https://crrev.com/bfaed2050b1e73a5cb442c77bd6d75975a0341e9/chrome/browser/vr/assets_loader.cc [modify] https://crrev.com/bfaed2050b1e73a5cb442c77bd6d75975a0341e9/chrome/browser/vr/assets_loader.h
,
Mar 12 2018
,
Mar 16 2018
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by vollick@chromium.org
, Feb 13 2018