New issue
Advanced search Search tips

Issue 811985 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocking:
issue 703855
issue 793306
issue 642544
issue 793809



Sign in to add a comment

Roll EarlGrey to version from Feb 2018

Project Member Reported by baxley@chromium.org, Feb 13 2018

Issue description

EarlGrey landed some typing improvements, this will hopefully help re-enable some tests.

I quickly tried to compile but there are some deprecated API uses of OSAtomic...

I fixed previous instances with this change:
https://github.com/google/EarlGrey/commit/ccfb82a700a21ca7dee9a76adf9e179b54ee6065

We'll have to update upstream first, then we can roll it.
 

Comment 1 by baxley@chromium.org, Feb 13 2018

Blocking: 793809

Comment 2 by baxley@chromium.org, Feb 13 2018

Blocking: 793306

Comment 3 by baxley@chromium.org, Feb 13 2018

Blocking: 703855

Comment 4 by baxley@chromium.org, Feb 13 2018

Blocking: 642544
Cc: -liaoyuke@chromium.org
Owner: linds...@chromium.org
lindsayw@ are you interested in taking this bug?  Feel free to re-triage if not.
Status: Fixed (was: Assigned)
I forgot to cc this bug on my EG roll:
https://chromium-review.googlesource.com/c/chromium/src/+/1101561

OSAtomic fixes were fixed in Oct 2017 but a bad EG github upload overwrote those fixes so they caught that and fixed that in version 1.14.0.

This is fixed now.

Sign in to add a comment