Reduce system account gerrit bandwidth usage by deploying recipes with CIPD instead of git |
|||||||
Issue description
We've had multiple outages now (Issue 811569, Issue 806021), and one of the exacerbating factors (if not THE factor) is the way that bots bootstrap themselves.
Currently bots using "remote_run" (which is almost all of them on buildbot), or using kitchen (100% of LUCI builds) bootstrap themselves by doing git clones of the recipe repo (e.g. build.git) and all of its dependencies (e.g. depot_tools, recipes-py). None of this is cached and all of it counts directly against our gerrit bandwidth quota. As of today it's about 350MB per build for builders that use the build.git repo. infra.git and build_internal recipes are an extra 100MB and 59MB on top of this, respectively. Any network flakes here turn into retries and so we can get multiply-charged for this bandwidth when gerrit (or network, or swarming, etc.)'s having a bad day.
This bug proposes to do the following:
* Add a builder (triggered by every known recipe repo) which runs a go program that, in parallel, runs `recipes.py bundle` for each repo containing recipes. The output from this will be uploaded to cipd packages, tagged with the input repo revision and will set the 'latest' ref. The program will have an optimization to do nothing if an appropriately-tagged instance already exists in CIPD.
* Change swarmbucket to be configurable so that:
* the CIPD recipe package can be specified on a per builder basis
* the CIPD recipe version can be specified on a per builder basis (defaulting to "latest" to mimic the current recipe behavior)
* if the CIPD package is specified, the swarming task generated by buildbucket will contain it and the kitchen command line will be adjusted to point to the recipes in this folder. Note that from kitchen's point of view this is precisely how `led` works today.
* Update LUCI migration documentation to explicitly mention how recipe bundling works and the role of .gitattribute files in this process (e.g. https://chromium.googlesource.com/chromium/tools/build.git/+/master/.gitattributes).
* Add documentation for how non-chrome teams can configure this go program in luci-scheduler for their repos (so we can transfer the repo update process from the centralized builder to per-team builders).
* Send PSA to all LUCI users about this mechanism being available and how to take advantage of it.
* Start flipping through all chromium LUCI builders to use this mechanism, ending in a state where all chromium builders use the CIPD packages instead of git.
Some side benefits of this:
* Bootstrap for all LUCI tasks should be MUCH MUCH faster (seconds instead of minutes)
* Will open up the possibility of structured recipe rollouts (e.g. canary)
* Since it uses the same file set as `led` it will guarantee that led works for all builders
A downside of this:
* Folks using files outside of the `recipes` subdirectory in their repo will have to be mindful of the .gitattributes files to ensure the bundle picks these files up.
* There will be some additional latency from recipe-commit-time to recipe-deployed-time (on the order of a minute). However this is in exchange for the builds themselves actually taking less time (bootstrapping from CIPD v. git)
,
Feb 13 2018
This work will also de-prioritize the general git cache work in Issue 800447 (but not eliminate it). One of the big reasons we wanted to do that was to improve the bandwidth usage during bootstrap; however the proposal here, I think, will end up being simpler and more robust regardless of git cache.
,
Feb 14 2018
,
Feb 14 2018
(for the record) this all sounds good to me.
,
Feb 14 2018
This sounds great. FWIU this effectively enables canarying of recipes which I believe will make recipe changes much less dangerous; i.e. we could use stable recipes is non-canary builds and use canary or latest recipe in canary builds. By canary builds I mean existing buildbucket canarying mechanism.
,
Feb 14 2018
Yeah, but recipes change significantly more frequently that other stuff we canary (several timers per day vs ~once in two weeks). We'll need an automated canary => stable promotion process.
,
Feb 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/2830a30b99b39d141536b231dfa50af98426c157 commit 2830a30b99b39d141536b231dfa50af98426c157 Author: Robert Iannucci <iannucci@chromium.org> Date: Wed Feb 14 19:38:16 2018 [recipe_bundler] Add main CLI boilerplate. R=tandrii@chromium.org, vadimsh@chromium.org Bug: 811974 Change-Id: I5ac7c15c608c730179150aaabc83fdf2f72b77d8 Reviewed-on: https://chromium-review.googlesource.com/918043 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> [add] https://crrev.com/2830a30b99b39d141536b231dfa50af98426c157/go/src/infra/tools/recipe_bundler/main.go [add] https://crrev.com/2830a30b99b39d141536b231dfa50af98426c157/go/src/infra/tools/recipe_bundler/recipe_bundler.infra_testing
,
Feb 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/0a597d546c7d2503c0b805f81d7408c79689f165 commit 0a597d546c7d2503c0b805f81d7408c79689f165 Author: Robert Iannucci <iannucci@chromium.org> Date: Fri Feb 16 19:29:08 2018 [recipe_bundler] Add basic CLI interface flags and validation. R=tandrii@chromium.org, vadimsh@chromium.org Bug: 811974 Change-Id: I672639ebc92382b15adf82b461e294af9982f876 Reviewed-on: https://chromium-review.googlesource.com/919685 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/0a597d546c7d2503c0b805f81d7408c79689f165/go/src/infra/tools/recipe_bundler/main.go [add] https://crrev.com/0a597d546c7d2503c0b805f81d7408c79689f165/go/src/infra/tools/recipe_bundler/cmd_bundle.go [add] https://crrev.com/0a597d546c7d2503c0b805f81d7408c79689f165/go/src/infra/tools/recipe_bundler/cmd_bundle_test.go [modify] https://crrev.com/0a597d546c7d2503c0b805f81d7408c79689f165/go/src/infra/tools/recipe_bundler/recipe_bundler.infra_testing
,
Feb 16 2018
,
Feb 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/e7db625cc501382b66555db209e6f525f9c2d2de commit e7db625cc501382b66555db209e6f525f9c2d2de Author: Robert Iannucci <iannucci@chromium.org> Date: Sat Feb 17 21:14:15 2018 [recipe_bundler] Add more skeleton. R=tandrii@chromium.org, vadimsh@chromium.org Bug: 811974 Change-Id: Ic27128b615ee7cedb8edcb12835e23df2e917956 Reviewed-on: https://chromium-review.googlesource.com/920904 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> [modify] https://crrev.com/e7db625cc501382b66555db209e6f525f9c2d2de/go/src/infra/tools/recipe_bundler/main.go [modify] https://crrev.com/e7db625cc501382b66555db209e6f525f9c2d2de/go/src/infra/tools/recipe_bundler/cmd_bundle.go [modify] https://crrev.com/e7db625cc501382b66555db209e6f525f9c2d2de/go/src/infra/tools/recipe_bundler/cmd_bundle_test.go [modify] https://crrev.com/e7db625cc501382b66555db209e6f525f9c2d2de/go/src/infra/tools/recipe_bundler/recipe_bundler.infra_testing
,
Feb 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/eb562da3fbe81db6400dade5ec9350d4788c427b commit eb562da3fbe81db6400dade5ec9350d4788c427b Author: Robert Iannucci <iannucci@chromium.org> Date: Thu Feb 22 06:13:27 2018 [cipd] Allow . and / in ref names, extend max ref length to 256. This will allow git refs to be used directly as cipd refs. R=vadimsh@chromium.org Bug: 811974 Change-Id: I450ab94a1d9f2fb681dce482735c813153ebf79d Reviewed-on: https://chromium-review.googlesource.com/930032 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/eb562da3fbe81db6400dade5ec9350d4788c427b/cipd/client/cipd/common/common.go [modify] https://crrev.com/eb562da3fbe81db6400dade5ec9350d4788c427b/cipd/client/cipd/common/common_test.go
,
Feb 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/7265695f08e6c89ef8b5775cfaaf445028505f40 commit 7265695f08e6c89ef8b5775cfaaf445028505f40 Author: Robert Iannucci <iannucci@chromium.org> Date: Thu Feb 22 18:42:44 2018 [swarming] Update swarming server CIPD ref validation regex. R=vadimsh@chromium.org Bug: 811974 Change-Id: I7c489cffb76851cf51625641860f905870d73f48 Reviewed-on: https://chromium-review.googlesource.com/929998 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> [modify] https://crrev.com/7265695f08e6c89ef8b5775cfaaf445028505f40/appengine/swarming/cipd.py
,
Feb 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/6e3ecb23e9056e29a0553656590512374207e343 commit 6e3ecb23e9056e29a0553656590512374207e343 Author: Robert Iannucci <iannucci@chromium.org> Date: Thu Feb 22 19:57:26 2018 [cipd] Allow . and / in ref names, refs up to 256 bytes. This will allow git refs to be used directly as cipd refs. R=vadimsh@chromium.org Bug: 811974 Change-Id: Idb3d43e54047db7a7cd3445c18d0a255fb99e341 Reviewed-on: https://chromium-review.googlesource.com/929899 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/6e3ecb23e9056e29a0553656590512374207e343/appengine/chrome_infra_packages/cipd/impl.py
,
Feb 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/25f9f05f6cedc7672e1a75a75a5734ef36ba7d2f commit 25f9f05f6cedc7672e1a75a75a5734ef36ba7d2f Author: Robert Iannucci <iannucci@chromium.org> Date: Thu Feb 22 20:12:27 2018 [cipd] Bump minor version to 1.7.5 for expanded refs R=vadimsh@chromium.org Bug: 811974 Change-Id: I957990021d7c882ab862fa0bf91eb8291ca2e7d4 Reviewed-on: https://chromium-review.googlesource.com/931997 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/25f9f05f6cedc7672e1a75a75a5734ef36ba7d2f/cipd/client/cipd/client.go
,
Feb 27 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/963c11767391247283ad26e7f3b42bf494a330ce commit 963c11767391247283ad26e7f3b42bf494a330ce Author: Robert Iannucci <iannucci@chromium.org> Date: Tue Feb 27 23:46:31 2018
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/d0de9616e5bb6e4bf96bd92f05f5730b63e75a9e commit d0de9616e5bb6e4bf96bd92f05f5730b63e75a9e Author: Robert Iannucci <iannucci@chromium.org> Date: Wed Feb 28 01:15:45 2018 [cipd] Bump cipd version to ae28364c740acff97ae118adcb2808b6cb5129c5. This allows the cipd client to process refs with slashes in them. Also it is compiled with cgo on OSX, which should help with DNS resolution errors that happen on some machines. R=vadimsh@chromium.org Bug: 811974 , 803673 Change-Id: If298db5cfe0e10e3734deb4215bf82b95ff5e09e Reviewed-on: https://chromium-review.googlesource.com/940521 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> [modify] https://crrev.com/d0de9616e5bb6e4bf96bd92f05f5730b63e75a9e/cipd_client_version
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/25505a2d894312473196f217fe5d608a27653db2 commit 25505a2d894312473196f217fe5d608a27653db2 Author: Robert Iannucci <iannucci@chromium.org> Date: Wed Feb 28 01:18:03 2018 [cipd_bootstrap_v2] Bump CIPD version to ae28364c740acff97ae118adcb2808b6cb5129c5 This allows the cipd client to process refs with slashes in them. R=vadimsh@chromium.org Bug: 811974 Change-Id: I6d558ea27f1dbc6509924a2d962d1ebb54b275dc Reviewed-on: https://chromium-review.googlesource.com/940458 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/25505a2d894312473196f217fe5d608a27653db2/scripts/slave/cipd_bootstrap_v2.py
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/9951acc9de9593d3eeec70733006ee34e7d6a743 commit 9951acc9de9593d3eeec70733006ee34e7d6a743 Author: Robert Iannucci <iannucci@chromium.org> Date: Wed Feb 28 18:32:43 2018 [recipe_bundler] Fully working implementation. Knows how to generate local and remote CIPD packages and sets useful refs for them, as well as tagging them with the resolved revision. This version also resolves symlink refs and the commit to fetch ahead of time, and includes the ref in the CIPD package name (see docstring for scheme). Doing this enables EXTREME PERFORMANCE in the noop case (useful for triggering this on many repos at the same time). :) Bug: 811974 Change-Id: Ib002eb72080481fee7f7833c79f13acba5058b84 Reviewed-on: https://chromium-review.googlesource.com/923558 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/9951acc9de9593d3eeec70733006ee34e7d6a743/go/src/infra/tools/recipe_bundler/cmd_bundle.go [modify] https://crrev.com/9951acc9de9593d3eeec70733006ee34e7d6a743/go/src/infra/tools/recipe_bundler/recipe_bundler.infra_testing [add] https://crrev.com/9951acc9de9593d3eeec70733006ee34e7d6a743/go/src/infra/tools/recipe_bundler/recipes.go [add] https://crrev.com/9951acc9de9593d3eeec70733006ee34e7d6a743/go/src/infra/tools/recipe_bundler/cipd_client.go [add] https://crrev.com/9951acc9de9593d3eeec70733006ee34e7d6a743/go/src/infra/tools/recipe_bundler/run.go [modify] https://crrev.com/9951acc9de9593d3eeec70733006ee34e7d6a743/go/src/infra/tools/recipe_bundler/cmd_bundle_test.go [add] https://crrev.com/9951acc9de9593d3eeec70733006ee34e7d6a743/go/src/infra/tools/recipe_bundler/git.go
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/e4ff278e791b7f1bcce1f195371ab9c8825cbb16 commit e4ff278e791b7f1bcce1f195371ab9c8825cbb16 Author: Robert Iannucci <iannucci@chromium.org> Date: Wed Feb 28 23:11:11 2018 [cr-buildbucket] Refactor recipe integration. This puts all recipe processing logic in a single location, which makes it easier to understand and modify. R=nodir@chromium.org Bug: 811974 Change-Id: I27cfc5934167b90b60cf8ab47dc08b52996fe805 Reviewed-on: https://chromium-review.googlesource.com/940981 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/e4ff278e791b7f1bcce1f195371ab9c8825cbb16/appengine/cr-buildbucket/swarming/swarming.py [modify] https://crrev.com/e4ff278e791b7f1bcce1f195371ab9c8825cbb16/appengine/cr-buildbucket/swarming/test/swarmbucket_api_test.py [modify] https://crrev.com/e4ff278e791b7f1bcce1f195371ab9c8825cbb16/appengine/cr-buildbucket/swarming/test/swarming_test.py
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/8eb4cfbe3fbc7d65821a169b17bcb97088666e8d commit 8eb4cfbe3fbc7d65821a169b17bcb97088666e8d Author: Robert Iannucci <iannucci@chromium.org> Date: Fri Mar 02 08:32:30 2018 [buildbucket] Support CIPD recipe packages. This adds configuration options to Swarmbucket to allow it to fetch recipes from a CIPD package instead of from git. R=nodir@chromium.org Bug: 811974 Change-Id: Ia88810ece41ebc41e98c188c81a416f2bda01c23 Reviewed-on: https://chromium-review.googlesource.com/945421 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/8eb4cfbe3fbc7d65821a169b17bcb97088666e8d/appengine/cr-buildbucket/swarming/swarming.py [modify] https://crrev.com/8eb4cfbe3fbc7d65821a169b17bcb97088666e8d/appengine/cr-buildbucket/swarming/test/swarming_test.py [modify] https://crrev.com/8eb4cfbe3fbc7d65821a169b17bcb97088666e8d/appengine/cr-buildbucket/proto/project_config.proto [modify] https://crrev.com/8eb4cfbe3fbc7d65821a169b17bcb97088666e8d/appengine/cr-buildbucket/proto/project_config_pb2.py
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/0e5e8fd4fae459b353e9ebf9cccc76876e024cf4 commit 0e5e8fd4fae459b353e9ebf9cccc76876e024cf4 Author: Robert Iannucci <iannucci@chromium.org> Date: Fri Mar 02 19:35:54 2018 [recipe_bundler] Add build yaml. R=nodir@chromium.org, vadimsh@chromium.org Bug: 811974 Change-Id: I40d10aeca10d0dc330fd5aa376c68f023dd0f454 Reviewed-on: https://chromium-review.googlesource.com/945372 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [add] https://crrev.com/0e5e8fd4fae459b353e9ebf9cccc76876e024cf4/build/packages/recipe_builder.yaml
,
Mar 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/7f6f817a7aecb8c23869e2d16a437820a5d9148f commit 7f6f817a7aecb8c23869e2d16a437820a5d9148f Author: Robert Iannucci <iannucci@chromium.org> Date: Mon Mar 05 19:34:34 2018 Add recipe_bundler recipe. This is probably the dumbest recipe ever. Once we have CIPD recipe packages available in buildbucket, I'm tempted to replace this recipe with a purpose-built bash script. R=nodir@chromium.org, tandrii@chromium.org, vadimsh@chromium.org Bug: 811974 Change-Id: Ice174c2f80bb5b6c5290285b00279541b978f63a Reviewed-on: https://chromium-review.googlesource.com/949459 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/7f6f817a7aecb8c23869e2d16a437820a5d9148f/recipes/README.recipes.md [add] https://crrev.com/7f6f817a7aecb8c23869e2d16a437820a5d9148f/recipes/recipes/recipe_bundler.expected/basic.json [add] https://crrev.com/7f6f817a7aecb8c23869e2d16a437820a5d9148f/recipes/recipes/recipe_bundler.py
,
Mar 5 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/39a3c8eebfd447b4c5acafcf0f067e9d6a4a7d52 commit 39a3c8eebfd447b4c5acafcf0f067e9d6a4a7d52 Author: Robert Iannucci <iannucci@chromium.org> Date: Mon Mar 05 19:46:04 2018
,
Mar 5 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/583d7d6cff0d489daf7a5c62310c6f7e9ec306a3 commit 583d7d6cff0d489daf7a5c62310c6f7e9ec306a3 Author: Robert Iannucci <iannucci@chromium.org> Date: Mon Mar 05 20:16:00 2018
,
Mar 5 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/f871380001f6d6048a13c17ebdea66401ed70132 commit f871380001f6d6048a13c17ebdea66401ed70132 Author: Robert Iannucci <iannucci@chromium.org> Date: Mon Mar 05 21:11:18 2018
,
Mar 6 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/a4de3561b3881e1994c79077859d25aa30338e38 commit a4de3561b3881e1994c79077859d25aa30338e38 Author: Robert Iannucci <iannucci@chromium.org> Date: Tue Mar 06 21:37:12 2018
,
Mar 6 2018
,
Mar 6 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/a7dad5ddd7d27763bc1ad741d1ee70e605014d78 commit a7dad5ddd7d27763bc1ad741d1ee70e605014d78 Author: Robert Iannucci <iannucci@chromium.org> Date: Tue Mar 06 22:53:14 2018
,
Mar 6 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/163b3354148ea78a1b9cca9a4df3c6b8597d5d55 commit 163b3354148ea78a1b9cca9a4df3c6b8597d5d55 Author: Robert Iannucci <iannucci@chromium.org> Date: Tue Mar 06 23:54:14 2018
,
Mar 7 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/5be4b353065af71449c3a35b37653b461e99ec11 commit 5be4b353065af71449c3a35b37653b461e99ec11 Author: Robert Iannucci <iannucci@chromium.org> Date: Wed Mar 07 00:25:52 2018
,
Mar 7 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/b6e10b3f0b528c9c19469d479e327e8327075ab5 commit b6e10b3f0b528c9c19469d479e327e8327075ab5 Author: Robert Iannucci <iannucci@chromium.org> Date: Wed Mar 07 00:33:29 2018
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/28687ff56e0ee767c9230d387ffc9792c2c8fdf7 commit 28687ff56e0ee767c9230d387ffc9792c2c8fdf7 Author: Robert Iannucci <iannucci@chromium.org> Date: Wed Mar 07 00:42:28 2018 [recipe_bundler] Fix recipe_bundler recipe R=vadimsh@chromium.org Bug: 811974 Change-Id: I818e8eb0f74d46afa3aeb350a79e55ca5b94992b Reviewed-on: https://chromium-review.googlesource.com/952531 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/28687ff56e0ee767c9230d387ffc9792c2c8fdf7/recipes/recipes/recipe_bundler.expected/basic.json [modify] https://crrev.com/28687ff56e0ee767c9230d387ffc9792c2c8fdf7/recipes/recipes/recipe_bundler.py
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/ed5a9c95c144f5d84147742ed72b02215c402913 commit ed5a9c95c144f5d84147742ed72b02215c402913 Author: Robert Iannucci <iannucci@chromium.org> Date: Wed Mar 07 01:04:10 2018 [recipe_bundler] Use debug logging. R=vadimsh@chromium.org Bug: 811974 Change-Id: I6f39fe69717b95ac3b4da1aab6fd90738be7b7ef Reviewed-on: https://chromium-review.googlesource.com/952564 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/ed5a9c95c144f5d84147742ed72b02215c402913/recipes/recipes/recipe_bundler.expected/basic.json [modify] https://crrev.com/ed5a9c95c144f5d84147742ed72b02215c402913/recipes/recipes/recipe_bundler.py
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/2f57730e54273d0f0e3ae8236d82b95ebd7abb64 commit 2f57730e54273d0f0e3ae8236d82b95ebd7abb64 Author: Robert Iannucci <iannucci@chromium.org> Date: Wed Mar 07 01:24:48 2018 [recipe_bundler] Fix bug where we picked "revision" instead of "ref". TBR=vadimsh@chromium.org Bug: 811974 Change-Id: I8acb1c65f75c6a3b67e855529f55e6827bb357b7 Reviewed-on: https://chromium-review.googlesource.com/952580 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/2f57730e54273d0f0e3ae8236d82b95ebd7abb64/go/src/infra/tools/recipe_bundler/cmd_bundle.go
,
Mar 7 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/f2c9f2ac36d80cce77ce304311a7e12f9af41ac6 commit f2c9f2ac36d80cce77ce304311a7e12f9af41ac6 Author: Robert Iannucci <iannucci@chromium.org> Date: Wed Mar 07 02:14:14 2018
,
Mar 7 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/10f92d393f0109e35e61f3897dffaeecadb37053 commit 10f92d393f0109e35e61f3897dffaeecadb37053 Author: Robert Iannucci <iannucci@chromium.org> Date: Wed Mar 07 02:41:33 2018
,
Mar 7 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/3246bcccf293bca082d58049bce1573dcd7aa2ac commit 3246bcccf293bca082d58049bce1573dcd7aa2ac Author: Robert Iannucci <iannucci@chromium.org> Date: Wed Mar 07 02:51:49 2018
,
Mar 7 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/1b3301035e097639974060e14f180a9e37a43653 commit 1b3301035e097639974060e14f180a9e37a43653 Author: Robert Iannucci <iannucci@chromium.org> Date: Wed Mar 07 03:01:50 2018
,
Mar 7 2018
Ok! We now have the recipe-bundler running on luci-scheduler for all chromium repos (build, infra, build_internal, release scripts). It's using a pinned version of recipes (using a bundle that it created for itself). The builds take ~3 seconds to run when there's no work to do. Woohoo! Next steps: * document how this all works * add playbook entries for it * add alerts for this builder * Update LUCI migration docs * Write "run your own bundler" docs (for non-chromium users) * send PSA * start rolling it out to real builders
,
Mar 7 2018
Great progress! Thanks for the update.
,
Mar 7 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/120942ebccb85d3132f1767bde63a093c2da1965 commit 120942ebccb85d3132f1767bde63a093c2da1965 Author: Robert Iannucci <iannucci@chromium.org> Date: Wed Mar 07 19:15:46 2018
,
Mar 7 2018
Above commit was adding a luci-notify entry for this builder (going to my email for now). Next I'll work on documentation/playbook.
,
Mar 7 2018
For posterity, the alerting schemes considered were: 1. Basic build failure alerting (using luci-notify) 2. Alerting when the lag between git and CIPD package availability was too high. Not sure how to implement this, but this would really be the best solution. 3. Alerting when builds on recipe-bundler take too long. In the end, we went with option 1. I think I'll also implement option 3 in a poor-man's way by setting a maximum execution time of 5 minutes for the builder.
,
Mar 7 2018
Re 3: Buildbucket sends the stats to tsmon - http://shortn/_p41HuO1rB2 Maybe we can setup real alert based on them.
,
Mar 7 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/415bb5b46626021521790147b02df95a54635dad commit 415bb5b46626021521790147b02df95a54635dad Author: Robert Iannucci <iannucci@chromium.org> Date: Wed Mar 07 23:02:51 2018
,
Mar 8 2018
Yeah well... I just set a max execution time, so it'll get covered by 1. In case cipd backend decides to get sassy.
,
Mar 8 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/e98cd216ed47e20249b71c4385fa9afa63cadadd commit e98cd216ed47e20249b71c4385fa9afa63cadadd Author: Robert Iannucci <iannucci@chromium.org> Date: Thu Mar 08 01:54:36 2018
,
Mar 8 2018
We now have N+2 redundancy for this builder :p
,
Mar 9 2018
,
Mar 9 2018
Updated luci migration doc too (see "files missing from recipes" in "common issues")
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/9c7c5d6669de83823c9a34c7da11c7891d09662d commit 9c7c5d6669de83823c9a34c7da11c7891d09662d Author: Robert Iannucci <iannucci@chromium.org> Date: Fri Mar 09 19:45:06 2018 [recipe_bundler] Make prefixes required, always set-ref. This makes the prefix settings explicitly required by the tool to prevent accidental uploads to the production CIPD packages. It also changes so that when the tool is supposed to check out "FETCH_HEAD" (aka "the latest version of the given ref"), it will call `cipd set-ref` even if the CIPD package tagged with the resolved git commit has already been uploaded. R=vadimsh@google.com Bug: 811974 Change-Id: I3e0b7b0db3f9200f26d59846afbb2e6e46cd2d34 Reviewed-on: https://chromium-review.googlesource.com/956880 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> [modify] https://crrev.com/9c7c5d6669de83823c9a34c7da11c7891d09662d/recipes/README.recipes.md [modify] https://crrev.com/9c7c5d6669de83823c9a34c7da11c7891d09662d/go/src/infra/tools/recipe_bundler/cmd_bundle.go [modify] https://crrev.com/9c7c5d6669de83823c9a34c7da11c7891d09662d/recipes/recipes/recipe_bundler.expected/basic.json [modify] https://crrev.com/9c7c5d6669de83823c9a34c7da11c7891d09662d/recipes/recipes/recipe_bundler.py
,
Mar 9 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/62a252e1c9af1230ea7602d858706816b64197f3 commit 62a252e1c9af1230ea7602d858706816b64197f3 Author: Robert Iannucci <iannucci@chromium.org> Date: Fri Mar 09 22:57:51 2018
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/cbaa13a61c2ddb66affda73a0e1fbbc43f1f6e3d commit cbaa13a61c2ddb66affda73a0e1fbbc43f1f6e3d Author: Robert Iannucci <iannucci@chromium.org> Date: Fri Mar 09 23:13:39 2018 [recipe_bundler] Actually set package name. R=tandrii@chromium.org Bug: 811974 Change-Id: I2ba15e21fc9f93625dd8859d7dd439b971ec68bb Reviewed-on: https://chromium-review.googlesource.com/957702 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/cbaa13a61c2ddb66affda73a0e1fbbc43f1f6e3d/go/src/infra/tools/recipe_bundler/cmd_bundle.go
,
Mar 9 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/033ef1c33c2b96a33d735c9860e42d5059a42a68 commit 033ef1c33c2b96a33d735c9860e42d5059a42a68 Author: Robert Iannucci <iannucci@chromium.org> Date: Fri Mar 09 23:32:19 2018
,
Mar 9 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/81cf5c977ac545205024a6bd7d13d196fbeaf965 commit 81cf5c977ac545205024a6bd7d13d196fbeaf965 Author: Robert Iannucci <iannucci@chromium.org> Date: Fri Mar 09 23:38:50 2018
,
Mar 10 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/4fb5919fd824abd637d05180e12b3d6dc4ca6f3e commit 4fb5919fd824abd637d05180e12b3d6dc4ca6f3e Author: Robert Iannucci <iannucci@chromium.org> Date: Sat Mar 10 00:15:44 2018
,
Mar 10 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/725181b961fccd23e48caf72a49b1bc7776991d9 commit 725181b961fccd23e48caf72a49b1bc7776991d9 Author: Robert Iannucci <iannucci@chromium.org> Date: Sat Mar 10 16:53:12 2018
,
Mar 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/0cd6b63eb21f8b8ffe2ddd9d13c3d0a478f0f372 commit 0cd6b63eb21f8b8ffe2ddd9d13c3d0a478f0f372 Author: Robert Iannucci <iannucci@chromium.org> Date: Sat Mar 10 18:22:18 2018 [cr-buildbucket] Improve swarmingcfg validation for CIPD recipes. Also change default package ref from 'head' to 'refs/heads/master' to match current recipe_bundler behavior. R=nodir@chromium.org, tandrii@chromium.org Bug: 811974 Change-Id: I7d12fd6e46737c236e16d13a2e9881a610b2b4d3 Reviewed-on: https://chromium-review.googlesource.com/957823 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/0cd6b63eb21f8b8ffe2ddd9d13c3d0a478f0f372/appengine/cr-buildbucket/swarming/swarming.py [modify] https://crrev.com/0cd6b63eb21f8b8ffe2ddd9d13c3d0a478f0f372/appengine/cr-buildbucket/swarming/test/swarmingcfg_test.py [modify] https://crrev.com/0cd6b63eb21f8b8ffe2ddd9d13c3d0a478f0f372/appengine/cr-buildbucket/swarming/swarmingcfg.py
,
Mar 10 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/6fa6caca9cfec019710002f31fe1bca502d32cb1 commit 6fa6caca9cfec019710002f31fe1bca502d32cb1 Author: Robert Iannucci <iannucci@chromium.org> Date: Sat Mar 10 20:48:57 2018
,
Mar 10 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/5660049101aed00c927bda3e32ee0881fceed01b commit 5660049101aed00c927bda3e32ee0881fceed01b Author: Robert Iannucci <iannucci@chromium.org> Date: Sat Mar 10 20:50:00 2018
,
Mar 10 2018
General Docs: https://chrome-internal.googlesource.com/infra/infra_internal/+/master/doc/recipe_bundler.md Playbook: https://chrome-internal.googlesource.com/infra/infra_internal/+/master/doc/troopers/playbook.md#RecipeBundlerFailure Alerts: https://critique.corp.google.com/#review/188556986 Migration doc: https://docs.google.com/document/d/121dSdjBu4jjxC9vq5SGeEoaPlmmGWHl-LECXBjHfmQ4/edit#heading=h.kpgn7o1shn4x Run-your-own-builder: https://chrome-internal.googlesource.com/infra/infra_internal/+/master/doc/recipe_bundler.md#recipe-bundler-setup
,
Mar 12 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/5d7e26470583e1ed78dd896d82f0cc409804487b commit 5d7e26470583e1ed78dd896d82f0cc409804487b Author: Robert Iannucci <iannucci@chromium.org> Date: Mon Mar 12 00:13:02 2018
,
Mar 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55a7b7bc7b8b8bbd4941359faeffb61510012352 commit 55a7b7bc7b8b8bbd4941359faeffb61510012352 Author: Robert Iannucci <iannucci@chromium.org> Date: Mon Mar 12 20:13:42 2018 [cr-buildbucket-dev] Use bundled recipes for all of cr-buildbucket-dev. R=nodir@chromium.org Bug: 811974 Change-Id: I5959edc280c02937b66417ea035f8012feb5bb33 Reviewed-on: https://chromium-review.googlesource.com/958038 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#542579} [modify] https://crrev.com/55a7b7bc7b8b8bbd4941359faeffb61510012352/infra/config/global/cr-buildbucket-dev.cfg
,
Mar 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/ca25e9275536e0236670d0284fa7467302cd043e commit ca25e9275536e0236670d0284fa7467302cd043e Author: Nodir Turakulov <nodir@google.com> Date: Mon Mar 12 21:11:41 2018 [cr-buildbucket] treat "-" repository as empty dash is useful when overriding a recipe repo. Bug: 811974 Change-Id: I53c5a10e1b852a4355691363ca8c4f07edeef7ce Reviewed-on: https://chromium-review.googlesource.com/959426 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/ca25e9275536e0236670d0284fa7467302cd043e/appengine/cr-buildbucket/swarming/swarming.py [modify] https://crrev.com/ca25e9275536e0236670d0284fa7467302cd043e/appengine/cr-buildbucket/swarming/test/swarmingcfg_test.py [modify] https://crrev.com/ca25e9275536e0236670d0284fa7467302cd043e/appengine/cr-buildbucket/proto/project_config.proto [modify] https://crrev.com/ca25e9275536e0236670d0284fa7467302cd043e/appengine/cr-buildbucket/swarming/swarmingcfg.py
,
Mar 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1148692354415e735eecfed7268312e81e9fec9 commit b1148692354415e735eecfed7268312e81e9fec9 Author: Robert Iannucci <iannucci@chromium.org> Date: Mon Mar 12 22:54:43 2018 [recipe_bundler] Convert fyi-ci builders to CIPD recipes R=jbudorick@chromium.org, nodir@chromium.org Bug: 811974 Change-Id: I2f13b98fb0f82e38aa526ff4b8696614e6ef0746 Reviewed-on: https://chromium-review.googlesource.com/959586 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#542640} [modify] https://crrev.com/b1148692354415e735eecfed7268312e81e9fec9/infra/config/global/cr-buildbucket.cfg
,
Mar 13 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/379649d89da72a59c0f1d3fee1930e63276b9c17 commit 379649d89da72a59c0f1d3fee1930e63276b9c17 Author: Robert Iannucci <iannucci@chromium.org> Date: Tue Mar 13 01:46:13 2018
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/9c285ae33a9061acf18c3c94784b0c21aabdf102 commit 9c285ae33a9061acf18c3c94784b0c21aabdf102 Author: Robert Iannucci <iannucci@chromium.org> Date: Tue Mar 13 02:05:12 2018 [infra] Switch all infra bots to use CIPD recipes R=nodir@chromium.org, tandrii@chromium.org Bug: 811974 Change-Id: I5ab8ade15a3abdb65dff34078dd64d4786af3b02 Reviewed-on: https://chromium-review.googlesource.com/959598 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/9c285ae33a9061acf18c3c94784b0c21aabdf102/cr-buildbucket-dev.cfg [modify] https://crrev.com/9c285ae33a9061acf18c3c94784b0c21aabdf102/cr-buildbucket.cfg
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/34ac69aa62eb7b0417a1fbcedab83d628961e61d commit 34ac69aa62eb7b0417a1fbcedab83d628961e61d Author: Robert Iannucci <iannucci@chromium.org> Date: Tue Mar 13 02:25:02 2018 Whitespace to test new build config. TBR=nodir@chromium.org, tandrii@chromium.org Bug: 811974 Change-Id: I5215376eae4ee613a3de5461a3cdf2159a392ae9 Reviewed-on: https://chromium-review.googlesource.com/959578 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/34ac69aa62eb7b0417a1fbcedab83d628961e61d/WHITESPACE
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a178491a30d3a35113c7b40ed0eeceebdfa25e13 commit a178491a30d3a35113c7b40ed0eeceebdfa25e13 Author: Robert Iannucci <iannucci@chromium.org> Date: Tue Mar 13 02:59:02 2018 Switch fuchsia builders to use CIPD recipes TBR=jbudorick@chromium.org, tandrii@chromium.org Bug: 811974 Change-Id: I1cbeab2333cd9a243177cf9a4e1d1bd73b1efc19 Reviewed-on: https://chromium-review.googlesource.com/959745 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#542704} [modify] https://crrev.com/a178491a30d3a35113c7b40ed0eeceebdfa25e13/infra/config/global/cr-buildbucket.cfg
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/650b4468e7d58695402d174a00951d4fc867797e commit 650b4468e7d58695402d174a00951d4fc867797e Author: Robbie Iannucci <iannucci@chromium.org> Date: Tue Mar 13 03:19:25 2018 Revert "[infra] Switch all infra bots to use CIPD recipes" This reverts commit 9c285ae33a9061acf18c3c94784b0c21aabdf102. Reason for revert: Windows bots are unhappy about this Original change's description: > [infra] Switch all infra bots to use CIPD recipes > > R=nodir@chromium.org, tandrii@chromium.org > > Bug: 811974 > Change-Id: I5ab8ade15a3abdb65dff34078dd64d4786af3b02 > Reviewed-on: https://chromium-review.googlesource.com/959598 > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Commit-Queue: Robbie Iannucci <iannucci@chromium.org> TBR=iannucci@chromium.org,nodir@chromium.org,tandrii@chromium.org Change-Id: I4e70d14fe2fffe28bb608c5f74c4fd36799dca37 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 811974 Reviewed-on: https://chromium-review.googlesource.com/959722 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/650b4468e7d58695402d174a00951d4fc867797e/cr-buildbucket-dev.cfg [modify] https://crrev.com/650b4468e7d58695402d174a00951d4fc867797e/cr-buildbucket.cfg
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/recipes-py/+/5c6e39ec6dee4d110839f61767a361979ae13dda commit 5c6e39ec6dee4d110839f61767a361979ae13dda Author: Robert Iannucci <iannucci@chromium.org> Date: Tue Mar 13 06:18:20 2018 [bundle] Copy file data instead of symlinks. Windows doesn't like 'em, and we don't really need 'em. Keep it simple :) R=tandrii@chromium.org, vadimsh@chromium.org Bug: 811974 Change-Id: I72fd296ab662f1acfd21a451a4525849d1e777b5 Reviewed-on: https://chromium-review.googlesource.com/959539 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/5c6e39ec6dee4d110839f61767a361979ae13dda/recipe_engine/bundle.py
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/fd9cd6e80683a3dfc8b0c4f5661d565a3f1e8463 commit fd9cd6e80683a3dfc8b0c4f5661d565a3f1e8463 Author: Robert Iannucci <iannucci@chromium.org> Date: Tue Mar 13 07:02:33 2018 Reland "[infra] Switch all infra bots to use CIPD recipes" This is a reland of 9c285ae33a9061acf18c3c94784b0c21aabdf102 Original change's description: > [infra] Switch all infra bots to use CIPD recipes > > R=nodir@chromium.org, tandrii@chromium.org > > Bug: 811974 > Change-Id: I5ab8ade15a3abdb65dff34078dd64d4786af3b02 > Reviewed-on: https://chromium-review.googlesource.com/959598 > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Commit-Queue: Robbie Iannucci <iannucci@chromium.org> TBR: nodir@chromium.org, tandrii@chromium.org Bug: 811974 Change-Id: I660f35b5e2b56900d9e76bfd434c6c828a41f674 Reviewed-on: https://chromium-review.googlesource.com/959754 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/fd9cd6e80683a3dfc8b0c4f5661d565a3f1e8463/cr-buildbucket-dev.cfg [modify] https://crrev.com/fd9cd6e80683a3dfc8b0c4f5661d565a3f1e8463/cr-buildbucket.cfg
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/3f1cf7a6152c04512456d67c429175a1062c0d1c commit 3f1cf7a6152c04512456d67c429175a1062c0d1c Author: Robert Iannucci <iannucci@chromium.org> Date: Tue Mar 13 10:04:02 2018 Remove dependency on depot_tools auto_stub and mox. It turns out that presubmit was exposing the versions in the depot_tools that belongs to the recipes. Ick. R=maruel@chromium.org, vadimsh@chromium.org Bug: 811974 Change-Id: I024c3866662ef111e8731331bf2e07cfc18ad122 Reviewed-on: https://chromium-review.googlesource.com/959881 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/3f1cf7a6152c04512456d67c429175a1062c0d1c/scripts/slave/unittests/results_dashboard_test.py [modify] https://crrev.com/3f1cf7a6152c04512456d67c429175a1062c0d1c/scripts/tools/unittests/botreboot_test.py [modify] https://crrev.com/3f1cf7a6152c04512456d67c429175a1062c0d1c/scripts/slave/unittests/upload_perf_dashboard_results_test.py [modify] https://crrev.com/3f1cf7a6152c04512456d67c429175a1062c0d1c/scripts/slave/ios/xctest_utils_test.py [modify] https://crrev.com/3f1cf7a6152c04512456d67c429175a1062c0d1c/scripts/common/unittests/gtest_utils_test.py [modify] https://crrev.com/3f1cf7a6152c04512456d67c429175a1062c0d1c/scripts/slave/recipe_modules/swarming/unittests/standard_isolated_script_merge_test.py [modify] https://crrev.com/3f1cf7a6152c04512456d67c429175a1062c0d1c/scripts/slave/recipe_modules/swarming/unittests/collect_task_test.py [modify] https://crrev.com/3f1cf7a6152c04512456d67c429175a1062c0d1c/scripts/slave/recipe_modules/swarming/unittests/standard_gtest_merge_test.py
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88e78b4b7be97c04c92ed66d5393781e1adb08ce commit 88e78b4b7be97c04c92ed66d5393781e1adb08ce Author: Robert Iannucci <iannucci@chromium.org> Date: Tue Mar 13 21:42:09 2018 [recipe_bundler] Use CIPD recipe bundles for linux CI and Try builders. R=jbudorick@chromium.org Bug: 811974 Change-Id: I4430e7324c1e091e6e137147e24f9c869f2efd77 Reviewed-on: https://chromium-review.googlesource.com/961481 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#542922} [modify] https://crrev.com/88e78b4b7be97c04c92ed66d5393781e1adb08ce/infra/config/global/cr-buildbucket.cfg
,
Mar 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/964a8c4ad62c3ef5b358112b196abddccd5d5cdc commit 964a8c4ad62c3ef5b358112b196abddccd5d5cdc Author: Robert Iannucci <iannucci@chromium.org> Date: Wed Mar 14 02:33:07 2018 [recipe_bundler] Use CIPD recipe bundles for the rest of Chromium. R=jbudorick@chromium.org Bug: 811974 Change-Id: I50908b28ce18fabf62f033563669f194b68fb9a4 Reviewed-on: https://chromium-review.googlesource.com/961531 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#542989} [modify] https://crrev.com/964a8c4ad62c3ef5b358112b196abddccd5d5cdc/infra/config/global/cr-buildbucket.cfg
,
Mar 14 2018
Here's the graph of gerrit bandwidth usage for our LUCI system account: http://shortn/_2opnx7Zd9c You may notice it's zero. 🎉 \o/ 🎉
,
Mar 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/7c35171f0bf2061e5c231e5f4df1982dfa8066a6 commit 7c35171f0bf2061e5c231e5f4df1982dfa8066a6 Author: Robert Iannucci <iannucci@chromium.org> Date: Wed Mar 14 08:11:19 2018 [led] Update led to work with CIPD bundled recipes. R=agable@chromium.org, tandrii@chromium.org Bug: 811974 Change-Id: Ibfb16ac8598f470e8c54523147a0553dc6bd2294 Reviewed-on: https://chromium-review.googlesource.com/961396 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/7c35171f0bf2061e5c231e5f4df1982dfa8066a6/go/src/infra/tools/led/job_userland.go [modify] https://crrev.com/7c35171f0bf2061e5c231e5f4df1982dfa8066a6/go/src/infra/tools/led/cmd_edit_recipe_bundle.go [modify] https://crrev.com/7c35171f0bf2061e5c231e5f4df1982dfa8066a6/go/src/infra/tools/led/job.go [modify] https://crrev.com/7c35171f0bf2061e5c231e5f4df1982dfa8066a6/go/src/infra/tools/led/job_edit.go [modify] https://crrev.com/7c35171f0bf2061e5c231e5f4df1982dfa8066a6/go/src/infra/tools/led/job_def.go [modify] https://crrev.com/7c35171f0bf2061e5c231e5f4df1982dfa8066a6/go/src/infra/tools/led/cmd_edit.go
,
Mar 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/1c9c003404cd5b286a33c480b0c3af9297537c3b commit 1c9c003404cd5b286a33c480b0c3af9297537c3b Author: Robert Iannucci <iannucci@chromium.org> Date: Wed Mar 14 09:02:44 2018 [led] Bump to support CIPD Recipes. TBR=tandrii@chromium.org Bug: 811974 Change-Id: I1ace75471dfbe2798c7c848f76d6607b34ff1033 Reviewed-on: https://chromium-review.googlesource.com/962082 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/1c9c003404cd5b286a33c480b0c3af9297537c3b/cipd_manifest.txt
,
Mar 16 2018
This seems to have stuck, calling this one done!
,
Mar 16 2018
we need to remove account from humongous quota bucket.
,
Jun 5 2018
Filed issue 849526 for quota update. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by iannucci@chromium.org
, Feb 13 2018