Android Snapshot Upload Logic Under Viz |
|||||
Issue descriptionWhen a tab is backgrounded, Android saves a snapshot to memory or disk. In tab resume cases, the Browser process queries for whether it has live content (a valid compositor frame) for a given renderer, and only if this is missing does it upload the saved tab snapshot which can be used as a fallback frame. As the DisplayCompositor now lives in the Viz process, it may be harder to query this information, and the Browser may end up uploading snapshots in more cases. We should assess whether we can avoid this or whether the cost is low enough that just always uploading is fine.
,
Feb 13 2018
+dtrainor@
,
May 22 2018
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f31f0ee83accc280b26c3c1307a7c6280ec0937 commit 8f31f0ee83accc280b26c3c1307a7c6280ec0937 Author: Saman Sami <samans@chromium.org> Date: Fri Jun 01 19:11:58 2018 Use HostFrameSinkManager for taking snapshots on Android This will make snapshots work with viz. This CL shouldn't functionally affect non-viz setup because HostFrameSinkManager forwards the copy request to CompositorFrameSinkSupport. Bug: 811973 Change-Id: Ia131c1952530b408ae1b1cc5545ea59d5463f6f2 Reviewed-on: https://chromium-review.googlesource.com/1081894 Reviewed-by: Khushal <khushalsagar@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#563749} [modify] https://crrev.com/8f31f0ee83accc280b26c3c1307a7c6280ec0937/ui/android/delegated_frame_host_android.cc
,
Jun 5 2018
Is there more work to do here?
,
Jun 12 2018
I haven't noticed any issues. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by fsamuel@google.com
, Feb 13 2018