New issue
Advanced search Search tips
Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment
link

Issue 811956: Remove chrome://view-http-cache

Reported by eroman@chromium.org, Feb 13 2018 Project Member

Issue description

Comment 1 by mmenke@chromium.org, Feb 13 2018

This has been hooked up when the network service is enabled, so there are two hookups you'll need to remove (You'll presumably notice this, anyways, while tearing it down).  There may also be some cache integration tests that use it.

Comment 2 by eroman@chromium.org, Feb 13 2018

Yeah, the network service case has been the most work, since it uses that URL for caching unit-tests

Comment 3 by bugdroid1@chromium.org, Feb 21 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc

commit 6ebc11f6f6d112e4cca5251d4c0203e18cd79adc
Author: Eric Roman <eroman@chromium.org>
Date: Wed Feb 21 19:32:24 2018

Remove chrome://view-http-cache.

This was also aliased by chrome://cache.

TBR=palmer@chromium.org,hubbe@chromium.org

Bug:  811956 ,  809823 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_mojo
Change-Id: I2187a3956d913f8f110b0f7b5296e84beb2a82ac
Reviewed-on: https://chromium-review.googlesource.com/917303
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538186}
[modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/chrome/browser/browser_about_handler.cc
[modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/chrome/browser/browser_about_handler_unittest.cc
[modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/chrome/browser/net/network_context_configuration_browsertest.cc
[modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/chrome/browser/resources/net_internals/http_cache_view.html
[modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/chrome/common/webui_url_constants.cc
[modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/chrome/common/webui_url_constants.h
[modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/content/browser/BUILD.gn
[delete] https://crrev.com/421a0bb636d7fe67e4712a71c85c92c101c42268/content/browser/net/view_http_cache_job_factory.cc
[delete] https://crrev.com/421a0bb636d7fe67e4712a71c85c92c101c42268/content/browser/net/view_http_cache_job_factory.h
[modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/content/browser/webui/url_data_manager_backend.cc
[delete] https://crrev.com/421a0bb636d7fe67e4712a71c85c92c101c42268/content/browser/webui/web_ui_browsertest.cc
[modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/content/browser/webui/web_ui_url_loader_factory.cc
[modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/content/public/common/url_constants.cc
[modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/content/public/common/url_constants.h
[modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/content/test/BUILD.gn
[modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/media/cast/net/udp_socket_client_unittest.cc
[modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/services/network/BUILD.gn
[delete] https://crrev.com/421a0bb636d7fe67e4712a71c85c92c101c42268/services/network/cache_url_loader.cc
[delete] https://crrev.com/421a0bb636d7fe67e4712a71c85c92c101c42268/services/network/cache_url_loader.h
[modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/services/network/network_context.cc
[modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/services/network/network_context.h
[modify] https://crrev.com/6ebc11f6f6d112e4cca5251d4c0203e18cd79adc/services/network/public/mojom/network_service.mojom

Comment 4 by eroman@chromium.org, Feb 21 2018

Status: Fixed (was: Assigned)

Sign in to add a comment