New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 811948 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task


Sign in to add a comment

Replace blink side UseCounter by browser side UseCounter

Project Member Reported by loonyb...@chromium.org, Feb 13 2018

Issue description

Blink side UseCounter has many limitations (e.g. does not work correctly with OOPIF, making it hard to workers, etc).
A browser side UseCounter is implemented using PageLoadMetricsObserver.
Once the accuracy of the browser side counter is verified, the blink side counter should be replaced. 
 
Blocking: 716565
A browser side histogram (Blink.UseCounter.Features_TestBrowserProcessLogging) has been added (see details in  issue 716565 ).
Blocking: 814837
Blockedon: 818687 716565 818684
Blockedon: 819225
Blockedon: 819226
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/398cf0803ed34aaac96e94eff016529d391a4aa3

commit 398cf0803ed34aaac96e94eff016529d391a4aa3
Author: Luna Lu <loonybear@chromium.org>
Date: Tue Mar 13 21:22:46 2018

Rename UseCounter histograms

OOPIF is going to roll out in M67, this means the blink side UseCounter will no
longer be accurate. Switching to the browser side UseCounter in this CL.

However, there's still existing bugs where the browser sise UseCounter is not
working correctly, tracked in  crbug.com/811948 .

Bug:  811948 ,  716565 
Change-Id: I112f82d5f6b938dce4bbe394413068a8c3472498
Reviewed-on: https://chromium-review.googlesource.com/957472
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542913}
[modify] https://crrev.com/398cf0803ed34aaac96e94eff016529d391a4aa3/chrome/browser/page_load_metrics/observers/use_counter_page_load_metrics_observer.h
[modify] https://crrev.com/398cf0803ed34aaac96e94eff016529d391a4aa3/chrome/browser/ui/search/local_ntp_browsertest.cc
[modify] https://crrev.com/398cf0803ed34aaac96e94eff016529d391a4aa3/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/398cf0803ed34aaac96e94eff016529d391a4aa3/third_party/WebKit/Source/core/frame/UseCounter.cpp
[modify] https://crrev.com/398cf0803ed34aaac96e94eff016529d391a4aa3/third_party/WebKit/Source/core/frame/UseCounterTest.cpp
[modify] https://crrev.com/398cf0803ed34aaac96e94eff016529d391a4aa3/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
[modify] https://crrev.com/398cf0803ed34aaac96e94eff016529d391a4aa3/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment