Replace blink side UseCounter by browser side UseCounter |
||||||||
Issue descriptionBlink side UseCounter has many limitations (e.g. does not work correctly with OOPIF, making it hard to workers, etc). A browser side UseCounter is implemented using PageLoadMetricsObserver. Once the accuracy of the browser side counter is verified, the blink side counter should be replaced. ⛆ |
|
|
,
Feb 21 2018
A browser side histogram (Blink.UseCounter.Features_TestBrowserProcessLogging) has been added (see details in issue 716565 ).
,
Feb 22 2018
,
Mar 6 2018
,
Mar 6 2018
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/398cf0803ed34aaac96e94eff016529d391a4aa3 commit 398cf0803ed34aaac96e94eff016529d391a4aa3 Author: Luna Lu <loonybear@chromium.org> Date: Tue Mar 13 21:22:46 2018 Rename UseCounter histograms OOPIF is going to roll out in M67, this means the blink side UseCounter will no longer be accurate. Switching to the browser side UseCounter in this CL. However, there's still existing bugs where the browser sise UseCounter is not working correctly, tracked in crbug.com/811948 . Bug: 811948 , 716565 Change-Id: I112f82d5f6b938dce4bbe394413068a8c3472498 Reviewed-on: https://chromium-review.googlesource.com/957472 Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Rick Byers <rbyers@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#542913} [modify] https://crrev.com/398cf0803ed34aaac96e94eff016529d391a4aa3/chrome/browser/page_load_metrics/observers/use_counter_page_load_metrics_observer.h [modify] https://crrev.com/398cf0803ed34aaac96e94eff016529d391a4aa3/chrome/browser/ui/search/local_ntp_browsertest.cc [modify] https://crrev.com/398cf0803ed34aaac96e94eff016529d391a4aa3/content/browser/service_worker/service_worker_browsertest.cc [modify] https://crrev.com/398cf0803ed34aaac96e94eff016529d391a4aa3/third_party/WebKit/Source/core/frame/UseCounter.cpp [modify] https://crrev.com/398cf0803ed34aaac96e94eff016529d391a4aa3/third_party/WebKit/Source/core/frame/UseCounterTest.cpp [modify] https://crrev.com/398cf0803ed34aaac96e94eff016529d391a4aa3/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp [modify] https://crrev.com/398cf0803ed34aaac96e94eff016529d391a4aa3/tools/metrics/histograms/histograms.xml
,
Mar 22 2018
|
|||||
►
Sign in to add a comment |
||||||||
Comment 1 by loonyb...@chromium.org
, Feb 21 2018