New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 811928 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 810128
issue 803548



Sign in to add a comment

RenderWidgetHostInputEventRouter should use HitTestQuery for transforming locations

Project Member Reported by riajiang@chromium.org, Feb 13 2018

Issue description

Currently in RenderWidgetHostInputEventRouter, we use TransformPointToCoordSpaceForView [1] to transform locations, which uses SurfaceHittest in normal chrome. Need to change that to use HitTestQuery::TransformLocationForTarget instead, because we don't want to use SurfaceHittest in normal chrome and can't use SurfaceHittest in OOP-D.

[1] https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_view_base.h?l=328

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56501686b916ffce0338aa6330ede842b0517b40

commit 56501686b916ffce0338aa6330ede842b0517b40
Author: Ria Jiang <riajiang@chromium.org>
Date: Fri Mar 02 00:56:54 2018

Use HitTestQuery to transform locations in RWHInputEventRouter.

Currently in RenderWidgetHostInputEventRouter, we use
TransformPointToCoordSpaceForView [1] to transform locations, which uses
SurfaceHittest in normal chrome. We don't want to use SurfaceHittest in
normal chrome and can't use SurfaceHittest in OOP-D.

This CL changes to use HitTestQuery::TransformLocationForTarget instead.

[1] https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_view_base.h?l=328

Bug:  811928 
Test: site-per-process-hit-test-browsertests
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ie2ea51f0c12e17612aca17e322b592cdbdce5614
Reviewed-on: https://chromium-review.googlesource.com/917205
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540387}
[modify] https://crrev.com/56501686b916ffce0338aa6330ede842b0517b40/components/viz/host/hit_test/hit_test_query.cc
[modify] https://crrev.com/56501686b916ffce0338aa6330ede842b0517b40/components/viz/host/hit_test/hit_test_query.h
[modify] https://crrev.com/56501686b916ffce0338aa6330ede842b0517b40/components/viz/host/hit_test/hit_test_query_unittest.cc
[modify] https://crrev.com/56501686b916ffce0338aa6330ede842b0517b40/content/browser/renderer_host/render_widget_host_input_event_router.cc
[modify] https://crrev.com/56501686b916ffce0338aa6330ede842b0517b40/content/browser/renderer_host/render_widget_host_input_event_router.h

Labels: Merge-Request-66 OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
M66 branch revision is 540276, but the CL in c#1 is 540387 (landed on branch cut day), can we merge it back?
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 3 2018

Labels: -Merge-Request-66 Merge-Approved-66 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 5 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b388b7e32c542d710b47a20d8f7fa6972796a63

commit 8b388b7e32c542d710b47a20d8f7fa6972796a63
Author: Ria Jiang <riajiang@chromium.org>
Date: Mon Mar 05 17:29:31 2018

Use HitTestQuery to transform locations in RWHInputEventRouter.

Currently in RenderWidgetHostInputEventRouter, we use
TransformPointToCoordSpaceForView [1] to transform locations, which uses
SurfaceHittest in normal chrome. We don't want to use SurfaceHittest in
normal chrome and can't use SurfaceHittest in OOP-D.

This CL changes to use HitTestQuery::TransformLocationForTarget instead.

[1] https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_view_base.h?l=328

Bug:  811928 
Test: site-per-process-hit-test-browsertests
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ie2ea51f0c12e17612aca17e322b592cdbdce5614
Reviewed-on: https://chromium-review.googlesource.com/917205
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540387}(cherry picked from commit 56501686b916ffce0338aa6330ede842b0517b40)
Reviewed-on: https://chromium-review.googlesource.com/949078
Reviewed-by: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#11}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/8b388b7e32c542d710b47a20d8f7fa6972796a63/components/viz/host/hit_test/hit_test_query.cc
[modify] https://crrev.com/8b388b7e32c542d710b47a20d8f7fa6972796a63/components/viz/host/hit_test/hit_test_query.h
[modify] https://crrev.com/8b388b7e32c542d710b47a20d8f7fa6972796a63/components/viz/host/hit_test/hit_test_query_unittest.cc
[modify] https://crrev.com/8b388b7e32c542d710b47a20d8f7fa6972796a63/content/browser/renderer_host/render_widget_host_input_event_router.cc
[modify] https://crrev.com/8b388b7e32c542d710b47a20d8f7fa6972796a63/content/browser/renderer_host/render_widget_host_input_event_router.h

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edcd09ea13535bee12b7bf131d6b79a185114990

commit edcd09ea13535bee12b7bf131d6b79a185114990
Author: Ria Jiang <riajiang@chromium.org>
Date: Mon May 07 18:19:44 2018

Use HitTestQuery to transform locations in RenderWidgetHostViewBase.

1. Changed TransformPointToLocalCoordSpace to be non-virtual and use
HitTestQuery when we use Viz hit-test. If there are no viz::EventSource
specified, we match viz::EventSource::ALL (added) events. Added
TransformPointToLocalCoordSpaceLegacy (virtual) to do essentially what
TransformPointToLocalCoordSpace used to do on different platforms.

2. TransformPointToRootCoordSpaceF, TransformRootPointToViewCoordSpace and
TransformPointToCoordSpaceForView all use TransformPointToLocalCoordSpace
essentially, added necessary info to use the new version correctly.

3. Overridded GetRootFrameSinkId() in RenderWidgetHostViewChildFrame and
RenderWidgetHostViewGuest.

Bug:  811928 
Test: covered by tests
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I6d36e954d821ff5a9f6b68b545acd1ef4a3a2114
Reviewed-on: https://chromium-review.googlesource.com/940602
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556502}
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/components/viz/host/hit_test/hit_test_query.cc
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/components/viz/host/hit_test/hit_test_query.h
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/content/browser/frame_host/cross_process_frame_connector.cc
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/content/browser/frame_host/cross_process_frame_connector.h
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/content/browser/frame_host/render_widget_host_view_guest.h
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/content/browser/pointer_lock_browsertest.cc
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/content/browser/renderer_host/DEPS
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/content/browser/renderer_host/delegated_frame_host.h
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/content/browser/renderer_host/frame_connector_delegate.cc
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/content/browser/renderer_host/frame_connector_delegate.h
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/content/browser/renderer_host/render_widget_host_input_event_router.cc
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/content/browser/renderer_host/render_widget_host_input_event_router.h
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/content/browser/renderer_host/render_widget_host_input_event_router_unittest.cc
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/content/browser/renderer_host/render_widget_host_view_base.cc
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/content/browser/renderer_host/render_widget_host_view_base.h
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/content/browser/renderer_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/edcd09ea13535bee12b7bf131d6b79a185114990/content/browser/site_per_process_hit_test_browsertest.cc

Sign in to add a comment