New issue
Advanced search Search tips

Issue 811922 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 5
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 430155



Sign in to add a comment

Animation Worklet - Origin Trial Integration

Project Member Reported by majidvp@chromium.org, Feb 13 2018

Issue description

This bug tracks specific work that is done to prepare AnimationWorklet for origin trial.
 
Intent to Experiment thread sent to blink-dev:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/AZ-PYPMS7EA/DEqbe2u5BQAJ
Status: Started (was: Assigned)
Here are two WIP patch:
Add feature measurements for AnimationWorklet: https://chromium-review.googlesource.com/c/chromium/src/+/916886
Integrate with OT infra: https://chromium-review.googlesource.com/c/chromium/src/+/917125
Blocking: 430155
Labels: -Type-Bug Type-Feature
Summary: Animation Worklet - Origin Trial (was: Animation Worklet - Original Trial)
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/384c9d450f2d0301fbfa138d79dce8bdd5eac6c8

commit 384c9d450f2d0301fbfa138d79dce8bdd5eac6c8
Author: Majid Valipour <majidvp@chromium.org>
Date: Mon Feb 26 22:45:44 2018

[animation-worklet] Integrate AnimationWorklet with origin trial infra

Intent to Experiment:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/AZ-PYPMS7EA/DEqbe2u5BQAJ

Bug:  811922 
Change-Id: I967df8e38d55cffc985ca8982f3762e95aa08ae7
Reviewed-on: https://chromium-review.googlesource.com/917125
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539299}
[add] https://crrev.com/384c9d450f2d0301fbfa138d79dce8bdd5eac6c8/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/animationworklet-origin-trial-interfaces.html
[modify] https://crrev.com/384c9d450f2d0301fbfa138d79dce8bdd5eac6c8/third_party/WebKit/Source/core/animation/ScrollTimeline.cpp
[modify] https://crrev.com/384c9d450f2d0301fbfa138d79dce8bdd5eac6c8/third_party/WebKit/Source/core/animation/ScrollTimeline.idl
[modify] https://crrev.com/384c9d450f2d0301fbfa138d79dce8bdd5eac6c8/third_party/WebKit/Source/core/testing/InternalSettings.cpp
[modify] https://crrev.com/384c9d450f2d0301fbfa138d79dce8bdd5eac6c8/third_party/WebKit/Source/core/testing/InternalSettings.h
[modify] https://crrev.com/384c9d450f2d0301fbfa138d79dce8bdd5eac6c8/third_party/WebKit/Source/modules/animationworklet/AnimationWorkletGlobalScope.idl
[modify] https://crrev.com/384c9d450f2d0301fbfa138d79dce8bdd5eac6c8/third_party/WebKit/Source/modules/animationworklet/EffectProxy.idl
[modify] https://crrev.com/384c9d450f2d0301fbfa138d79dce8bdd5eac6c8/third_party/WebKit/Source/modules/animationworklet/WindowAnimationWorklet.idl
[modify] https://crrev.com/384c9d450f2d0301fbfa138d79dce8bdd5eac6c8/third_party/WebKit/Source/modules/animationworklet/WorkletAnimation.idl
[modify] https://crrev.com/384c9d450f2d0301fbfa138d79dce8bdd5eac6c8/third_party/WebKit/Source/platform/runtime_enabled_features.json5

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d84bf05cbc3856aedeaf971adfe1986bcd50d5e

commit 9d84bf05cbc3856aedeaf971adfe1986bcd50d5e
Author: Majid Valipour <majidvp@chromium.org>
Date: Thu Mar 01 17:03:16 2018

[animation-worklet] Correctly expose EffectProxy is worklet scope

Fix an issue in AnimationWorkletGlobalScope binding generation where
EffectProxy was not being exposed in that scope.

It also adds a test to verify all the interfaces that are exposed in
the animation worklet global scope under origin trial.

The test is relying on console.log and expectation file which is
why I decided to not write it as a testharness based test.

Bug:  811922 
Change-Id: If13d3797f908d3f0a3945480e22c6e63cad9f76e
Reviewed-on: https://chromium-review.googlesource.com/935702
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jason Chase <chasej@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540190}
[add] https://crrev.com/9d84bf05cbc3856aedeaf971adfe1986bcd50d5e/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/animationworklet-origin-trial-interfaces-worklet-scope-expected.txt
[add] https://crrev.com/9d84bf05cbc3856aedeaf971adfe1986bcd50d5e/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/animationworklet-origin-trial-interfaces-worklet-scope.html
[modify] https://crrev.com/9d84bf05cbc3856aedeaf971adfe1986bcd50d5e/third_party/WebKit/Source/modules/animationworklet/EffectProxy.idl
[modify] https://crrev.com/9d84bf05cbc3856aedeaf971adfe1986bcd50d5e/third_party/WebKit/Source/modules/modules_idl_files.gni

Status: Fixed (was: Started)
Summary: Animation Worklet - Origin Trial Integration (was: Animation Worklet - Origin Trial)
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfa88e80c3052ed9f73cf98bf5a99d20feb17c32

commit cfa88e80c3052ed9f73cf98bf5a99d20feb17c32
Author: Majid Valipour <majidvp@chromium.org>
Date: Mon Nov 12 16:28:36 2018

[animation-worklet] AnimationWorklet runtime flags should imply WebAnimationsAPI

AnimationWorklet and ScrollTimeline heavily depend on WebAnimations API.
For example to build the most basic example based on AnimationWorklet one
needs to construct a KeyframeEffect.

This CL will ensure that AnimationWorklet flag also enables WebAnimationsAPI
runtime feature.

Bug:  903953 ,  811922 
Change-Id: Ie1f92ee2e579541675f88b762cbc30895bc66942
Reviewed-on: https://chromium-review.googlesource.com/c/1329891
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607250}
[modify] https://crrev.com/cfa88e80c3052ed9f73cf98bf5a99d20feb17c32/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/animationworklet-origin-trial-interfaces.html
[modify] https://crrev.com/cfa88e80c3052ed9f73cf98bf5a99d20feb17c32/third_party/blink/renderer/platform/runtime_enabled_features.json5

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 13

Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28a90438b5c0fc7fde25e94429608fee46b8a100

commit 28a90438b5c0fc7fde25e94429608fee46b8a100
Author: Majid Valipour <majidvp@chromium.org>
Date: Tue Nov 13 15:34:04 2018

[animation-worklet] AnimationWorklet runtime flags should imply WebAnimationsAPI

AnimationWorklet and ScrollTimeline heavily depend on WebAnimations API.
For example to build the most basic example based on AnimationWorklet one
needs to construct a KeyframeEffect.

This CL will ensure that AnimationWorklet flag also enables WebAnimationsAPI
runtime feature.

Bug:  903953 ,  811922 
Change-Id: Ie1f92ee2e579541675f88b762cbc30895bc66942
Reviewed-on: https://chromium-review.googlesource.com/c/1329891
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#607250}(cherry picked from commit cfa88e80c3052ed9f73cf98bf5a99d20feb17c32)
Reviewed-on: https://chromium-review.googlesource.com/c/1333890
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#657}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/28a90438b5c0fc7fde25e94429608fee46b8a100/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/animationworklet-origin-trial-interfaces.html
[modify] https://crrev.com/28a90438b5c0fc7fde25e94429608fee46b8a100/third_party/blink/renderer/platform/runtime_enabled_features.json5

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/28a90438b5c0fc7fde25e94429608fee46b8a100

Commit: 28a90438b5c0fc7fde25e94429608fee46b8a100
Author: majidvp@chromium.org
Commiter: majidvp@chromium.org
Date: 2018-11-13 15:34:04 +0000 UTC

[animation-worklet] AnimationWorklet runtime flags should imply WebAnimationsAPI

AnimationWorklet and ScrollTimeline heavily depend on WebAnimations API.
For example to build the most basic example based on AnimationWorklet one
needs to construct a KeyframeEffect.

This CL will ensure that AnimationWorklet flag also enables WebAnimationsAPI
runtime feature.

Bug:  903953 ,  811922 
Change-Id: Ie1f92ee2e579541675f88b762cbc30895bc66942
Reviewed-on: https://chromium-review.googlesource.com/c/1329891
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#607250}(cherry picked from commit cfa88e80c3052ed9f73cf98bf5a99d20feb17c32)
Reviewed-on: https://chromium-review.googlesource.com/c/1333890
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#657}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment