Issue metadata
Sign in to add a comment
|
PDF form calculations stopped working
Reported by
tech...@d91.net,
Feb 13 2018
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36 Example URL: http://www.pdfscripting.com/public/FreeStuff/PDFSamples/SimpleCalcExample_v2.pdf Steps to reproduce the problem: 1. Open PDF form with 'simple' calculations (First row in example) 2. Enter in values in fields 3. View incorrect answer What is the expected behavior? Math will work correctly. What went wrong? Built in calculations do not add/multiply correctly. Does it occur on multiple sites: Yes Is it a problem with a plugin? Yes PDF Viewer Did this work before? Yes 63.0.3239.132 Does this work in other browsers? Yes Chrome version: 64.0.3282.140 Channel: stable OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Shockwave Flash 28.0 r0 Noticed this issue in an internal PDF form used for purchasing requests, so I went and found a public form that can replicate the issue. I have tested the linked SimpleCalcExample_v2.pdf and our internal form in Chrome 63.x and Adobe Reader and the calculations work as expected. In Chrome 64.x they do not.
,
Feb 13 2018
,
Feb 15 2018
,
Feb 15 2018
,
Feb 15 2018
,
Feb 16 2018
https://chromium.googlesource.com/chromium/src/+log/9e956deeaf2ab913c3f1f82b56fc9f7e885209fc..6a0943d812263288972d4197252f78386edb76de -> One of the two CLs in r511585.
,
Feb 26 2018
,
Feb 26 2018
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium/+/9141116074f9209f617d9607e747c8947c952c46 commit 9141116074f9209f617d9607e747c8947c952c46 Author: Dan Sinclair <dsinclair@chromium.org> Date: Mon Feb 26 18:19:14 2018 Fixup AFSimple_Calculate indexing bug The refactoring in [1] introduced a bug where we pulled the wrong array index to get the array of fields to use in the AFSimple_Calculate method. This caused the calculation to not be performed as the fields could not be found. This CL fixes up the index and adds a test to verify we use AFSimple_Calucate to sum two fields. 1- https://pdfium-review.googlesource.com/c/pdfium/+/16670 Bug: chromium:811913 Change-Id: I2abb9fe4fe2d6969ce1876736faadf252ef90575 Reviewed-on: https://pdfium-review.googlesource.com/27670 Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by: Ryan Harrison <rharrison@chromium.org> [add] https://crrev.com/9141116074f9209f617d9607e747c8947c952c46/testing/resources/calculate.pdf [add] https://crrev.com/9141116074f9209f617d9607e747c8947c952c46/testing/resources/calculate.in [modify] https://crrev.com/9141116074f9209f617d9607e747c8947c952c46/fxjs/cjs_publicmethods.cpp [modify] https://crrev.com/9141116074f9209f617d9607e747c8947c952c46/fxjs/cjs_publicmethods_embeddertest.cpp
,
Feb 26 2018
,
Feb 26 2018
This bug requires manual review: We are only 7 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 26 2018
Before we approve merge to M65, could you pls confirm followings? This is regressed in M64 and M65 is very close to stable promotion, can't this wait until M66? If it is critical to merge, pls provide merge justification and how safe it is. Thank you.
,
Feb 26 2018
This initially broke in M64 and wasn't noticed until now, so it maybe safe to ignore. Without this change, any PDF which uses the AF calculate methods will fail to work correctly as the text fields won't be found. I don't know how common this is (outside of the 2 mentions in this bug from users). The change is a 1-bit change to fix a refactoring that switched a 1 to a 0, so it should be safe to merge.
,
Feb 26 2018
Ok, pls update the bug with canary result tomorrow. Thank you.
,
Feb 27 2018
Able to reproduce this issue on reported version 64.0.3282.140 using Mac, windows and Linux. Hence verified the fix on latest canary 66.0.3356.0 using Mac, Windows and Linux. Fix is working as expected. i.e; Calculations are working as expected. Attaching screenshot for reference. Hence adding TE-Verified labels. Thanks!
,
Feb 27 2018
The NextAction date has arrived: 2018-02-27
,
Feb 27 2018
I don't see anything showing up in crash for this method, and it was verified by TE, so I believe this is safe to merge.
,
Feb 27 2018
Approving merge to M65 branch 3325 based on comments #12, #14 and #17. Please merge ASAP so we can pick it up for tomorrow's last M65 beta release. Thank you.
,
Feb 27 2018
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium/+/e839a6adb305467759e0d22fe7532a72fe4d8fa7 commit e839a6adb305467759e0d22fe7532a72fe4d8fa7 Author: Dan Sinclair <dsinclair@chromium.org> Date: Tue Feb 27 15:46:52 2018 [Merge M65] Fixup AFSimple_Calculate indexing bug The refactoring in [1] introduced a bug where we pulled the wrong array index to get the array of fields to use in the AFSimple_Calculate method. This caused the calculation to not be performed as the fields could not be found. This CL fixes up the index and adds a test to verify we use AFSimple_Calucate to sum two fields. 1- https://pdfium-review.googlesource.com/c/pdfium/+/16670 TBR: rharrision@chromium.org Bug: chromium:811913 Change-Id: I2abb9fe4fe2d6969ce1876736faadf252ef90575 Reviewed-on: https://pdfium-review.googlesource.com/27670 Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by: Ryan Harrison <rharrison@chromium.org> (cherry picked from commit 9141116074f9209f617d9607e747c8947c952c46) Reviewed-on: https://pdfium-review.googlesource.com/27750 Reviewed-by: dsinclair <dsinclair@chromium.org> [add] https://crrev.com/e839a6adb305467759e0d22fe7532a72fe4d8fa7/testing/resources/calculate.pdf [add] https://crrev.com/e839a6adb305467759e0d22fe7532a72fe4d8fa7/testing/resources/calculate.in [modify] https://crrev.com/e839a6adb305467759e0d22fe7532a72fe4d8fa7/fxjs/cjs_publicmethods.cpp [modify] https://crrev.com/e839a6adb305467759e0d22fe7532a72fe4d8fa7/fxjs/cjs_publicmethods_embeddertest.cpp |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dba...@ursulinestl.org
, Feb 13 2018