AddressSpaceRandomizationTest.RandomBitCorrelations23 started flaking in base_unittests on Fuchsia |
|||
Issue descriptione.g. https://ci.chromium.org/buildbot/chromium.fyi/Fuchsia%20(dbg)/16162 00174.735] 03926.03995> [ RUN ] AddressSpaceRandomizationTest.RandomBitCorrelations23 [00174.735] 03926.03995> [3:1515976145:0213/030615.610222:174680488:FATAL:address_space_randomization_unittest.cc(185)] Check failed: 24 >= chi_squared (24 vs. 26.01) #00: base::debug::StackTrace::StackTrace(unsigned long) at ??:? #01: base::debug::StackTrace::StackTrace() at ??:? #02: logging::LogMessage::~LogMessage() at ??:? #03: base::RandomBitCorrelation(int) at ??:? #04: base::AddressSpaceRandomizationTest_RandomBitCorrelations23_Test::TestBody() at ??:? #05: void testing::internal::InvokeHelper<void, std::__1::tuple<> >::InvokeMethod<base::RunLoop, void (base::RunLoop::*)()>(base::RunLoop*, void (base::RunLoop::*)(), std::__1::tuple<> const&) at ??:? #06: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) at ??:? #07: testing::Test::Run() at ??:? #08: testing::TestInfo::Run() at ??:? #09: testing::TestCase::Run() at ??:? #10: testing::internal::UnitTestImpl::RunAllTests() at ??:? #11: bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) at ??:? #12: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) at ??:? #13: testing::UnitTest::Run() at ??:? #14: RUN_ALL_TESTS() at ??:? #15: base::TestSuite::Run() at ??:? #16: void base::internal::FunctorTraits<void (base::WaitableEvent::*)(), void>::Invoke<base::WaitableEvent*>(void (base::WaitableEvent::*)(), base::WaitableEvent*&&) at ??:? #17: void base::internal::InvokeHelper<false, void>::MakeItSo<void (base::WaitableEvent::*)(), base::WaitableEvent*>(void (base::WaitableEvent::*&&)(), base::WaitableEvent*&&) at ??:? #18: void base::internal::Invoker<base::internal::BindState<void (base::WaitableEvent::*)(), base::internal::UnretainedWrapper<base::WaitableEvent> >, void ()>::RunImpl<void (base::WaitableEvent::*)(), std::__1::tuple<base::internal::UnretainedWrapper<base::WaitableEvent> >, 0ul>(void (base::WaitableEvent::*&&)(), std::__1::tuple<base::internal::UnretainedWrapper<base::WaitableEvent> >&&, std::__1::integer_sequence<unsigned long, 0ul>) at ??:? #19: base::internal::Invoker<base::internal::BindState<void (base::WaitableEvent::*)(), base::internal::UnretainedWrapper<base::WaitableEvent> >, void ()>::Run(base::internal::BindStateBase*) at ??:? #20: base::RepeatingCallback<void ()>::Run() const & at ??:? #21: base::(anonymous namespace)::LaunchUnitTestsInternal(base::RepeatingCallback<int ()> const&, unsigned long, int, bool, base::RepeatingCallback<void ()> const&) at ??:? #22: base::LaunchUnitTests(int, char**, base::RepeatingCallback<int ()> const&) at ??:? #23: main at ??:? #24: pc 0x4cb6bdce910e (libc.so,0x1b10e) [00174.743] 03926.03995> [00174.744] 03926.03995> [2229/2927] AddressSpaceRandomizationTest.RandomBitCorrelations23 (CRASHED)
,
Feb 13 2018
This actually looks like the RNG went over the allowable non-randomness. I'll look into why that happens, or if we need to relax the threshold in the test.
,
Feb 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5b81ccb0cd7e6da884e902505704c85f09cb4bb commit b5b81ccb0cd7e6da884e902505704c85f09cb4bb Author: Scott Graham <scottmg@chromium.org> Date: Tue Feb 13 19:29:56 2018 fuchsia: Disable some flaky tests base_unittests AddressSpaceRandomizationTest.RandomBitCorrelations23 seems newish, but has failed a couple times. ipc_tests BadMessage has failed a number of times over the last week. mojo_system_unittests MultiprocessMessagePipeTestWithPeerSupport is also very flaky over the last week. Bug: 764018 , 810448 , 811881 Change-Id: If010457d69209c6a12d36aa4ffe49ae35600b623 Reviewed-on: https://chromium-review.googlesource.com/916724 Commit-Queue: Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#536421} [modify] https://crrev.com/b5b81ccb0cd7e6da884e902505704c85f09cb4bb/testing/buildbot/filters/fuchsia.base_unittests.filter [modify] https://crrev.com/b5b81ccb0cd7e6da884e902505704c85f09cb4bb/testing/buildbot/filters/fuchsia.ipc_tests.filter [modify] https://crrev.com/b5b81ccb0cd7e6da884e902505704c85f09cb4bb/testing/buildbot/filters/fuchsia.mojo_system_unittests.filter
,
Feb 13 2018
Removing myself since Scott's change mutes the failures. Leaving it open because I suspect other bit position tests (not just 23) will also fail, and because someone may want to investigate the cause.
,
Feb 16 2018
Doh, https://build.chromium.org/p/chromium.fyi/builders/Fuchsia%20%28dbg%29/builds/16374 failed RandomBitCorrelations25. I guess we should probably disable * instead of just individual ones?
,
Feb 16 2018
Yep, afraid so.
,
Feb 16 2018
*ahem* Yeah, I probably should have spotted that in most reputable PRNGs all bits should be equivalently randomized. ;)
,
Feb 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a9e74f5e0fc86a1a4fb9a02bc91e4b35d3eb7e6 commit 7a9e74f5e0fc86a1a4fb9a02bc91e4b35d3eb7e6 Author: Scott Graham <scottmg@chromium.org> Date: Fri Feb 16 22:07:12 2018 fuchsia: Disable a couple flaky tests Both from this run: https://build.chromium.org/p/chromium.fyi/builders/Fuchsia%20%28dbg%29/builds/16374 Bug: 764015 , 811881 Change-Id: If6954f1ded3ad61961dd60c994ef7d1d905351c9 Reviewed-on: https://chromium-review.googlesource.com/923431 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#537426} [modify] https://crrev.com/7a9e74f5e0fc86a1a4fb9a02bc91e4b35d3eb7e6/testing/buildbot/filters/fuchsia.base_unittests.filter [modify] https://crrev.com/7a9e74f5e0fc86a1a4fb9a02bc91e4b35d3eb7e6/testing/buildbot/filters/fuchsia.ipc_tests.filter
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62c715550ee24d8b24ef1069819719c2d3abafb0 commit 62c715550ee24d8b24ef1069819719c2d3abafb0 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Mon Jun 18 19:36:35 2018 Filter out all remaining base tests on Fuchsia. This removes all the remaining disabled tests in the filter file for base tests on Fuchsia and instead filters each of them individually. Bug: 738275, 752368, 753490, 810077, 811881, 851734, 851747, 851759, 851760 Change-Id: I375954138d09ebacc05b2ad37afe1e09901e52e2 Reviewed-on: https://chromium-review.googlesource.com/1096483 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#568112} [modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/allocator/partition_allocator/address_space_randomization_unittest.cc [modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/files/file_proxy_unittest.cc [modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/files/file_util_unittest.cc [modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/message_loop/message_loop_unittest.cc [modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/metrics/field_trial_unittest.cc [modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/observer_list_unittest.cc [modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/process/process_util_unittest.cc [modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/synchronization/condition_variable_unittest.cc [modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/sys_info_unittest.cc [modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/threading/platform_thread_unittest.cc [modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/trace_event/process_memory_dump_unittest.cc [modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/trace_event/trace_category_unittest.cc [modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/testing/buildbot/filters/fuchsia.base_unittests.filter |
|||
►
Sign in to add a comment |
|||
Comment 1 by w...@chromium.org
, Feb 13 2018Owner: bbudge@chromium.org
Status: Assigned (was: Unconfirmed)