"Share Your Screen" picker dialog does not have the Share button enabled by default |
|||||||
Issue descriptionChrome Version: (copy from chrome://version) Version 66.0.3343.3 (Official Build) dev (64-bit) OS: (e.g. Win7, OSX 10.9.5, etc...) MacOS High Sierra 17D47 What steps will reproduce the problem? (1) present to a hangouts meet meeting (2) observe that the "Share Your Screen" dialog opens (3) What is the expected result? The share button is enabled. What happens instead? The share button is disabled. Please use labels and text to provide additional information. Clicking on the white area then click back on the desktop icon works; double-clicking on the desktop icon also works; and switching to one of the other tabs in the picker then switching back would enable the "Share" button. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Feb 13 2018
,
Feb 15 2018
I can't reproduce using exactly the same versions (OS and browser). Please add detailed steps about how the sharing is initiated.
,
Feb 15 2018
Got it figured out, it happens only when you have all 3 options (desktop, window, tab) enabled. Did a quick bisect: https://chromium.googlesource.com/chromium/src/+log/76abb33952e2e1a490b41ba7f8927f96e359fb0c..a5252e85ac6d36e0a8fa45193292b53d7058123d Qiang, which CL of these do you think caused this?
,
Feb 15 2018
I think it is due to https://chromium-review.googlesource.com/c/chromium/src/+/895529
,
Feb 15 2018
OK, assigning over to reviewer, author on cc.
,
Feb 15 2018
[1] changes the enable state of shareButton_ when we change the selection of Tab Share list. But we have to make sure only when the "Chrome Tab" is in the front, we can do this. Otherwise, it may happen that the tab selection changes automatically (during initialization, tab closed, new tab open), and we make "Share" button into wrong state. [1] https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm?q=desktop_media_picker_con&sq=package:chromium&l=602
,
Feb 16 2018
Thanks for pointing this out! In mentioned CL I set button enabled/disabled state in setTabBrowserIndex. Not checking that corresponding tab is active. If this is the problem, then adding check for active tab may solve this issue.
,
Feb 26 2018
Guys, we need to get this fixed or reverted, ideally before the cut this week.
,
Feb 26 2018
I'm fine with reverting
,
May 25 2018
What's the latest status here?
,
May 25 2018
This bug should be fixed now, that just needs to be tested/confirmed. Bug was introduced in crash fix: https://chromium-review.googlesource.com/c/chromium/src/+/895529 . But that crash fix was reverted in CL: https://chromium-review.googlesource.com/c/chromium/src/+/941541. Also no worries about crash fix reverted because of this comment: https://chromium-review.googlesource.com/c/chromium/src/+/938801#message-61d50f1ea6f9b726e1e5980fe5ff8a6281ecd598
,
May 25 2018
Verified. Thanks. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by q...@chromium.org
, Feb 13 2018