New issue
Advanced search Search tips

Issue 811749 link

Starred by 3 users

Issue metadata

Status: Verified
Owner: ----
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

crosvm: using "crosvm stop <socket>" does not work

Project Member Reported by robert.b...@intel.com, Feb 13 2018

Issue description

When providing a socket to run with "-s" and then calling "crosvm stop <socket>" the running VM does not shutdown.
 

Comment 1 Deleted

Comment 2 Deleted

Comment 3 by dgreid@chromium.org, Feb 13 2018

Components: OS>Systems>Containers
Labels: -Pri-3 Pri-1
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/30ebd272d69c64e691054f31d75b324ad20ec905

commit 30ebd272d69c64e691054f31d75b324ad20ec905
Author: Rob Bradford <robert.bradford@intel.com>
Date: Wed Feb 14 01:40:53 2018

crosvm: allow control of running VM via socket

Remove control_sockets definition that shadows earlier one which
contains the opened socket for receiving messages for controlling the
running VM. This shadowing meant that the messages sent over the socket
were not handled.

TEST="crosvm run -s" with socket and then subsequent "crosvm stop"
causes the running VM to be shutdown
BUG= 811749 

Signed-off-by: Rob Bradford <robert.bradford@intel.com>
Change-Id: If5a82ec10c29ab037cbedcf7acea23a49b4cfeb6
Reviewed-on: https://chromium-review.googlesource.com/916264
Commit-Ready: Dylan Reid <dgreid@chromium.org>
Tested-by: Dylan Reid <dgreid@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/30ebd272d69c64e691054f31d75b324ad20ec905/src/linux.rs

Comment 5 by dgreid@chromium.org, Feb 14 2018

Status: Verified (was: Untriaged)
Thanks! Also added an auto test to catch this, once they start running.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/6c7ca93e28bb2a9cef146ef7cd001930cb63c367

commit 6c7ca93e28bb2a9cef146ef7cd001930cb63c367
Author: Zach Reizner <zachr@google.com>
Date: Thu Mar 08 00:55:08 2018

REAPPLY: crosvm: allow control of running VM via socket

This change was overwritten yet again by a bad rebase. In this case it
was CL:942084.

TEST="crosvm run -s" with socket and then subsequent "crosvm stop"
causes the running VM to be shutdown
BUG= 811749 

Change-Id: I04d9b71b6eeef494eb0ffcd86c7bc71a86730a19
Reviewed-on: https://chromium-review.googlesource.com/951981
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Robert Bradford <robert.bradford@intel.com>
Reviewed-by: Sonny Rao <sonnyrao@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/6c7ca93e28bb2a9cef146ef7cd001930cb63c367/src/linux.rs

Sign in to add a comment