New issue
Advanced search Search tips

Issue 811718 link

Starred by 1 user
Status: Fixed
Owner:
vapier@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

hterm: DECALN doesn't set cursor to home position

Reported by judo...@gmail.com, Feb 13 2018 
What steps will reproduce the problem?

$ printf "hello\e#8world"


What is the expected result?

DECALN should fill the screen with a screen alignment pattern *and* move the cursor to the home position. Thus the terminal should be filled with E and "world" should be printed at position column=0.


What happens instead?

"world" is printed at column=5.

Comment 1 by vapier@chromium.org, Feb 13 2018

Summary: hterm: DECALN doesn't set cursor to home position (was: DECALN doesn't set cursor to home position)
thanks for the short example & explanation.  these are much easier to debug.

i haven't looked at the code, but i'd believe they don't work entirely correctly.  for these debugging sequences, we basically did as much as some of the ncurses test apps wanted and that was it.

Comment 2 by vapier@chromium.org, Jun 18 2018

Owner: vapier@chromium.org
Status: Fixed (was: Unconfirmed)
this is fixed in hterm-1.79+ and nassh-0.8.44+
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/362373a969a93f314591a83dd09907092d9b37fe

commit 362373a969a93f314591a83dd09907092d9b37fe
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Jun 18 19:09:13 2018

hterm: DECALN: fix cursor position

The docs and xterm implementation move the cursor to 0,0 when running
DECALN, but hterm hasn't.  Update our implementation to match.

Bug:  811718 
Url: https://vt100.net/docs/vt510-rm/DECALN.html
Change-Id: I5afb8271923f59ea8a0a886fc1e25c2f565568f1
Reviewed-on: https://chromium-review.googlesource.com/1103772
Reviewed-by: Vitaliy Shipitsyn <vsh@google.com>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/362373a969a93f314591a83dd09907092d9b37fe/hterm/doc/ControlSequences.md
[modify] https://crrev.com/362373a969a93f314591a83dd09907092d9b37fe/hterm/js/hterm_vt.js
►

Sign in to add a comment