New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 811699 link

Starred by 2 users
Status: Fixed
Owner:
weidongg@chromium.org
Closed: Feb 2018
Cc:
omrilio@chromium.org
ajha@chromium.org
█ brajkumar@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Chopped 'Unnamed Folder' text is seen on clicking Folder where one App is available in it at App Launcher

Project Member Reported by mmanchala@chromium.org, Feb 13 2018 
Chrome Version:  66.0.3344.0//10399.0.0 dev-channel  Peppy,Candy and Paine
OS: Chrome

What steps will reproduce the problem?
(1)Sign in to chrome -> Open App launcher
(2)Now click on Folder where only one App is available
and observe 'Unnamed Folder' text is seen chopped
(Please refer Screenshot)

Expected: Chopped 'Unnamed Folder' text should not be seen
Actual: Instead Chopped 'Unnamed Folder' text is seen

This is Regression issue as same is working fine in 66.0.3327.0/10330.0.0 dev-channel Peppy

@omrilio: Please confirm the Issue

Note : Issue is working fine in M-63, M-64, M-65
Actual_Name.jpg
89.5 KB View Download

Comment 1 by mmanchala@chromium.org, Feb 13 2018 

Issue is working fine in 66.0.3329.0/10335.0.0 dev-channel Peppy device
Attaching video and Screenshot for reference
Expected_Name.webm
1.8 MB View Download
Expected_Name.jpg
129 KB View Download

Comment 2 by newcomer@chromium.org, Feb 13 2018

Cc: omrilio@chromium.org
Owner: weidongg@chromium.org

Comment 3 by weidongg@chromium.org, Feb 14 2018 

I think the folder containing one single item is not supported currently?

Comment 4 by omrilio@chromium.org, Feb 14 2018 

Yep - folder with one item is not supported

Comment 5 by mmanchala@chromium.org, Feb 14 2018

Labels: Inhouse-HYD-Reported
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b62c95dd0ffd1a36b823fc938a294f72ef048fc2

commit b62c95dd0ffd1a36b823fc938a294f72ef048fc2
Author: Weidong Guo <weidongg@chromium.org>
Date: Thu Feb 15 00:00:17 2018

Fix folder placeholder text issue

Change:
Use the maximum of folder name's width and grid view's width as the
width of the folder.

Bug:  811699 
Change-Id: Iaa456ea4a2d19585918e4184d625793862463ea2
Reviewed-on: https://chromium-review.googlesource.com/919431
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536896}
[modify] https://crrev.com/b62c95dd0ffd1a36b823fc938a294f72ef048fc2/ui/app_list/views/app_list_folder_view.cc

Comment 7 by weidongg@chromium.org, Feb 15 2018

Status: Fixed (was: Assigned)
Although this is not a supported situation, some users may get single-app folder somehow (not sure why, is this supported in old launcher?). I landed a fix for this.
►

Sign in to add a comment