New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 811687 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Add support for device source to media device enumerations on Mac

Project Member Reported by guidou@chromium.org, Feb 13 2018

Issue description

Currently enumerateDevices reports only the device name (e.g., Built-in device), but not the source (External Speaker/Headphone).

Also, the devicechange event is not fired when the source changes (since the device name does not change).

Having this information is relevant for some applications.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed22b40df6edc440bc791b7e3a104abb56335827

commit ed22b40df6edc440bc791b7e3a104abb56335827
Author: Guido Urdaneta <guidou@chromium.org>
Date: Tue Apr 03 10:23:45 2018

Use device sources as label in audio device enumerations on Mac

On Mac, audio devices may have an active source.
For example, the built-in audio device might be using the internal
speakers or headphones (same device, different sources).
This CL changes audio device enumerations so that the device label
uses the source instead of the device name if the source is available.

The reason is that the source (together with the transport, added in
crrev.com/c/980951) is a better description of the device.

Some examples:

Before: "Built-in Microphone"
Now: "External Microphone (Built-in)" or "Internal Microphone (Built-in)"

Before: "Built-in Output"
Now: "Internal Speakers (Built-in)" or "Headphones (Built-in)"

Before: "HDMI"
Now: "HP Z30i (HDMI)"

This change also requires firing the devicechange event if the source for
a device changes, since that results in a change to the enumeration results.
This CL includes the required changes to AudioDeviceListenerMac.

Bug:  811687 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ieb6801fe979cfed528036862471203f5d29e4603
Reviewed-on: https://chromium-review.googlesource.com/984312
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547662}
[modify] https://crrev.com/ed22b40df6edc440bc791b7e3a104abb56335827/media/audio/mac/audio_device_listener_mac.cc
[modify] https://crrev.com/ed22b40df6edc440bc791b7e3a104abb56335827/media/audio/mac/audio_device_listener_mac.h
[modify] https://crrev.com/ed22b40df6edc440bc791b7e3a104abb56335827/media/audio/mac/core_audio_util_mac.cc
[modify] https://crrev.com/ed22b40df6edc440bc791b7e3a104abb56335827/media/audio/mac/core_audio_util_mac.h
[modify] https://crrev.com/ed22b40df6edc440bc791b7e3a104abb56335827/media/device_monitors/device_monitor_mac.mm

Status: Fixed (was: Assigned)

Sign in to add a comment