Update git client to 2.16.2 everywhere |
|||||||||
Issue descriptiongit 2.16 has some performance improvement. https://github.com/git/git/blob/master/Documentation/RelNotes/2.16.0.txt#L152 git 2.16 includes the linux version of performance fix for slow fetch happened in 749709 So I expect updated git will improve the time of bot_update step a minutes or so on non-windows bot.
,
Feb 14 2018
There is work on v2 protocol both in Git at Google and in git client. Is this related, or orthogonal to change to linux perf improvement?
,
Feb 14 2018
I did not know about v2 protocol. git 2.16.1 includes the fix for too many stating to file system causing slow `git fetch`, https://github.com/git/git/commit/c291293b2ecec8ca77dfd218fa820dd7a0137a2b I found in https://bugs.chromium.org/p/chromium/issues/detail?id=749709#c54 and you fixed. git is optimized for Linux, but limited IOPS on GCE makes it not good as on bare metal server. I think this is the main reason of performance difference on bot_update step in linux and windows tryserver. http://shortn/_pzUBrhL2HW
,
Feb 14 2018
Great, I was planning to do this to get new git-interpret-trailers features too. https://chromium-review.googlesource.com/#/c/chromium/tools/depot_tools/+/919530 https://chromium-review.googlesource.com/#/c/chromium/tools/build/+/919551
,
Feb 14 2018
,
Feb 27 2018
,
Feb 27 2018
So, this is currently blocked on issue 794657 because https://chrome-internal-review.googlesource.com/c/infradata/config/+/570638 wants to deploy diff versions of git to diff platform. Now, Vadim says that git 2.16.2 is available for all platforms, and hence we can deploy it given today's swarming support in swarming. I propose to deploy 2.16.2 everywhere. What do others think?
,
Feb 27 2018
,
Feb 27 2018
update: so, turns out with 2.16.2 we got lucky because github's windows git didn't hvae to be patched, so the version number is the same for all platform, and so we can go ahead and deploy 2.16.2 instead.
,
Feb 27 2018
Aaron, how does that sound? If it sounds all right, I'd like to give the 2.16.2 deployment a go to familiarize myself with the process.
,
Feb 27 2018
That's... horrifying and terrible, but yeah, since we've gotten lucky with 2.16.2, let's go ahead and deploy it. I already have CLs out for canarying/staging 2.16.1: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/919530 https://chromium-review.googlesource.com/c/chromium/tools/build/+/919551 https://chrome-internal-review.googlesource.com/c/infradata/config/+/570638 I'll go ahead and update and land these since they're ready, and then you can do the corresponding CLs for prod versions.
,
Feb 27 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/c10d42b2f6d11826cbfc1027731abfb9a0bf2a0a commit c10d42b2f6d11826cbfc1027731abfb9a0bf2a0a Author: Aaron Gable <agable@chromium.org> Date: Tue Feb 27 16:53:26 2018
,
Feb 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/608f0b7aad11c466b10404e34f2f62f436d5a126 commit 608f0b7aad11c466b10404e34f2f62f436d5a126 Author: Aaron Gable <agable@chromium.org> Date: Tue Feb 27 16:58:13 2018 Update cipd bootstrap staging git to 2.16.2 Bug: 811681 Change-Id: Icca0ef0cb629547c35ee86b2b9648ed80f0fc5c7 Reviewed-on: https://chromium-review.googlesource.com/919551 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/608f0b7aad11c466b10404e34f2f62f436d5a126/scripts/slave/cipd_bootstrap_v2.py
,
Feb 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/53a62911658d6c4f830f4d5ead14134def4dffe5 commit 53a62911658d6c4f830f4d5ead14134def4dffe5 Author: Aaron Gable <agable@chromium.org> Date: Tue Feb 27 16:59:57 2018 Update windows bleeding-edge git to 2.16.2 Bug: 811681 Change-Id: Id7b276274ba6e2e52fba9a19e6c15d5fd972c178 Reviewed-on: https://chromium-review.googlesource.com/919530 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/53a62911658d6c4f830f4d5ead14134def4dffe5/bootstrap/win/manifest_bleeding_edge.txt
,
Feb 27 2018
Go ahead and do the updates for prod whenever you're confident that these are stable!
,
Feb 27 2018
Thanks! Looks like the canary builds are all picking up the new Git version and chugging along nicely, so I'll go ahead with the prod updates. https://chrome-internal-review.googlesource.com/c/infradata/config/+/578577 https://chromium-review.googlesource.com/c/chromium/tools/build/+/939988 https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/939991
,
Feb 27 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/dc0366a5cce1c2d4445aae61d5bda565e804a61c commit dc0366a5cce1c2d4445aae61d5bda565e804a61c Author: Jao-ke Chin-Lee <jchinlee@google.com> Date: Tue Feb 27 20:48:06 2018
,
Feb 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/6a2e902ebe9fbbcf408a1fb1daf1194ce440749f commit 6a2e902ebe9fbbcf408a1fb1daf1194ce440749f Author: Jao-ke Chin-Lee <jchinlee@chromium.org> Date: Tue Feb 27 20:53:05 2018 Update cipd bootstrap prod git to 2.16.2 Bug: 811681 Change-Id: I1e8bb05830661664ce4b0281124fb8d1c040ebe7 Reviewed-on: https://chromium-review.googlesource.com/939988 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> [modify] https://crrev.com/6a2e902ebe9fbbcf408a1fb1daf1194ce440749f/scripts/slave/cipd_bootstrap_v2.py
,
Feb 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/9cb8fad0b34953487754468c1f04eb9d3cc197a9 commit 9cb8fad0b34953487754468c1f04eb9d3cc197a9 Author: Jao-ke Chin-Lee <jchinlee@chromium.org> Date: Tue Feb 27 22:57:55 2018 Update windows git to 2.16.2 Bug: 811681 Change-Id: I2ef7238baececcf87643cba78d72622922ad881c Reviewed-on: https://chromium-review.googlesource.com/939991 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> [modify] https://crrev.com/9cb8fad0b34953487754468c1f04eb9d3cc197a9/bootstrap/win/manifest.txt
,
Feb 28 2018
Thank you for updating git. Sadaly, I don't see bot_update step time improvement on linux tryserver builder, but bot_update time of windows waterfall builder is improved drastically. With git 2.15.0.windows.1 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%20Builder%20%28dbg%29/1817 5 mins 48 secs https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%20Builder%20%28dbg%29/1819 8 mins 47 secs https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%20Builder%20%28dbg%29/1821 9 mins 22 secs With git 2.16.2.windows.1 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%20Builder%20%28dbg%29/1816 35 secs https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%20Builder%20%28dbg%29/1820 35 secs https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%20Builder%20%28dbg%29/1822 35 secs It become 10x~20x times faster.
,
Mar 1 2018
,
Mar 6 2018
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/15759121361d022b84c2759281e024f94fb2e0d1 commit 15759121361d022b84c2759281e024f94fb2e0d1 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri May 04 18:13:07 2018 Update windows bleeding-edge git to 2.17.0 R=jchinlee@chromium.org Bug: 811681 Change-Id: I0f98bcb3a8006d78a8658e50a6e012171b24b679 Reviewed-on: https://chromium-review.googlesource.com/1043491 Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/15759121361d022b84c2759281e024f94fb2e0d1/bootstrap/win/manifest_bleeding_edge.txt
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0902fd02ee07e0f75e172109ab580742167ec94d commit 0902fd02ee07e0f75e172109ab580742167ec94d Author: depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri May 04 19:45:14 2018 Roll src/third_party/depot_tools/ 848c86e3e..157591213 (1 commit) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/848c86e3e858..15759121361d $ git log 848c86e3e..157591213 --date=short --no-merges --format='%ad %ae %s' 2018-05-03 tandrii Update windows bleeding-edge git to 2.17.0 Created with: roll-dep src/third_party/depot_tools BUG= chromium:811681 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I316a0f743f65642a2c299797055256ab9f9f5dd5 Reviewed-on: https://chromium-review.googlesource.com/1044544 Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556157} [modify] https://crrev.com/0902fd02ee07e0f75e172109ab580742167ec94d/DEPS
,
May 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/6f3c1c82d48ba8c9cee1d15d1406f47973aa88fa commit 6f3c1c82d48ba8c9cee1d15d1406f47973aa88fa Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Mon May 07 17:58:06 2018 Update windows git to 2.17.0 R=jchinlee@chromium.org Bug: 811681 Change-Id: Ic09fe7c90690a26f35e71f6313d17097de7553e9 Reviewed-on: https://chromium-review.googlesource.com/1044661 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org> [modify] https://crrev.com/6f3c1c82d48ba8c9cee1d15d1406f47973aa88fa/recipes/trigger_recipe_roller.txt [modify] https://crrev.com/6f3c1c82d48ba8c9cee1d15d1406f47973aa88fa/bootstrap/win/manifest.txt
,
May 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35b27fe1e6324ef894165b346d3256c9b12c29b7 commit 35b27fe1e6324ef894165b346d3256c9b12c29b7 Author: depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Mon May 07 21:50:57 2018 Roll src/third_party/depot_tools/ 5e5f2d603..5ae86d202 (2 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5e5f2d60353b..5ae86d202127 $ git log 5e5f2d603..5ae86d202 --date=short --no-merges --format='%ad %ae %s' 2018-04-26 jbroman Update canned PRESUBMIT checks to report that TBR does not apply to OWNERS. 2018-05-07 tandrii Update windows git to 2.17.0 Created with: roll-dep src/third_party/depot_tools BUG= chromium:811681 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Id8f55746eacc756b3f167e503a9e62482a2a7ebd Reviewed-on: https://chromium-review.googlesource.com/1048183 Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556578} [modify] https://crrev.com/35b27fe1e6324ef894165b346d3256c9b12c29b7/DEPS |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by tikuta@chromium.org
, Feb 13 2018