Add bot that ensures that Chromium builds with webrtc_enabled = false |
||||||
Issue descriptionChromium should always build for enable_webrtc = false There is currently no bot for this, so this breaks periodically. Just a linux bot is probably sufficient to start.
,
Mar 13 2018
,
Mar 13 2018
,
Mar 13 2018
Code out for review and I've requested a slave machine. https://chromium-review.googlesource.com/c/chromium/tools/build/+/960124 https://chromium-review.googlesource.com/c/chromium/src/+/960125 Remaining: 1) get slave machine and add to slaves.cfg 2) land chromium-side CL 3) land infra cl 4) restart master
,
Mar 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cedcff7c569387f6dd290224664cb506eb33905 commit 6cedcff7c569387f6dd290224664cb506eb33905 Author: Patrik Höglund <phoglund@chromium.org> Date: Mon Mar 19 12:29:29 2018 Add new builder with enable_webrtc=false. We want Chromium to build with enable_webrtc=false. I will initially add a build bot in chromium.webrtc. Bug: chromium:811678 Change-Id: If3f23a70f0102f5b65bb46e5e91eee3c0b1bbeb2 Reviewed-on: https://chromium-review.googlesource.com/960125 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#544013} [modify] https://crrev.com/6cedcff7c569387f6dd290224664cb506eb33905/testing/buildbot/chromium.webrtc.json [modify] https://crrev.com/6cedcff7c569387f6dd290224664cb506eb33905/testing/buildbot/waterfalls.pyl [modify] https://crrev.com/6cedcff7c569387f6dd290224664cb506eb33905/tools/mb/mb_config.pyl
,
Mar 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/fd5fa8e2141aefe3fd7ace37dabb32ee8b64d646 commit fd5fa8e2141aefe3fd7ace37dabb32ee8b64d646 Author: Patrik Höglund <phoglund@chromium.org> Date: Tue Mar 20 10:37:23 2018 Add builder for enable_webrtc=false. For now, I'm just adding a bot in chromium.webrtc without any corresponding tryslaves. I reckon breakages here will be so rare that sheriffs can just go in and revert when appropriate. Bug: chromium:811678 Change-Id: I66b7cf4f65f783e7edaa52e05bd021e16ad441b8 Reviewed-on: https://chromium-review.googlesource.com/960124 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> [modify] https://crrev.com/fd5fa8e2141aefe3fd7ace37dabb32ee8b64d646/masters/master.chromium.webrtc/master_builders_cfg.py [modify] https://crrev.com/fd5fa8e2141aefe3fd7ace37dabb32ee8b64d646/masters/master.chromium.webrtc/slaves.cfg [modify] https://crrev.com/fd5fa8e2141aefe3fd7ace37dabb32ee8b64d646/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py
,
Mar 20 2018
All right, the bot is up and it works. enable_webrtc=false is broken though. Can somebody get to fixing it?
,
Mar 21 2018
We've decided to get rid of enable_webrtc=false instead.
,
Mar 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/eadc9fa15ca9cf6afcea34836bd45058c2820e8d commit eadc9fa15ca9cf6afcea34836bd45058c2820e8d Author: Patrik Höglund <phoglund@chromium.org> Date: Wed Mar 21 08:59:37 2018 Revert "Add builder for enable_webrtc=false." This reverts commit fd5fa8e2141aefe3fd7ace37dabb32ee8b64d646. Reason for revert: Turns out bot will not be needed. Original change's description: > Add builder for enable_webrtc=false. > > For now, I'm just adding a bot in chromium.webrtc without any > corresponding tryslaves. I reckon breakages here will be so rare that > sheriffs can just go in and revert when appropriate. > > Bug: chromium:811678 > Change-Id: I66b7cf4f65f783e7edaa52e05bd021e16ad441b8 > Reviewed-on: https://chromium-review.googlesource.com/960124 > Commit-Queue: Patrik Höglund <phoglund@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> TBR=phoglund@chromium.org,jbudorick@chromium.org Change-Id: I0cd958f4319ecf0b1eefd1bf6e9066506e690469 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:811678 Reviewed-on: https://chromium-review.googlesource.com/972981 Reviewed-by: Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> [modify] https://crrev.com/eadc9fa15ca9cf6afcea34836bd45058c2820e8d/masters/master.chromium.webrtc/master_builders_cfg.py [modify] https://crrev.com/eadc9fa15ca9cf6afcea34836bd45058c2820e8d/masters/master.chromium.webrtc/slaves.cfg [modify] https://crrev.com/eadc9fa15ca9cf6afcea34836bd45058c2820e8d/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py
,
Mar 21 2018
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3691fbc7bf5198ccd2a68fabdbd6bbc689549e36 commit 3691fbc7bf5198ccd2a68fabdbd6bbc689549e36 Author: Patrik Höglund <phoglund@chromium.org> Date: Fri Mar 23 13:58:47 2018 Revert "Add new builder with enable_webrtc=false." This reverts commit 6cedcff7c569387f6dd290224664cb506eb33905. Reason for revert: Turns out bot will not be needed. Original change's description: > Add new builder with enable_webrtc=false. > > We want Chromium to build with enable_webrtc=false. I will initially > add a build bot in chromium.webrtc. > > Bug: chromium:811678 > Change-Id: If3f23a70f0102f5b65bb46e5e91eee3c0b1bbeb2 > Reviewed-on: https://chromium-review.googlesource.com/960125 > Commit-Queue: Patrik Höglund <phoglund@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544013} TBR=phoglund@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:811678 Change-Id: I4a5321aac59bc2de99487c8036ba2724ef025b54 Reviewed-on: https://chromium-review.googlesource.com/972961 Reviewed-by: Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#545424} [modify] https://crrev.com/3691fbc7bf5198ccd2a68fabdbd6bbc689549e36/testing/buildbot/chromium.webrtc.json [modify] https://crrev.com/3691fbc7bf5198ccd2a68fabdbd6bbc689549e36/testing/buildbot/waterfalls.pyl [modify] https://crrev.com/3691fbc7bf5198ccd2a68fabdbd6bbc689549e36/tools/mb/mb_config.pyl |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jansson@chromium.org
, Mar 1 2018