Issue metadata
Sign in to add a comment
|
Regression : [Mac] ‘Opening PDF in Preview’ message is being shown even after exiting from ‘Preview’ App.
Reported by
avsha...@etouch.net,
Feb 13 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version : 66.0.3345.0 (Official Build) c8ce2d88ee3c73948b2c91cbd9dff78eaf9472f0-refs/heads/master@{#536026} 64-bit OS : Mac(10.12.6, 10.13.1, 10.13.4) Precondition : Sign in to chrome using with valid credentials. What steps will reproduce the problem? 1. Launch chrome, open NTP and hit ‘Cmd + P’ to open PrintPreview. 2. Set destination to ‘Save to Google Drive’ 3. Click on ‘Open PDF in Preview’ link (Preview app opens). 4. Exit from ‘Preview’ application and observe. Actual Result : ‘Opening PDF in Preview’ message is shown even after exiting from ‘Preview’ App. Expected Result : Chrome print preview window should close automatically after clicking on ‘Open PDF in Preview’ link. This is a regression issue broken in ‘M-65’ and providing the bisect using ‘per-revision’ script: Good build : 65.0.3295.0 (Revision : 524285) Bad build : 65.0.3296.0 (Revision : 524554) You are probably looking for a change made after 524492 (known good), but no later than 524493 (first known bad). Change Log URL: https://chromium.googlesource.com/chromium/src/+log/03b79777e8a56ca69cb24849f9053ec8171d147b..f5a5f376dae006f46357175f8d47f3b46b965fd4 Suspect : https://chromium.googlesource.com/chromium/src/+/f5a5f376dae006f46357175f8d47f3b46b965fd4 @rbpotter : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Note : 1. This is Mac OS specific issue. 2. Issue is not reproducible on Windows(7,8,8.1,10) and Linux(14.04 LTS) OS since ‘Open PDF in Preview’ option is not available. 3. Issue is reproducible on Dev #66.0.3343.3 & Beta #65.0.3325.51 build as well.
,
Feb 13 2018
Adding release blocker label for this issue.Please reduce priority or remove if not the case. Thank You!
,
Feb 13 2018
Reporter - I think I might know what is causing this but don't have a Mac so can't reproduce the issue. It would help if you can check the following: 1) Does this happen if the destination is set to a local printer (i.e. not Google Drive, which is a cloud printer)? 2) Does this happen if the destination is "Save as PDF"? Thanks!
,
Feb 13 2018
M65 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Feb 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a99415dbc7a7c13a94905f103324f747f8a2fc0b commit a99415dbc7a7c13a94905f103324f747f8a2fc0b Author: rbpotter <rbpotter@chromium.org> Date: Wed Feb 14 02:17:42 2018 Print Preview: Fix Mac Open in Preview bug If the user starts a print job by clicking open pdf in preview, it should be handled as a print to a local printer even if the currently selected printer is a cloud printer. Bug: 811662 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I92d97843816d375cf02c807356e837cd0cf33f7c Reviewed-on: https://chromium-review.googlesource.com/916721 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#536614} [modify] https://crrev.com/a99415dbc7a7c13a94905f103324f747f8a2fc0b/chrome/browser/resources/print_preview/print_preview.js
,
Feb 14 2018
With response to comment #3 : Rechecked the above issue on Mac(10.12.6, 10.13.1, 10.13.4) machines using latest Canary chrome version : 66.0.3347.0 1. Issue is not reproducible when destination is set to a local printer (i.e. not Google Drive, which is a cloud printer)? 2. Issue is not reproducible when the destination is "Save as PDF". Note : Unable to reproduce the issues when the destination is Google drive(Cloud printer), so it seems to be fixed and working as intended. Kindly refer attached screen cast for reference. Thanks.
,
Feb 14 2018
As it is working as intended on latest Canary-66.0.3347.0 adding TE Verified labels for the same and requesting merge to M65 as it is marked as release block stable for M65. Thanks..!
,
Feb 14 2018
Marking fixed and requesting merge per comment 7.
,
Feb 14 2018
Approving merge to M65 branch 3325 based on comment #7. Please merge ASAP. Thank you.
,
Feb 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98d56b58d0a26b9f89d63485ad4eab5bb6e7349e commit 98d56b58d0a26b9f89d63485ad4eab5bb6e7349e Author: rbpotter <rbpotter@chromium.org> Date: Wed Feb 14 19:19:58 2018 Print Preview: Fix Mac Open in Preview bug (M65) If the user starts a print job by clicking open pdf in preview, it should be handled as a print to a local printer even if the currently selected printer is a cloud printer. Bug: 811662 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I92d97843816d375cf02c807356e837cd0cf33f7c Reviewed-on: https://chromium-review.googlesource.com/916721 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#536614}(cherry picked from commit a99415dbc7a7c13a94905f103324f747f8a2fc0b) TBR: thestig@chromium.org Reviewed-on: https://chromium-review.googlesource.com/919042 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#465} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/98d56b58d0a26b9f89d63485ad4eab5bb6e7349e/chrome/browser/resources/print_preview/print_preview.js
,
Feb 21 2018
Update : Verified above issue in latest Beta #65.0.3325.88 build on Mac(10.12.6, 10.13.1, 10.13.4) OS and the issue is fixed. Kindly review an attached screen-cast. Thank you! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by avsha...@etouch.net
, Feb 13 2018