New issue
Advanced search Search tips

Issue 811619 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 800945



Sign in to add a comment

Add strings for the new wallpaper picker

Project Member Reported by wzang@chromium.org, Feb 13 2018

Issue description

The new wallpaper picker adds a bunch of new strings.
 

Comment 1 by wzang@chromium.org, Feb 13 2018

Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2c437377bbcb1e2808190cf9d2f5af73781e337

commit c2c437377bbcb1e2808190cf9d2f5af73781e337
Author: Wenzhao Zang <wzang@chromium.org>
Date: Fri Feb 16 03:09:54 2018

cros: Add strings for new wallpaper picker

The mock is at: goo.gl/kGgEVr

TBR=cpu@chromium.org

Bug:  811619 
Change-Id: I1b3c773bae64031e47a9e7ab2aee65da9bb0c2f0
Reviewed-on: https://chromium-review.googlesource.com/922399
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537167}
[modify] https://crrev.com/c2c437377bbcb1e2808190cf9d2f5af73781e337/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/c2c437377bbcb1e2808190cf9d2f5af73781e337/chrome/browser/chromeos/extensions/wallpaper_private_api.cc

Comment 3 by wzang@chromium.org, Feb 23 2018

Status: Fixed (was: Started)

Comment 4 by wzang@chromium.org, Mar 2 2018

Status: Started (was: Fixed)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 14 2018

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b46715bc67e210ec472824f68789911a4005323

commit 7b46715bc67e210ec472824f68789911a4005323
Author: Wenzhao Zang <wzang@chromium.org>
Date: Sat Apr 14 02:00:52 2018

cros: Add more strings for new wallpaper picker

These strings are needed for M68.

Spec:
https://drive.google.com/corp/drive/folders/0B_2Uyb2Rhx2ObU5VTFJVWHR2WW8

TBR=cpu@chromium.org

Bug:  811619 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I37f9af3e203984f7dcdeea6eb07b5c22bf6424f0
Reviewed-on: https://chromium-review.googlesource.com/984712
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550856}
[modify] https://crrev.com/7b46715bc67e210ec472824f68789911a4005323/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/7b46715bc67e210ec472824f68789911a4005323/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/7b46715bc67e210ec472824f68789911a4005323/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js
[modify] https://crrev.com/7b46715bc67e210ec472824f68789911a4005323/chrome/browser/resources/chromeos/wallpaper_manager/main.html

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62e5477de85e135ffd3a896f5feea6bce20609a6

commit 62e5477de85e135ffd3a896f5feea6bce20609a6
Author: Wenzhao Zang <wzang@chromium.org>
Date: Fri Jun 01 22:24:14 2018

cros: Add additional strings for new wallpaper picker

Spec:
https://drive.google.com/corp/drive/folders/0B_2Uyb2Rhx2ObU5VTFJVWHR2WW8

TBR=cpu@chromium.org

Bug:  811619 
Change-Id: I4c3e1d3ce93c2c67c6a8c394c30cec9f0f162765
Reviewed-on: https://chromium-review.googlesource.com/1083020
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563833}
[modify] https://crrev.com/62e5477de85e135ffd3a896f5feea6bce20609a6/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/62e5477de85e135ffd3a896f5feea6bce20609a6/chrome/browser/chromeos/extensions/wallpaper_private_api.cc

Comment 8 by wzang@chromium.org, Jun 23 2018

Status: Fixed (was: Started)

Sign in to add a comment