New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 811603 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

ios/web_view is missing string resource for plugin placeholder

Project Member Reported by michaeldo@chromium.org, Feb 13 2018

Issue description

The plugin placeholder (which covers unsupported flash content) exists in //ios/web and //ios/web_view by extension.

However, because string resources are bundled with Chrome, the string is missing. See screenshot for example.

Test URL: http://www.mono-1.com/monoface/main.html
 
web shell.png
167 KB View Download
Chrome.png
159 KB View Download

Comment 1 by jzw@chromium.org, Feb 13 2018

Thanks for verifying Michael.

For reference, safari iOS just shows a blank page.

Comment 2 by jzw@chromium.org, Apr 11 2018

Is this also related to these logs below?

[0411/153122.161864:WARNING:resource_bundle.cc(565)] locale resources are not loaded
[0411/153138.913438:WARNING:resource_bundle.cc(565)] locale resources are not loaded
[0411/153138.913618:WARNING:resource_bundle.cc(565)] locale resources are not loaded
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d56a1315142202005dd8d349876b98590d496bb6

commit d56a1315142202005dd8d349876b98590d496bb6
Author: John Z Wu <jzw@chromium.org>
Date: Tue Apr 24 22:08:53 2018

Bundle component strings in //ios/web_view.

Fixes this warning log:
[0411/153122.161864:WARNING:resource_bundle.cc(565)] locale resources are not loaded

Also shows "This plugin is not supported" when visiting websites with flash content.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I33e7e65dcb8193a93f5208f847a39a20e8472987
Bug:  811603 
Reviewed-on: https://chromium-review.googlesource.com/1024488
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553312}
[modify] https://crrev.com/d56a1315142202005dd8d349876b98590d496bb6/ios/web_view/BUILD.gn
[modify] https://crrev.com/d56a1315142202005dd8d349876b98590d496bb6/ios/web_view/internal/DEPS
[modify] https://crrev.com/d56a1315142202005dd8d349876b98590d496bb6/ios/web_view/internal/web_view_web_client.h
[modify] https://crrev.com/d56a1315142202005dd8d349876b98590d496bb6/ios/web_view/internal/web_view_web_client.mm

Comment 4 by jzw@chromium.org, Apr 25 2018

Status: Fixed (was: Available)

Sign in to add a comment