New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 811575 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Show toast for "Copy link" in Browser Actions menu

Project Member Reported by sbirch@chromium.org, Feb 13 2018

Issue description

Low priority & not blocking but nice to have -- I will defer to +srahim on the text, but Google Search uses e.g. "Link copied to clipboard"
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/custom-tabs-client/+/7884a658507dc99bcb54b328bc29d76e64c3b684

commit 7884a658507dc99bcb54b328bc29d76e64c3b684
Author: Lei Tian <ltian@chromium.org>
Date: Wed Feb 28 22:43:53 2018

Add predefined items to Browser Actions fallback dialog

Add 3 predefined items to the Browser Actions fallback dialog includes:
1. Open in browser
2. Copy link
3. Share link: Android vanila text share, not Chrome customize share.

Also move the icons of custom items to align on the right and for
predefined items, no icon would shown.

Bug:  810971 ,  811575 , 813926
Change-Id: I52ee0dfa9bb808cb5746889b9e10dff9aedcd6b9
Reviewed-on: https://chromium-review.googlesource.com/929593
Commit-Queue: Lei Tian <ltian@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>

[modify] https://crrev.com/7884a658507dc99bcb54b328bc29d76e64c3b684/customtabs/res/values/colors.xml
[modify] https://crrev.com/7884a658507dc99bcb54b328bc29d76e64c3b684/customtabs/src/android/support/customtabs/browseractions/BrowserActionsIntent.java
[modify] https://crrev.com/7884a658507dc99bcb54b328bc29d76e64c3b684/customtabs/src/android/support/customtabs/browseractions/BrowserActionItem.java
[modify] https://crrev.com/7884a658507dc99bcb54b328bc29d76e64c3b684/customtabs/res/layout/browser_actions_context_menu_row.xml
[add] https://crrev.com/7884a658507dc99bcb54b328bc29d76e64c3b684/customtabs/res/values/strings.xml
[modify] https://crrev.com/7884a658507dc99bcb54b328bc29d76e64c3b684/customtabs/tests/src/android/support/customtabs/browseractions/BrowserActionsFallbackMenuUiTest.java
[modify] https://crrev.com/7884a658507dc99bcb54b328bc29d76e64c3b684/customtabs/src/android/support/customtabs/browseractions/BrowserActionsFallbackMenuUi.java
[modify] https://crrev.com/7884a658507dc99bcb54b328bc29d76e64c3b684/customtabs/res/layout/browser_actions_context_menu_page.xml
[modify] https://crrev.com/7884a658507dc99bcb54b328bc29d76e64c3b684/customtabs/res/values/dimens.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4af8c78b3f5483e664ef6bc156e2196ed3d0b83

commit b4af8c78b3f5483e664ef6bc156e2196ed3d0b83
Author: Lei Tian <ltian@chromium.org>
Date: Fri Mar 02 03:59:45 2018

Roll out changes of display predefined items for Browser Actions fallback dialog

Roll out changes of display predefined items for Browser Actions
fallback dialog

Bug:  810971 ,  811575 , 813926
Change-Id: I499f0e14bb2b1c39d362a3f78f53cb5a12df3545
Reviewed-on: https://chromium-review.googlesource.com/942189
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Lei Tian <ltian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540441}
[modify] https://crrev.com/b4af8c78b3f5483e664ef6bc156e2196ed3d0b83/DEPS

Comment 3 by ltian@chromium.org, Mar 2 2018

Status: Fixed (was: Assigned)

Sign in to add a comment