New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 811561 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Update analysis result with flaky tests found by swarming rerun

Project Member Reported by chanli@chromium.org, Feb 13 2018

Issue description

Currently we update analysis result with flaky tests found by try job but not flaky tests found by swarming rerun. 

After this change, we should be able to get all information related to flaky tests within one waterfall test failure in one place.

TriggerFlakeAnalysesPipeline and reporting event for test failures need to be updated after this change.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/bfd05bc748f94fb3600a3fe99e69226b555a76da

commit bfd05bc748f94fb3600a3fe99e69226b555a76da
Author: Chan <chanli@chromium.org>
Date: Wed Feb 14 22:47:46 2018

[Findit] Update WfAnalysis to save flaky test information.

Before we only update WfAnalysis.result to save flaky tests found by try job but not swarming reruns.

This change will also update WfAnalysis.result to save first time flaky tests found by swarming reruns.

Also add a new field flaky_tests in WfAnalysis to explicitely save such information, and also in case there is no WfAnalysis.result when heuristic analysis aborts unexpectedly.

Bug:  811561 
Change-Id: I039fbc33ec8b7670066de8c477291f591a647eea
Reviewed-on: https://chromium-review.googlesource.com/917321
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/bfd05bc748f94fb3600a3fe99e69226b555a76da/appengine/findit/waterfall/test/update_analysis_with_flake_info_pipeline_test.py
[modify] https://crrev.com/bfd05bc748f94fb3600a3fe99e69226b555a76da/appengine/findit/model/test/wf_analysis_test.py
[modify] https://crrev.com/bfd05bc748f94fb3600a3fe99e69226b555a76da/appengine/findit/services/compile_failure/compile_try_job.py
[modify] https://crrev.com/bfd05bc748f94fb3600a3fe99e69226b555a76da/appengine/findit/services/test_failure/test_failure_analysis.py
[modify] https://crrev.com/bfd05bc748f94fb3600a3fe99e69226b555a76da/appengine/findit/waterfall/update_analysis_with_flake_info_pipeline.py
[modify] https://crrev.com/bfd05bc748f94fb3600a3fe99e69226b555a76da/appengine/findit/services/test_failure/test_try_job.py
[modify] https://crrev.com/bfd05bc748f94fb3600a3fe99e69226b555a76da/appengine/findit/waterfall/flake/test/trigger_flake_analyses_pipeline_test.py
[modify] https://crrev.com/bfd05bc748f94fb3600a3fe99e69226b555a76da/appengine/findit/services/test_failure/test/test_try_job_test.py
[modify] https://crrev.com/bfd05bc748f94fb3600a3fe99e69226b555a76da/appengine/findit/waterfall/flake/trigger_flake_analyses_pipeline.py
[modify] https://crrev.com/bfd05bc748f94fb3600a3fe99e69226b555a76da/appengine/findit/services/test_failure/test/test_failure_analysis_test.py
[modify] https://crrev.com/bfd05bc748f94fb3600a3fe99e69226b555a76da/appengine/findit/model/wf_analysis.py

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/30f051f8b63471cb2ed8c3a0c2638d77e69737f8

commit 30f051f8b63471cb2ed8c3a0c2638d77e69737f8
Author: Chan <chanli@chromium.org>
Date: Wed Feb 14 23:05:06 2018

[Findit] Prevent double reporting on flaky test failures on waterfall.

Only report reliable failed test at the end of failure analysis, wait until the end of flake analysis to report flaky tests found by Findit.

Bug:  811561 
Change-Id: Iffa267c7a11b9059ed0f88963e5f69b598b95f1f
Reviewed-on: https://chromium-review.googlesource.com/917421
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>

[modify] https://crrev.com/30f051f8b63471cb2ed8c3a0c2638d77e69737f8/appengine/findit/services/event_reporting.py
[modify] https://crrev.com/30f051f8b63471cb2ed8c3a0c2638d77e69737f8/appengine/findit/services/test/event_reporting_test.py

Comment 3 by chanli@chromium.org, Feb 15 2018

Status: Fixed (was: Assigned)

Sign in to add a comment