New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 811556 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 786204



Sign in to add a comment

Eng tracking for GLIF visual updates for enterprise enrollment flow

Project Member Reported by zalcorn@chromium.org, Feb 13 2018

Issue description

Eng tracking bug for crbug/786204 - GLIF visual updates for enterprise enrollment flow.

General OOBE spec lives at https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZWp9zcCh-kcQ/files/MCFK23fL_7-f7multL6RRSfa

Will be updating shortly with updated spec for Enterprise enrollment screens.
 
Blocking: 786204
Labels: -M-66 M-67

Comment 4 by zalcorn@google.com, Mar 23 2018

Hey folks just checking in on the status here - is there anything you need from me or Elizabeth?
Feature freeze for M67 is Friday March 30, let me know if we should punt to M68.
Thanks!
Labels: -M-67 M-68
Yes, M68 seems more likely
Hey folks, sorry I haven't checked in on this in a while. Is this on track for M68?
Labels: -M-68 M-69
Hey, M69 seems more likely. Sorry :)
Owner: antrim@chromium.org
Cc: rsorokin@chromium.org
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bfd214a0e8af35212b7d51e81690d3b41f619a7

commit 9bfd214a0e8af35212b7d51e81690d3b41f619a7
Author: Denis Kuznetsov <antrim@google.com>
Date: Fri Jun 29 15:02:43 2018

Update Enterprise Enrollment UI

Add "enterprise card", made license selection screen use the card.

Bug: 811556
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ibb8dc59b3232c4a5d9a65b4c79faf57294bec913
Reviewed-on: https://chromium-review.googlesource.com/945994
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571476}
[modify] https://crrev.com/9bfd214a0e8af35212b7d51e81690d3b41f619a7/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/9bfd214a0e8af35212b7d51e81690d3b41f619a7/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc
[modify] https://crrev.com/9bfd214a0e8af35212b7d51e81690d3b41f619a7/chrome/browser/resources/chromeos/login/custom_elements_login.html
[modify] https://crrev.com/9bfd214a0e8af35212b7d51e81690d3b41f619a7/chrome/browser/resources/chromeos/login/custom_elements_login.js
[modify] https://crrev.com/9bfd214a0e8af35212b7d51e81690d3b41f619a7/chrome/browser/resources/chromeos/login/custom_elements_oobe.html
[modify] https://crrev.com/9bfd214a0e8af35212b7d51e81690d3b41f619a7/chrome/browser/resources/chromeos/login/custom_elements_oobe.js
[modify] https://crrev.com/9bfd214a0e8af35212b7d51e81690d3b41f619a7/chrome/browser/resources/chromeos/login/enrollment_license_card.css
[modify] https://crrev.com/9bfd214a0e8af35212b7d51e81690d3b41f619a7/chrome/browser/resources/chromeos/login/enrollment_license_card.html
[add] https://crrev.com/9bfd214a0e8af35212b7d51e81690d3b41f619a7/chrome/browser/resources/chromeos/login/enterprise_card.css
[add] https://crrev.com/9bfd214a0e8af35212b7d51e81690d3b41f619a7/chrome/browser/resources/chromeos/login/enterprise_card.html
[add] https://crrev.com/9bfd214a0e8af35212b7d51e81690d3b41f619a7/chrome/browser/resources/chromeos/login/enterprise_card.js
[add] https://crrev.com/9bfd214a0e8af35212b7d51e81690d3b41f619a7/chrome/browser/resources/chromeos/login/enterprise_card_footer.css
[add] https://crrev.com/9bfd214a0e8af35212b7d51e81690d3b41f619a7/chrome/browser/resources/chromeos/login/enterprise_header.css
[add] https://crrev.com/9bfd214a0e8af35212b7d51e81690d3b41f619a7/chrome/browser/resources/chromeos/login/enterprise_header.html
[add] https://crrev.com/9bfd214a0e8af35212b7d51e81690d3b41f619a7/chrome/browser/resources/chromeos/login/enterprise_header.js
[add] https://crrev.com/9bfd214a0e8af35212b7d51e81690d3b41f619a7/chrome/browser/resources/chromeos/login/images/enrollment_success_illustration_1x.png
[add] https://crrev.com/9bfd214a0e8af35212b7d51e81690d3b41f619a7/chrome/browser/resources/chromeos/login/images/enrollment_success_illustration_2x.png
[modify] https://crrev.com/9bfd214a0e8af35212b7d51e81690d3b41f619a7/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.css
[modify] https://crrev.com/9bfd214a0e8af35212b7d51e81690d3b41f619a7/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.html
[modify] https://crrev.com/9bfd214a0e8af35212b7d51e81690d3b41f619a7/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js
[modify] https://crrev.com/9bfd214a0e8af35212b7d51e81690d3b41f619a7/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc

Is the eng work on the feature finished?

Then please, close the issue and file a test review per https://crbug.com/786204#c38
Status: Started (was: Assigned)
There is a cl in review with small bugfix: https://chromium-review.googlesource.com/c/chromium/src/+/1122875
Active Directory screens are not migrated yet
EE must follow OOBE behavior and style:
1) white background if UI is in full-screen mode.
2) No shadows
3) Different buttons margins depending on whether UI is full-screen or not. See https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZcWxQVKsUFtK/files/MCGJEufWNx2OfnhmVzPdBozCwMSJbxAVNpw


I'd definitely advise migrating to oobe-dialog and Polymer infrastructure in general ASAP.
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fa1504e0561c97d2feeabac40eec4d1faa1e9b2

commit 3fa1504e0561c97d2feeabac40eec4d1faa1e9b2
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Wed Sep 12 15:59:48 2018

Cros: Remove shadow from enterprise-card

BUG=chromium:811556
TEST=manual

Change-Id: I1df22982da64bd19314b0c107a8342d4e9455169
Reviewed-on: https://chromium-review.googlesource.com/1221728
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590702}
[modify] https://crrev.com/3fa1504e0561c97d2feeabac40eec4d1faa1e9b2/chrome/browser/resources/chromeos/login/enterprise_card.css

Labels: Merge-Request-70
Requesting merge for CL in #c15.
One line change to css file. Removes shadow from enterprise dialog.
Project Member

Comment 17 by sheriffbot@chromium.org, Sep 13

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 32 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Just to note, requested merge only refers to change in #15 (single CSS file)
Project Member

Comment 19 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8607f136466985f8ac67165c2ad1cbc9316135d4

commit 8607f136466985f8ac67165c2ad1cbc9316135d4
Author: Denis Kuznetsov <antrim@google.com>
Date: Fri Sep 14 14:53:35 2018

Migrate OOBE Enrollment to polymer

Get rid of enterprise-card / enterprise-header, switch existing screens
to oobe-dialog.

This cl simplify existing code before migrating enrollment flow to polymer
completely.

Bug: 811556
Change-Id: I5035707ba57c4281a293a616225a8171a8e552dc
Reviewed-on: https://chromium-review.googlesource.com/1225698
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591343}
[modify] https://crrev.com/8607f136466985f8ac67165c2ad1cbc9316135d4/chrome/browser/resources/chromeos/login/custom_elements_login.html
[modify] https://crrev.com/8607f136466985f8ac67165c2ad1cbc9316135d4/chrome/browser/resources/chromeos/login/custom_elements_login.js
[modify] https://crrev.com/8607f136466985f8ac67165c2ad1cbc9316135d4/chrome/browser/resources/chromeos/login/custom_elements_oobe.html
[modify] https://crrev.com/8607f136466985f8ac67165c2ad1cbc9316135d4/chrome/browser/resources/chromeos/login/custom_elements_oobe.js
[modify] https://crrev.com/8607f136466985f8ac67165c2ad1cbc9316135d4/chrome/browser/resources/chromeos/login/enrollment_license_card.html
[modify] https://crrev.com/8607f136466985f8ac67165c2ad1cbc9316135d4/chrome/browser/resources/chromeos/login/enrollment_license_card.js
[delete] https://crrev.com/8d71f6f577d973c04ed02cf8779643a6b874ac50/chrome/browser/resources/chromeos/login/enterprise_card.css
[delete] https://crrev.com/8d71f6f577d973c04ed02cf8779643a6b874ac50/chrome/browser/resources/chromeos/login/enterprise_card.html
[delete] https://crrev.com/8d71f6f577d973c04ed02cf8779643a6b874ac50/chrome/browser/resources/chromeos/login/enterprise_card.js
[delete] https://crrev.com/8d71f6f577d973c04ed02cf8779643a6b874ac50/chrome/browser/resources/chromeos/login/enterprise_header.css
[delete] https://crrev.com/8d71f6f577d973c04ed02cf8779643a6b874ac50/chrome/browser/resources/chromeos/login/enterprise_header.js
[modify] https://crrev.com/8607f136466985f8ac67165c2ad1cbc9316135d4/chrome/browser/resources/chromeos/login/oobe_dialog.css
[modify] https://crrev.com/8607f136466985f8ac67165c2ad1cbc9316135d4/chrome/browser/resources/chromeos/login/oobe_dialog.html
[rename] https://crrev.com/8607f136466985f8ac67165c2ad1cbc9316135d4/chrome/browser/resources/chromeos/login/oobe_enrollment.html
[modify] https://crrev.com/8607f136466985f8ac67165c2ad1cbc9316135d4/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.css
[modify] https://crrev.com/8607f136466985f8ac67165c2ad1cbc9316135d4/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.html
[modify] https://crrev.com/8607f136466985f8ac67165c2ad1cbc9316135d4/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js
[modify] https://crrev.com/8607f136466985f8ac67165c2ad1cbc9316135d4/chrome/browser/resources/chromeos/login/oobe_update.css
[modify] https://crrev.com/8607f136466985f8ac67165c2ad1cbc9316135d4/chrome/browser/resources/chromeos/login/oobe_update.html

Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 21 by bugdroid1@chromium.org, Sep 25

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efdd50049bb79b6773058e76c21ab9bd85320f78

commit efdd50049bb79b6773058e76c21ab9bd85320f78
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Tue Sep 25 07:17:58 2018

Cros: Remove shadow from enterprise-card

BUG=chromium:811556
TEST=manual

Change-Id: I1df22982da64bd19314b0c107a8342d4e9455169
Reviewed-on: https://chromium-review.googlesource.com/1221728
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#590702}(cherry picked from commit 3fa1504e0561c97d2feeabac40eec4d1faa1e9b2)
Reviewed-on: https://chromium-review.googlesource.com/1242458
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#646}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/efdd50049bb79b6773058e76c21ab9bd85320f78/chrome/browser/resources/chromeos/login/enterprise_card.css

Project Member

Comment 22 by bugdroid1@chromium.org, Nov 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8af3013023099c09a9f579d9ce1dbb7b62dc3692

commit 8af3013023099c09a9f579d9ce1dbb7b62dc3692
Author: Denis Kuznetsov <antrim@google.com>
Date: Thu Nov 22 22:18:40 2018

Fix enrollment screen for attestation-based enrollment.

Remove separate ABE success screen.
Replace success text with dedicated polymer element.

TBR: alemate@chromium.org
Bug: 811556
Change-Id: Id26aae8ec6276d57148cbb2a101094f93d28e11c
Reviewed-on: https://chromium-review.googlesource.com/c/1329630
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610496}
[modify] https://crrev.com/8af3013023099c09a9f579d9ce1dbb7b62dc3692/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/8af3013023099c09a9f579d9ce1dbb7b62dc3692/chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc
[modify] https://crrev.com/8af3013023099c09a9f579d9ce1dbb7b62dc3692/chrome/browser/resources/chromeos/login/custom_elements_login.js
[modify] https://crrev.com/8af3013023099c09a9f579d9ce1dbb7b62dc3692/chrome/browser/resources/chromeos/login/custom_elements_oobe.js
[modify] https://crrev.com/8af3013023099c09a9f579d9ce1dbb7b62dc3692/chrome/browser/resources/chromeos/login/oobe_enrollment.html
[add] https://crrev.com/8af3013023099c09a9f579d9ce1dbb7b62dc3692/chrome/browser/resources/chromeos/login/oobe_enrollment.js
[modify] https://crrev.com/8af3013023099c09a9f579d9ce1dbb7b62dc3692/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.css
[modify] https://crrev.com/8af3013023099c09a9f579d9ce1dbb7b62dc3692/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.html
[modify] https://crrev.com/8af3013023099c09a9f579d9ce1dbb7b62dc3692/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js
[modify] https://crrev.com/8af3013023099c09a9f579d9ce1dbb7b62dc3692/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc

Sign in to add a comment