[desktop-pwas] 3-dot menu should have a tooltip. Also an accessible name. |
|||||
Issue descriptionChrome Version : 64.0.3282.140 What steps will reproduce the problem? 1. chrome://flags#enable-desktop-pwas 2. Chrome menu -> Add to shelf, open 3. Hover over 3-dot menu What is the expected result? A tooltip. Chrome's says "Customise and control Google Chrome". What happens instead of that? No tooltip.
,
Feb 13 2018
+srahim for advice (here're screenshots for context https://screenshot.googleplex.com/cUnYCWZ4uOg.png, https://screenshot.googleplex.com/92DQyzJ4Nj2.png) Ideas: - Customize and control this app - Customize and control your app
,
Feb 14 2018
,
Feb 14 2018
aleventhal@ from Accessibility has kindly put up a CL for this. (I believe coincidentally.) https://chromium-review.googlesource.com/c/chromium/src/+/920263 The string he's going with is "Customize and control $APP_NAME" which makes sense (given that the Chrome menu is "Customize and control Google Chrome"). I'm not sure what the accessible name should be.
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa432364df013ac6393017c52dde963fb2e1fd4e commit aa432364df013ac6393017c52dde963fb2e1fd4e Author: Aaron Leventhal <aleventhal@chromium.org> Date: Wed Feb 28 02:09:01 2018 Hosted app button name Follows the pattern used for the Chrome 3-dot app menu. Bug: 811555 Change-Id: I601a6225a98751657c83dd5d8dcf92b9200fecca Reviewed-on: https://chromium-review.googlesource.com/920263 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Matt Giuca <mgiuca@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#539655} [modify] https://crrev.com/aa432364df013ac6393017c52dde963fb2e1fd4e/chrome/app/generated_resources.grd [modify] https://crrev.com/aa432364df013ac6393017c52dde963fb2e1fd4e/chrome/browser/ui/views/frame/hosted_app_button_container.cc
,
Feb 28 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by alancutter@chromium.org
, Feb 13 2018Status: Assigned (was: Unconfirmed)