New issue
Advanced search Search tips

Issue 811548 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

HiDPI: URL drag image when dragging ominbox padlock is not scaled down

Project Member Reported by tapted@chromium.org, Feb 13 2018

Issue description

Chrome Version       : 64.0.3282.134
OS Version: 10176.65.0

What steps will reproduce the problem?
1. On a HiDPI device (E.g. Chromebook pixel), drag the padlock in the omnibox.

What is the expected result?

Complete image when dragging


What happens instead of that?

Image is scaled 2x and clipped


UserAgentString: Mozilla/5.0 (X11; CrOS x86_64 10176.65.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.134 Safari/537.36



 
Screenshot 2018-02-13 at 11.34.25.png
352 KB View Download

Comment 1 by ovanieva@google.com, Feb 13 2018

Owner: malaykeshav@chromium.org
Status: Assigned (was: Unconfirmed)
malaykeshav@ please triage
Status: Started (was: Assigned)
Cc: osh...@chromium.org
This effects every drag and drop with an image and/or text.
Patch under review.
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/851d5768a96cb47068f68e05bd4b13454325b8d2

commit 851d5768a96cb47068f68e05bd4b13454325b8d2
Author: Malay Keshav <malaykeshav@chromium.org>
Date: Wed Feb 14 21:55:23 2018

Bug fix to remove canvas scale when pixel canvas is enabled

The canvas is already scaled and set to the correct size when pixel
canvas is enabled.

Bug:  811548 
Change-Id: Iec2b0656ed26c49af783317cc3e0abfcc0780e29
Component: Canvas painter, Pixel Canvas, Scaling, HiDPI
Reviewed-on: https://chromium-review.googlesource.com/916529
Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536834}
[modify] https://crrev.com/851d5768a96cb47068f68e05bd4b13454325b8d2/ui/compositor/BUILD.gn
[modify] https://crrev.com/851d5768a96cb47068f68e05bd4b13454325b8d2/ui/compositor/canvas_painter.cc
[modify] https://crrev.com/851d5768a96cb47068f68e05bd4b13454325b8d2/ui/compositor/canvas_painter.h
[add] https://crrev.com/851d5768a96cb47068f68e05bd4b13454325b8d2/ui/compositor/canvas_painter_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment