New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 811543 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Long OOO (go/where-is-mgiuca)
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Task



Sign in to add a comment

Remove special RTL exception on Windows that was a work-around for Windows XP issues

Project Member Reported by mgiuca@chromium.org, Feb 13 2018

Issue description

See comment on AdjustStringForLocaleDirection:
https://cs.chromium.org/chromium/src/base/i18n/rtl.h?l=105

> TODO(idana)  bug 6806 : this function adjusts the string in question only
> if the current locale is right-to-left. The function does not take care of
> the opposite case (an RTL string displayed in an LTR context) since
> adjusting the string involves inserting Unicode formatting characters that
> Windows does not handle well unless right-to-left language support is
> installed. Since the English version of Windows doesn't have right-to-left
> language support installed by default, inserting the direction Unicode mark
> results in Windows displaying squares.

This was referring to Windows XP. Now that we no longer support XP, we should be able to remove this exception, and generally improve RTL support.

See this code review comment:

https://chromium-review.googlesource.com/c/chromium/src/+/876522/5/base/i18n/rtl.h

> However, I think we don't have to worry about this any more because we don't
> support Windows XP any more and I believe Windows 7 or later does come with
> RTL/BiDi support out of the box regardless of the UI language of the OS. 
>
> We need a bit of testing, though.
 
Labels: Hotlist-DesktopUIToolingRequired Hotlist-DesktopUIChecked
Cc: -mgiuca@chromium.org js...@chromium.org
Owner: mgiuca@chromium.org
jshin is no longer on the team. Since nobody else seems to be an owner in i18n, I'll assign myself but there's a VERY low probability of me getting to this. If anyone wants to take it, feel free.

Sign in to add a comment