New issue
Advanced search Search tips

Issue 811536 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

In component updater, change const scoped_refcounted<T>& to scoped_refcounted<T>

Project Member Reported by sorin@chromium.org, Feb 13 2018

Issue description

The former expression is legacy code before move semantics were accepted in the code base.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49126334a1bbe7b60bbade2b4875d07277f83446

commit 49126334a1bbe7b60bbade2b4875d07277f83446
Author: Sorin Jianu <sorin@chromium.org>
Date: Tue Feb 13 17:07:42 2018

In component updater, change const scoped_refcounted<T>& to scoped_refcounted<T>

Bug:  811536 
Change-Id: If59a6cdb323df42d5e67753de7e012c1438a39c1
Reviewed-on: https://chromium-review.googlesource.com/914968
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536394}
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/chrome/browser/component_updater/optimization_hints_component_installer_unittest.cc
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/chrome/browser/component_updater/supervised_user_whitelist_installer.cc
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/components/component_updater/component_installer.cc
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/components/component_updater/component_installer.h
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/components/component_updater/component_updater_service.cc
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/components/component_updater/component_updater_service.h
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/components/component_updater/component_updater_service_internal.h
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/components/component_updater/component_updater_service_unittest.cc
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/components/update_client/component.cc
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/components/update_client/component_patcher_operation.cc
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/components/update_client/component_patcher_operation.h
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/components/update_client/component_unpacker.cc
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/components/update_client/component_unpacker.h
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/components/update_client/ping_manager.cc
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/components/update_client/ping_manager.h
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/components/update_client/request_sender.cc
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/components/update_client/request_sender.h
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/components/update_client/update_checker.cc
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/components/update_client/update_checker.h
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/components/update_client/update_client.cc
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/components/update_client/update_client.h
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/components/update_client/update_client_internal.h
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/components/update_client/update_client_unittest.cc
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/components/update_client/update_engine.cc
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/components/update_client/update_engine.h
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/components/update_client/url_request_post_interceptor.cc
[modify] https://crrev.com/49126334a1bbe7b60bbade2b4875d07277f83446/components/update_client/url_request_post_interceptor.h

Comment 2 by sorin@chromium.org, Feb 13 2018

Status: Fixed (was: Started)

Sign in to add a comment