New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 811523 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 811524
issue 784223

Blocking:
issue 644851



Sign in to add a comment

Improve SkiaRenderer DrawFrame performance

Project Member Reported by weiliangc@chromium.org, Feb 12 2018

Issue description

Meta bug for improving SkiaRenderer's draw frame performance. This should be the CPU time used during call of draw frame.
 
Blockedon: 811524
Components: Internals>Compositing
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9adcaaa25d78c548386d17427fb5cb03e420457e

commit 9adcaaa25d78c548386d17427fb5cb03e420457e
Author: Brian Salomon <bsalomon@google.com>
Date: Wed Oct 03 21:10:31 2018

Don't use SkBlendMode::kSrc when quads are opaque in SkiaRenderer.

If quads are antialiased this can trigger shader blending.

Also Skia has optimized code paths for textures drawn src-over.

Bug: 811523
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I9f0405d7651464aeb761c02f5d16f4de29dbbd75
Reviewed-on: https://chromium-review.googlesource.com/c/1259543
Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Cr-Commit-Position: refs/heads/master@{#596363}
[modify] https://crrev.com/9adcaaa25d78c548386d17427fb5cb03e420457e/components/viz/service/display/skia_renderer.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/980cf77f69d8e17347c91b4edfe33faac6c5a833

commit 980cf77f69d8e17347c91b4edfe33faac6c5a833
Author: Brian Salomon <bsalomon@google.com>
Date: Thu Nov 29 21:40:19 2018

Reduce the number of drawImageSet calls in SkiaRenderer.

We now will group tile quads with different SharedQuadStates.

This is done by using per-image alpha in experimental_drawImageSetV1 and
by applying the matrix and scissor to the rendered rectangles when the
transform is positive scale and translate.

Bug: 811523
Change-Id: If9f5f7fe045b7e0170159a90c1694e664a569ae8
Reviewed-on: https://chromium-review.googlesource.com/c/1352669
Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Cr-Commit-Position: refs/heads/master@{#612373}
[modify] https://crrev.com/980cf77f69d8e17347c91b4edfe33faac6c5a833/components/viz/service/display/skia_renderer.cc
[modify] https://crrev.com/980cf77f69d8e17347c91b4edfe33faac6c5a833/components/viz/service/display/skia_renderer.h

Sign in to add a comment