New issue
Advanced search Search tips

Issue 811519 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 3
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

blink_perf.owp_storage/blob-build-all-then-read-parallel-files.html and 1 other(s) in blink_perf.owp_storage failing on chromium.perf/Android Nexus5X WebView Perf

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Feb 12 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of dtu@chromium.org

blink_perf.owp_storage/blob-build-all-then-read-parallel-files.html and 1 other(s) in blink_perf.owp_storage failing on chromium.perf/Android Nexus5X WebView Perf

Builders failed on: 
- Android Nexus5X WebView Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20WebView%20Perf


 

Comment 1 by dtu@chromium.org, Feb 12 2018

It's a consistent failure. It passed in build 1103 and started failing on build 1104.
https://ci.chromium.org/buildbot/chromium.perf/Android%20Nexus5X%20WebView%20Perf/1103
https://ci.chromium.org/buildbot/chromium.perf/Android%20Nexus5X%20WebView%20Perf/1104

There are two failing stories:
* blink_perf.owp_storage/blob-build-all-then-read-parallel-files.html
* blink_perf.owp_storage/blob-build-all-then-read-parallel-shm.html

The range is r534541 to r534674, 132 changes.

Comment 3 by dtu@chromium.org, Feb 13 2018

Cc: oysteine@google.com
 Issue 810639  has been merged into this issue.
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Feb 13 2018

Cc: nedngu...@google.com pwnall@chromium.org dmu...@chromium.org
Owner: dmu...@chromium.org
Status: Assigned (was: Available)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/11972ff5840000

[BlobStorage] Adding size configurations to perftests by dmurph@chromium.org
https://chromium.googlesource.com/chromium/src/+/1131391c410a6d01c584c4449accc7e1b1258b06

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 5 by dtu@chromium.org, Feb 13 2018

Hey dmurph, looks like some of the new tests you added are failing on the perf bots. Ptal!

* blob-build-all-then-read-parallel-files.html
* blob-build-all-then-read-parallel-shm.html

Comment 6 by dtu@chromium.org, Feb 13 2018

 Issue 811518  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd9b5527f101d1bc312ac29677f38b20dfe35473

commit fd9b5527f101d1bc312ac29677f38b20dfe35473
Author: Ned Nguyen <nednguyen@google.com>
Date: Wed Feb 14 03:09:31 2018

Revert "[BlobStorage] Adding size configurations to perftests"

This reverts commit 1131391c410a6d01c584c4449accc7e1b1258b06.

Reason for revert: Causes lot of failures on perf waterfall

Bug:  811519 

Original change's description:
> [BlobStorage] Adding size configurations to perftests
> 
> Bug:  782356 
> Change-Id: I571b3780b314517097585af1dd488f360511ef80
> Reviewed-on: https://chromium-review.googlesource.com/757168
> Commit-Queue: Daniel Murphy <dmurph@chromium.org>
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Cr-Commit-Position: refs/heads/master@{#534608}

TBR=dmurph@chromium.org,nednguyen@google.com,pwnall@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  782356 
Change-Id: I75ec6a28c55ac99dba7357c3b8771f8429ca1978
Reviewed-on: https://chromium-review.googlesource.com/917801
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#536631}
[modify] https://crrev.com/fd9b5527f101d1bc312ac29677f38b20dfe35473/storage/browser/blob/blob_memory_controller.cc
[modify] https://crrev.com/fd9b5527f101d1bc312ac29677f38b20dfe35473/third_party/WebKit/PerformanceTests/OWPStorage/README.md
[delete] https://crrev.com/7dbc461d4d621ec0aa14c1aa8408fac0216d46ad/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-parallel-files.html
[delete] https://crrev.com/7dbc461d4d621ec0aa14c1aa8408fac0216d46ad/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-parallel-ipc.html
[delete] https://crrev.com/7dbc461d4d621ec0aa14c1aa8408fac0216d46ad/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-parallel-shm.html
[modify] https://crrev.com/fd9b5527f101d1bc312ac29677f38b20dfe35473/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-parallel.html
[delete] https://crrev.com/7dbc461d4d621ec0aa14c1aa8408fac0216d46ad/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-serially-files.html
[delete] https://crrev.com/7dbc461d4d621ec0aa14c1aa8408fac0216d46ad/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-serially-ipc.html
[delete] https://crrev.com/7dbc461d4d621ec0aa14c1aa8408fac0216d46ad/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-serially-shm.html
[modify] https://crrev.com/fd9b5527f101d1bc312ac29677f38b20dfe35473/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-serially.html
[delete] https://crrev.com/7dbc461d4d621ec0aa14c1aa8408fac0216d46ad/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-and-read-immediately-files.html
[delete] https://crrev.com/7dbc461d4d621ec0aa14c1aa8408fac0216d46ad/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-and-read-immediately-ipc.html
[delete] https://crrev.com/7dbc461d4d621ec0aa14c1aa8408fac0216d46ad/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-and-read-immediately-shm.html
[modify] https://crrev.com/fd9b5527f101d1bc312ac29677f38b20dfe35473/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-and-read-immediately.html
[modify] https://crrev.com/fd9b5527f101d1bc312ac29677f38b20dfe35473/tools/perf/benchmarks/blink_perf.py

Status: Fixed (was: Assigned)

Sign in to add a comment